)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"59a05fc18b9836ff22b0f6f5b73395fe00cc327d","unresolved":false,"context_lines":[{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    def search_servers("},{"line_number":1578,"context_line":"            self, name_or_id\u003dNone, filters\u003dNone, detailed\u003dFalse,"},{"line_number":1579,"context_line":"            all_projects\u003dFalse):"},{"line_number":1580,"context_line":"        servers \u003d self.list_servers("},{"line_number":1581,"context_line":"            detailed\u003ddetailed, all_projects\u003dall_projects)"},{"line_number":1582,"context_line":"        return _utils._filter_list(servers, name_or_id, filters)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_cd758bfa","line":1579,"updated":"2017-02-14 18:35:58.000000000","message":"You should add a **params here instead. There\u0027s a lot of paramers/query string that you can pass to http://developer.openstack.org/api-ref/compute/?expanded\u003dlist-servers-detail\n\nWhat if I want to search for a specific tenant_id or for deleted servers too ? Are we going to add several arguments to this seach_servers() method ?\n\nIn Tempest we settled for **params here: https://github.com/openstack/tempest/blob/master/tempest/lib/services/compute/servers_client.py#L139 It\u0027s flexible and future-proof.","commit_id":"d2df08ecd82da45b2cb0076978f9c3342aa1540e"}],"shade/tests/unit/test_shade.py":[{"author":{"_account_id":24647,"name":"Roberto Polli","email":"robipolli@gmail.com","username":"ioggstream"},"change_message_id":"d25be323ccabc024ed4e9ff2d4c54c3c440e392b","unresolved":false,"context_lines":[{"line_number":594,"context_line":"            fakes.FakeServer(\u0027server2\u0027, \u0027\u0027, \u0027ACTIVE\u0027),"},{"line_number":595,"context_line":"        ]"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        r \u003d self.cloud.list_servers(all_projects\u003dTrue)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        mock_nova_client.servers.list.assert_called_with(all_tenants\u003d1)"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_665fce41","line":597,"updated":"2017-02-11 16:14:18.000000000","message":"r is unused and fails pep8.\n\nThis patch is tainting the refactor of demo_cloud too.","commit_id":"049c799268dcb850a76856875c0899ab2512feec"}]}
