)]}'
{"shade/_utils.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2dfd1a28fc484b432d2450a46974931eea3fe34e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            if ((e_id and e_id \u003d\u003d name_or_id) or"},{"line_number":129,"context_line":"                    (e_name and e_name \u003d\u003d name_or_id)):"},{"line_number":130,"context_line":"                identifier_matches.append(e)"},{"line_number":131,"context_line":"            elif ((e_id and fnmatch.fnmatch(e_id, name_or_id)) or"},{"line_number":132,"context_line":"                    (e_name and fnmatch.fnmatch(e_name, name_or_id))):"},{"line_number":133,"context_line":"                identifier_matches.append(e)"},{"line_number":134,"context_line":"        data \u003d identifier_matches"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_edab78d4","line":131,"updated":"2017-03-08 22:37:55.000000000","message":"I think this doesn\u0027t work because it turns a valid non-match into an error.  \n\nWith extant code, if \"[2017-01-01]\" doesn\u0027t match we loop to the next one.  Putting fnmatch() in there turns this into an (fairly obscure) raised error because it thinks the stuff between the \"[]\" is a character class.\n\nit\u0027s kind of tricky because the user would have to know to use fnmatch style escaping where you do the trick of putting the character in a single character class.  so you\u0027d do \"[[]2017-01-1]\".  python 3.something has an escape() function to do this but otherwise you\u0027re on your own.\n\nalso the automatic case-conversion part of fnmatch() based on OS seemed wrong as it\u0027s a bit non-deterministic.","commit_id":"56f9ef90f19180929cdda04913446858e0bf1b8c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"912ae04130015bd6850bb9066feccd8cd5cdecdc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    # but log it in case the user DID pass a pattern but did"},{"line_number":146,"context_line":"                    # it poorly and wants to know what went wrong with their"},{"line_number":147,"context_line":"                    # search"},{"line_number":148,"context_line":"                    log.debug(\"Bad pattern passed to fnmatch\", exc_info\u003dTrue)"},{"line_number":149,"context_line":"        data \u003d identifier_matches"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if not filters:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_572bfd93","line":148,"updated":"2017-03-09 23:17:57.000000000","message":"just a thought that this should probably be a one-shot error for the loop.  if you\u0027ve got a big list of things, this could be really spammy if it fires on every iteration","commit_id":"dee0749330a0c9d6b99553b97467c3b2457e5ce0"}],"shade/tests/unit/test__utils.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2dfd1a28fc484b432d2450a46974931eea3fe34e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        ret \u003d _utils._filter_list(data, \u0027donald\u0027, None)"},{"line_number":43,"context_line":"        self.assertEqual([el1], ret)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test__filter_list_name_or_id_special(self):"},{"line_number":46,"context_line":"        el1 \u003d dict(id\u003d100, name\u003d\u0027donald\u0027)"},{"line_number":47,"context_line":"        el2 \u003d dict(id\u003d200, name\u003d\u0027pluto[2017-01-10]\u0027)"},{"line_number":48,"context_line":"        data \u003d [el1, el2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_aaec0690","side":"PARENT","line":45,"updated":"2017-03-08 22:37:55.000000000","message":"I think removing this test has hidden the failure mode i mentioned in the other comment; i think this is a valid test for images with special chars and it does fail with this code (i did test :)","commit_id":"7883171eca469ab0314369d11c1e401e284ec66e"}]}
