)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3f2d059f687870ebdddf1c90ebf01a2f04e37652","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"                        if \u0027rel\u0027 in l and \u0027next\u0027 \u003d\u003d l[\u0027rel\u0027]:"},{"line_number":1607,"context_line":"                            endpoint \u003d l[\u0027href\u0027]"},{"line_number":1608,"context_line":"                            break"},{"line_number":1609,"context_line":"                    if endpoint:"},{"line_number":1610,"context_line":"                        _list(self._volume_client.get(endpoint))"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        if not cache:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_9f48665c","line":1609,"range":{"start_line":1609,"start_character":20,"end_line":1609,"end_character":32},"updated":"2017-05-22 23:21:19.000000000","message":"It might be just my eyes, but ... is it possible for endpoint to not be set at all causing a NameError here? This could happen in the case of \u0027rel\u0027 not being in l at all. Suggest setting \"endpoint\" to None before the for loop (at least).","commit_id":"0135357348d5318db2dc96de6a95f68fff88d910"},{"author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"change_message_id":"75e4b0bafbadb385fb34b1bcffd81e77159aa2b7","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"                        if \u0027rel\u0027 in l and \u0027next\u0027 \u003d\u003d l[\u0027rel\u0027]:"},{"line_number":1607,"context_line":"                            endpoint \u003d l[\u0027href\u0027]"},{"line_number":1608,"context_line":"                            break"},{"line_number":1609,"context_line":"                    if endpoint:"},{"line_number":1610,"context_line":"                        _list(self._volume_client.get(endpoint))"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        if not cache:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_a2e42d3d","line":1609,"range":{"start_line":1609,"start_character":20,"end_line":1609,"end_character":32},"in_reply_to":"ff0f0b1f_9f48665c","updated":"2017-05-23 00:25:33.000000000","message":"Hi Morgan,\nlooking at the cinder code my understanding is that when `volumes_list` is in the response, \u0027href\u0027 is always defined(it means that the response includes just a part of the volumes list and href is generated so that it includes the `marker`). When the last volumes are sent, the response only includes the `volumes` list.\nhttps://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L160\nhttps://github.com/openstack/cinder/blob/master/cinder/api/common.py#L325\nhttps://github.com/openstack/cinder/blob/master/cinder/api/common.py#L358\nBut it\u0027s definitely safer default it to None. Thx","commit_id":"0135357348d5318db2dc96de6a95f68fff88d910"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8875a48f13036907055ac0ca604269b7b9ec98a1","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"                        if \u0027rel\u0027 in l and \u0027next\u0027 \u003d\u003d l[\u0027rel\u0027]:"},{"line_number":1607,"context_line":"                            endpoint \u003d l[\u0027href\u0027]"},{"line_number":1608,"context_line":"                            break"},{"line_number":1609,"context_line":"                    if endpoint:"},{"line_number":1610,"context_line":"                        _list(self._volume_client.get(endpoint))"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        if not cache:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_9a54dbff","line":1609,"range":{"start_line":1609,"start_character":20,"end_line":1609,"end_character":32},"in_reply_to":"ff0f0b1f_a2e42d3d","updated":"2017-05-23 15:06:34.000000000","message":"Nice! Ty for confirming. This makes me feel better, but lets be defensive (agreed!). Thanks for addressing.","commit_id":"0135357348d5318db2dc96de6a95f68fff88d910"}]}