)]}'
{"shade/operatorcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"4616e681991ea366428580f42c8d64890d3b20b6","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        :raise OpenStackCloudException: if the domain cannot be created."},{"line_number":1090,"context_line":"        \"\"\""},{"line_number":1091,"context_line":"        with _utils.shade_exceptions(\"Failed to create domain {name}\".format("},{"line_number":1092,"context_line":"                name\u003dname)):"},{"line_number":1093,"context_line":"            domain_ref \u003d {\u0027name\u0027: name, \u0027enabled\u0027: enabled}"},{"line_number":1094,"context_line":"            if description is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_95f48ef2","line":1091,"updated":"2017-06-27 21:22:12.000000000","message":"Delete this","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f8984bcedfafe7224fd7f06c74bcd84d3d9bba82","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        :raise OpenStackCloudException: if the domain cannot be created."},{"line_number":1090,"context_line":"        \"\"\""},{"line_number":1091,"context_line":"        with _utils.shade_exceptions(\"Failed to create domain {name}\".format("},{"line_number":1092,"context_line":"                name\u003dname)):"},{"line_number":1093,"context_line":"            domain_ref \u003d {\u0027name\u0027: name, \u0027enabled\u0027: enabled}"},{"line_number":1094,"context_line":"            if description is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_b50d4ae9","line":1091,"in_reply_to":"5f201791_95f48ef2","updated":"2017-06-27 21:38:47.000000000","message":"Done","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"4616e681991ea366428580f42c8d64890d3b20b6","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"        \"\"\""},{"line_number":1091,"context_line":"        with _utils.shade_exceptions(\"Failed to create domain {name}\".format("},{"line_number":1092,"context_line":"                name\u003dname)):"},{"line_number":1093,"context_line":"            domain_ref \u003d {\u0027name\u0027: name, \u0027enabled\u0027: enabled}"},{"line_number":1094,"context_line":"            if description is not None:"},{"line_number":1095,"context_line":"                domain_ref[\u0027description\u0027] \u003d description"},{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_95cdaeb8","line":1093,"updated":"2017-06-27 21:22:12.000000000","message":"You could put description and enabled into kwargs and then add a valid_kwargs decorator with description and enabled in it if you want. - then you\u0027ll only get a kwargs with description or enabled if they were passed, but people can\u0027t pass other things.","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f8984bcedfafe7224fd7f06c74bcd84d3d9bba82","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"        \"\"\""},{"line_number":1091,"context_line":"        with _utils.shade_exceptions(\"Failed to create domain {name}\".format("},{"line_number":1092,"context_line":"                name\u003dname)):"},{"line_number":1093,"context_line":"            domain_ref \u003d {\u0027name\u0027: name, \u0027enabled\u0027: enabled}"},{"line_number":1094,"context_line":"            if description is not None:"},{"line_number":1095,"context_line":"                domain_ref[\u0027description\u0027] \u003d description"},{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_15d4fee7","line":1093,"in_reply_to":"5f201791_95cdaeb8","updated":"2017-06-27 21:38:47.000000000","message":"Nope. Today one can call this as:\n\n     create_domain(\u0027name\u0027, \u0027desc\u0027, False)\n\nChanging to kwargs would require them to\n\n    create_domain(\u0027name\u0027, description\u003d\u0027desc\u0027, enabled\u003dFalse)","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ff8b28efec775b7e253e305e52e26b36c92df4f8","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            if description is not None:"},{"line_number":1095,"context_line":"                domain_ref[\u0027description\u0027] \u003d description"},{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"},{"line_number":1097,"context_line":"                                              json\u003d{\u0027domain\u0027: domain_ref})"},{"line_number":1098,"context_line":"            domain \u003d meta.get_and_munchify(\u0027domain\u0027, data)"},{"line_number":1099,"context_line":"        return _utils.normalize_domains([domain])[0]"},{"line_number":1100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_40375b00","line":1097,"updated":"2017-06-27 17:39:57.000000000","message":"This is returning a munch object already. Why?","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"4616e681991ea366428580f42c8d64890d3b20b6","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            if description is not None:"},{"line_number":1095,"context_line":"                domain_ref[\u0027description\u0027] \u003d description"},{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"},{"line_number":1097,"context_line":"                                              json\u003d{\u0027domain\u0027: domain_ref})"},{"line_number":1098,"context_line":"            domain \u003d meta.get_and_munchify(\u0027domain\u0027, data)"},{"line_number":1099,"context_line":"        return _utils.normalize_domains([domain])[0]"},{"line_number":1100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_55da7677","line":1097,"in_reply_to":"5f201791_40375b00","updated":"2017-06-27 21:22:12.000000000","message":"You need to add \u0027domain\u0027 to the list of keys in shade/_adapter.py in _munchify_response.\n\npass error_message\u003d\"Failed to create domain {name}\".format(name\u003dname) as a parameter here.","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f8984bcedfafe7224fd7f06c74bcd84d3d9bba82","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            if description is not None:"},{"line_number":1095,"context_line":"                domain_ref[\u0027description\u0027] \u003d description"},{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"},{"line_number":1097,"context_line":"                                              json\u003d{\u0027domain\u0027: domain_ref})"},{"line_number":1098,"context_line":"            domain \u003d meta.get_and_munchify(\u0027domain\u0027, data)"},{"line_number":1099,"context_line":"        return _utils.normalize_domains([domain])[0]"},{"line_number":1100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_95012e6d","line":1097,"in_reply_to":"5f201791_55da7677","updated":"2017-06-27 21:38:47.000000000","message":"Done","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ff8b28efec775b7e253e305e52e26b36c92df4f8","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                domain_ref[\u0027description\u0027] \u003d description"},{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"},{"line_number":1097,"context_line":"                                              json\u003d{\u0027domain\u0027: domain_ref})"},{"line_number":1098,"context_line":"            domain \u003d meta.get_and_munchify(\u0027domain\u0027, data)"},{"line_number":1099,"context_line":"        return _utils.normalize_domains([domain])[0]"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    def update_domain("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_c00b6b27","line":1098,"updated":"2017-06-27 17:39:57.000000000","message":"Causing this to return an empty list.","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ff8b28efec775b7e253e305e52e26b36c92df4f8","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"            data \u003d self._identity_client.post(\u0027/domains\u0027,"},{"line_number":1097,"context_line":"                                              json\u003d{\u0027domain\u0027: domain_ref})"},{"line_number":1098,"context_line":"            domain \u003d meta.get_and_munchify(\u0027domain\u0027, data)"},{"line_number":1099,"context_line":"        return _utils.normalize_domains([domain])[0]"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    def update_domain("},{"line_number":1102,"context_line":"            self, domain_id\u003dNone, name\u003dNone, description\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_a0062f1f","line":1099,"range":{"start_line":1099,"start_character":15,"end_line":1099,"end_character":49},"updated":"2017-06-27 17:39:57.000000000","message":"And this to be called with [[]]","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"}],"shade/tests/unit/test_domains.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ff8b28efec775b7e253e305e52e26b36c92df4f8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \"Failed to create domain domain_name\""},{"line_number":99,"context_line":"        ):"},{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_601db772","line":101,"range":{"start_line":101,"start_character":73,"end_line":101,"end_character":76},"updated":"2017-06-27 17:39:57.000000000","message":"shade.exc.OpenStackCloudHTTPError will be raised, causing the expected exception (shade.OpenStackCloudException) to not happen, since create_domain will not wrap a Shade exception into another.","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f8984bcedfafe7224fd7f06c74bcd84d3d9bba82","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \"Failed to create domain domain_name\""},{"line_number":99,"context_line":"        ):"},{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_55f7168c","line":101,"range":{"start_line":101,"start_character":73,"end_line":101,"end_character":76},"in_reply_to":"5f201791_15b99e13","updated":"2017-06-27 21:38:47.000000000","message":"Done","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"4616e681991ea366428580f42c8d64890d3b20b6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \"Failed to create domain domain_name\""},{"line_number":99,"context_line":"        ):"},{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_15b99e13","line":101,"range":{"start_line":101,"start_character":73,"end_line":101,"end_character":76},"in_reply_to":"5f201791_601db772","updated":"2017-06-27 21:22:12.000000000","message":"Go ahead and update it. The test suite is more strict than reality is.","commit_id":"2c0f4a71faa236175e4a6bb96c3dbd4f2166e03c"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"84b09f625b981214d2e4ee4d8f3d78446b6503f8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        ):"},{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"},{"line_number":105,"context_line":"        self.assert_calls()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_28153c49","line":102,"updated":"2017-06-28 17:30:14.000000000","message":"POST actually shouldn\u0027t return json on a 409.","commit_id":"0bd02e660ef200a42aebb37e7833490e1da6e6c7"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"1d1990c6e49c4d33f0c2347c064e0676a8dbdb54","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        ):"},{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"},{"line_number":105,"context_line":"        self.assert_calls()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_9941f40e","line":102,"in_reply_to":"5f201791_28153c49","updated":"2017-07-01 14:03:55.000000000","message":"Done","commit_id":"0bd02e660ef200a42aebb37e7833490e1da6e6c7"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"84b09f625b981214d2e4ee4d8f3d78446b6503f8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"},{"line_number":105,"context_line":"        self.assert_calls()"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_0b76fa70","line":103,"updated":"2017-06-28 17:30:14.000000000","message":"validate\u003ddict(json\u003ddomain_data.json_request)\n\nWe should figure out a way to not make this fail silently... but for now just make sure you\u0027re passing validate a dict with a json key that contains the json you want validated.","commit_id":"0bd02e660ef200a42aebb37e7833490e1da6e6c7"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"1d1990c6e49c4d33f0c2347c064e0676a8dbdb54","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.register_uris(["},{"line_number":101,"context_line":"                dict(method\u003d\u0027POST\u0027, uri\u003dself.get_mock_url(), status_code\u003d409,"},{"line_number":102,"context_line":"                     json\u003ddomain_data.json_response,"},{"line_number":103,"context_line":"                     validate\u003ddomain_data.json_request)])"},{"line_number":104,"context_line":"            self.op_cloud.create_domain(\u0027domain_name\u0027)"},{"line_number":105,"context_line":"        self.assert_calls()"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_7944d81b","line":103,"in_reply_to":"5f201791_0b76fa70","updated":"2017-07-01 14:03:55.000000000","message":"Done","commit_id":"0bd02e660ef200a42aebb37e7833490e1da6e6c7"}]}