)]}'
{"shade/tests/functional/test_volume.py":[{"author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"change_message_id":"964c16f8a42a451cbf72641c4cf758bc98c48d3e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            # deletes without wait, then poll until none of them are found"},{"line_number":101,"context_line":"            # in the volume list anymore"},{"line_number":102,"context_line":"            for v in volume:"},{"line_number":103,"context_line":"                self.user_cloud.delete_volume(v, wait\u003dFalse)"},{"line_number":104,"context_line":"            try:"},{"line_number":105,"context_line":"                for count in _utils._iterate_timeout("},{"line_number":106,"context_line":"                        180, \"Timeout waiting for volume cleanup\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_bdda56e6","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":45},"updated":"2017-08-23 22:29:24.000000000","message":"what if we just force-delete here. At this point in the code we are out of the tests, we just want to make the best effort to clean everything up. Can\u0027t we just force-delete instead of try to delete and later to force-delete?.","commit_id":"b05aede84bbcb3707be1c4da0c596844ae1f2a60"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3aeb489d0cc88df3261a3342953d3db6909bf6a6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            # deletes without wait, then poll until none of them are found"},{"line_number":101,"context_line":"            # in the volume list anymore"},{"line_number":102,"context_line":"            for v in volume:"},{"line_number":103,"context_line":"                self.user_cloud.delete_volume(v, wait\u003dFalse)"},{"line_number":104,"context_line":"            try:"},{"line_number":105,"context_line":"                for count in _utils._iterate_timeout("},{"line_number":106,"context_line":"                        180, \"Timeout waiting for volume cleanup\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_096fe592","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":45},"in_reply_to":"7f287b81_bdda56e6","updated":"2017-08-24 06:36:00.000000000","message":"Force delete here will not help in fact and we decided with mordred on IRC to not remove this wait time because thanks that we have some small \"pause\" before running next tests: http://eavesdrop.openstack.org/irclogs/%23openstack-shade/%23openstack-shade.2017-08-22.log.html","commit_id":"b05aede84bbcb3707be1c4da0c596844ae1f2a60"},{"author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"change_message_id":"964c16f8a42a451cbf72641c4cf758bc98c48d3e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                for existing in self.user_cloud.list_volumes():"},{"line_number":122,"context_line":"                    for v in volume:"},{"line_number":123,"context_line":"                        if v[\u0027id\u0027] \u003d\u003d existing[\u0027id\u0027]:"},{"line_number":124,"context_line":"                            self.operator_cloud.delete_volume(v, force\u003dTrue)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_list_volumes_pagination(self):"},{"line_number":127,"context_line":"        \u0027\u0027\u0027Test pagination for list volumes functionality\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3df0a667","line":124,"range":{"start_line":124,"start_character":33,"end_line":124,"end_character":47},"updated":"2017-08-23 22:29:24.000000000","message":"is this self.user_cloud?","commit_id":"b05aede84bbcb3707be1c4da0c596844ae1f2a60"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3aeb489d0cc88df3261a3342953d3db6909bf6a6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                for existing in self.user_cloud.list_volumes():"},{"line_number":122,"context_line":"                    for v in volume:"},{"line_number":123,"context_line":"                        if v[\u0027id\u0027] \u003d\u003d existing[\u0027id\u0027]:"},{"line_number":124,"context_line":"                            self.operator_cloud.delete_volume(v, force\u003dTrue)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_list_volumes_pagination(self):"},{"line_number":127,"context_line":"        \u0027\u0027\u0027Test pagination for list volumes functionality\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_89d63527","line":124,"range":{"start_line":124,"start_character":33,"end_line":124,"end_character":47},"in_reply_to":"7f287b81_3df0a667","updated":"2017-08-24 06:36:00.000000000","message":"no, it has to be \"operator_cloud\" which have got admin privileges, otherwise test was failing in gate because regular user can\u0027t do delete with \"force\".","commit_id":"b05aede84bbcb3707be1c4da0c596844ae1f2a60"}]}