)]}'
{"shade/operatorcloud.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"    @_utils.cache_on_arguments()"},{"line_number":1231,"context_line":"    def list_groups(self, domain_id\u003dNone):"},{"line_number":1232,"context_line":"        \"\"\"List Keystone Groups."},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        :returns: A list of ``munch.Munch`` containing the group description."},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_7cb3650b","line":1232,"updated":"2017-08-28 20:58:26.000000000","message":"maybe You should add info about this domain_id parameter to docstring","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"    @_utils.cache_on_arguments()"},{"line_number":1231,"context_line":"    def list_groups(self, domain_id\u003dNone):"},{"line_number":1232,"context_line":"        \"\"\"List Keystone Groups."},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        :returns: A list of ``munch.Munch`` containing the group description."},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b7a206ad","line":1232,"in_reply_to":"7f287b81_7cb3650b","updated":"2017-08-28 21:46:21.000000000","message":"will do","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"        \"\"\""},{"line_number":1239,"context_line":"        kwargs \u003d {}"},{"line_number":1240,"context_line":"        if domain_id:"},{"line_number":1241,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":1242,"context_line":"        data \u003d self._identity_client.get("},{"line_number":1243,"context_line":"            \u0027/groups\u0027, params\u003dkwargs, error_message\u003d\"Failed to list groups\")"},{"line_number":1244,"context_line":"        return _utils.normalize_groups(self._get_and_munchify(\u0027groups\u0027, data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_5cb8a9e3","line":1241,"updated":"2017-08-28 20:58:26.000000000","message":"You can use _utils.valid_kwargs() decorator and then this \"if\" shouldn\u0027t be necessary","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"a68a995f663ddd394978540f87cd28659faeb338","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"        \"\"\""},{"line_number":1239,"context_line":"        kwargs \u003d {}"},{"line_number":1240,"context_line":"        if domain_id:"},{"line_number":1241,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":1242,"context_line":"        data \u003d self._identity_client.get("},{"line_number":1243,"context_line":"            \u0027/groups\u0027, params\u003dkwargs, error_message\u003d\"Failed to list groups\")"},{"line_number":1244,"context_line":"        return _utils.normalize_groups(self._get_and_munchify(\u0027groups\u0027, data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d10b3b27","line":1241,"in_reply_to":"7f287b81_17ce7a81","updated":"2017-08-30 00:34:37.000000000","message":"i was having failed caching unit tests when i used it originally. I figured out my mistake. switched to _utils.valid_kwargs()","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"        \"\"\""},{"line_number":1239,"context_line":"        kwargs \u003d {}"},{"line_number":1240,"context_line":"        if domain_id:"},{"line_number":1241,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":1242,"context_line":"        data \u003d self._identity_client.get("},{"line_number":1243,"context_line":"            \u0027/groups\u0027, params\u003dkwargs, error_message\u003d\"Failed to list groups\")"},{"line_number":1244,"context_line":"        return _utils.normalize_groups(self._get_and_munchify(\u0027groups\u0027, data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_17ce7a81","line":1241,"in_reply_to":"7f287b81_5cb8a9e3","updated":"2017-08-28 21:46:21.000000000","message":"i didn\u0027t do this and i forget why. i will double check on this","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            \u0027/groups\u0027, params\u003dkwargs, error_message\u003d\"Failed to list groups\")"},{"line_number":1244,"context_line":"        return _utils.normalize_groups(self._get_and_munchify(\u0027groups\u0027, data))"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"    def search_groups(self, name_or_id\u003dNone, filters\u003dNone, domain_id\u003dNone):"},{"line_number":1247,"context_line":"        \"\"\"Search Keystone groups."},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        :param name: Group name or id."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3cd15d24","line":1246,"updated":"2017-08-28 20:58:26.000000000","message":"maybe I\u0027m wrong but I would move domain_id to be declared before filters","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"            \u0027/groups\u0027, params\u003dkwargs, error_message\u003d\"Failed to list groups\")"},{"line_number":1244,"context_line":"        return _utils.normalize_groups(self._get_and_munchify(\u0027groups\u0027, data))"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"    def search_groups(self, name_or_id\u003dNone, filters\u003dNone, domain_id\u003dNone):"},{"line_number":1247,"context_line":"        \"\"\"Search Keystone groups."},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        :param name: Group name or id."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_57b882e3","line":1246,"in_reply_to":"7f287b81_3cd15d24","updated":"2017-08-28 21:46:21.000000000","message":"can\u0027t change the positional arguments","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"        \"\"\"Search Keystone groups."},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        :param name: Group name or id."},{"line_number":1250,"context_line":"        :param filters: A dict containing additional filters to use."},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"        :returns: A list of ``munch.Munch`` containing the group description."},{"line_number":1253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_1ccea181","line":1250,"updated":"2017-08-28 20:58:26.000000000","message":"please add domain_id description here","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"        \"\"\"Search Keystone groups."},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        :param name: Group name or id."},{"line_number":1250,"context_line":"        :param filters: A dict containing additional filters to use."},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"        :returns: A list of ``munch.Munch`` containing the group description."},{"line_number":1253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b78b261d","line":1250,"in_reply_to":"7f287b81_1ccea181","updated":"2017-08-28 21:46:21.000000000","message":"will do","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"        return _utils._filter_list(groups, name_or_id, filters,"},{"line_number":1259,"context_line":"                                   domain_id\u003ddomain_id)"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    def get_group(self, name_or_id, filters\u003dNone, domain_id\u003dNone):"},{"line_number":1262,"context_line":"        \"\"\"Get exactly one Keystone group."},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        :param id: Group name or id."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_fcc63568","line":1261,"updated":"2017-08-28 20:58:26.000000000","message":"Where domain_id is used in this method? I don\u0027t see it anywhere.\nAnd also I would move domain_id before filters","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"        return _utils._filter_list(groups, name_or_id, filters,"},{"line_number":1259,"context_line":"                                   domain_id\u003ddomain_id)"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    def get_group(self, name_or_id, filters\u003dNone, domain_id\u003dNone):"},{"line_number":1262,"context_line":"        \"\"\"Get exactly one Keystone group."},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        :param id: Group name or id."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_17931a5d","line":1261,"in_reply_to":"7f287b81_fcc63568","updated":"2017-08-28 21:46:21.000000000","message":"can\u0027t change the positional arguments\n\ni need to pass domain_id to get_entity, good catch.","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        \"\"\"Get exactly one Keystone group."},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        :param id: Group name or id."},{"line_number":1265,"context_line":"        :param filters: A dict containing additional filters to use."},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        :returns: A ``munch.Munch`` containing the group description."},{"line_number":1268,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_dcc37956","line":1265,"updated":"2017-08-28 20:58:26.000000000","message":"Please add info about domain_id to docstring","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        \"\"\"Get exactly one Keystone group."},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        :param id: Group name or id."},{"line_number":1265,"context_line":"        :param filters: A dict containing additional filters to use."},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        :returns: A ``munch.Munch`` containing the group description."},{"line_number":1268,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d798f275","line":1265,"in_reply_to":"7f287b81_dcc37956","updated":"2017-08-28 21:46:21.000000000","message":"will do","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"        \"\"\"Update an existing group"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        :param string name: New group name."},{"line_number":1310,"context_line":"        :param string description: New group description."},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"        :returns: A ``munch.Munch`` containing the group description."},{"line_number":1313,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_bca2edac","line":1310,"updated":"2017-08-28 20:58:26.000000000","message":"add to docstring","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"        \"\"\"Update an existing group"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        :param string name: New group name."},{"line_number":1310,"context_line":"        :param string description: New group description."},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"        :returns: A ``munch.Munch`` containing the group description."},{"line_number":1313,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f7a9ae7b","line":1310,"in_reply_to":"7f287b81_bca2edac","updated":"2017-08-28 21:46:21.000000000","message":"will do","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f394b590f37c7ee55096762c4073c7411611f925","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"            group_ref[\u0027name\u0027] \u003d name"},{"line_number":1327,"context_line":"        if description:"},{"line_number":1328,"context_line":"            group_ref[\u0027description\u0027] \u003d description"},{"line_number":1329,"context_line":"        if domain:"},{"line_number":1330,"context_line":"            dom \u003d self.get_domain(domain)"},{"line_number":1331,"context_line":"            if not dom:"},{"line_number":1332,"context_line":"                raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_9ca731be","line":1329,"updated":"2017-08-28 20:58:26.000000000","message":"not domain_id?","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e777b2b7321398d88ca3fd1f800a8781219fd0fd","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"            group_ref[\u0027name\u0027] \u003d name"},{"line_number":1327,"context_line":"        if description:"},{"line_number":1328,"context_line":"            group_ref[\u0027description\u0027] \u003d description"},{"line_number":1329,"context_line":"        if domain:"},{"line_number":1330,"context_line":"            dom \u003d self.get_domain(domain)"},{"line_number":1331,"context_line":"            if not dom:"},{"line_number":1332,"context_line":"                raise OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f7c2ce33","line":1329,"in_reply_to":"7f287b81_9ca731be","updated":"2017-08-28 21:46:21.000000000","message":"will fix","commit_id":"1096cfae6899ec9abf17d675cd29fc6e6f2ab077"}]}