)]}'
{"shade/_utils.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7dc38fc2e0469b148ce4f0d97b8de392f38464cc","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    TODO"},{"line_number":531,"context_line":"    \"\"\""},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    log \u003d _log.setup_logging(\u0027shade._retry_on_code\u0027)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    if isinstance(retry_on, int):"},{"line_number":536,"context_line":"        retry_on \u003d [retry_on]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_d103c241","line":533,"updated":"2017-12-04 16:08:40.000000000","message":"Let\u0027s put this one in \u0027shade.http\u0027.","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"27e6a8be08c34004fbb6ac7d8dae8d7647f48559","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    TODO"},{"line_number":531,"context_line":"    \"\"\""},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    log \u003d _log.setup_logging(\u0027shade._retry_on_code\u0027)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    if isinstance(retry_on, int):"},{"line_number":536,"context_line":"        retry_on \u003d [retry_on]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_3ed74e4e","line":533,"in_reply_to":"df87a7cf_d103c241","updated":"2017-12-05 00:41:35.000000000","message":"Done","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7dc38fc2e0469b148ce4f0d97b8de392f38464cc","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        except exc.OpenStackCloudHTTPError as e:"},{"line_number":544,"context_line":"            if (retry_on is not None and"},{"line_number":545,"context_line":"                    e.response.status_code in retry_on):"},{"line_number":546,"context_line":"                log.debug(\u0027Waiting %s seconds to retry\u0027, retry_wait)"},{"line_number":547,"context_line":"                time.sleep(retry_wait)"},{"line_number":548,"context_line":"                continue"},{"line_number":549,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_5163321b","line":546,"updated":"2017-12-04 16:08:40.000000000","message":"Maybe include something like \"Got status_code %s which is retriable, waiting ...\" or something to indicate why we\u0027re retrying?","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"27e6a8be08c34004fbb6ac7d8dae8d7647f48559","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        except exc.OpenStackCloudHTTPError as e:"},{"line_number":544,"context_line":"            if (retry_on is not None and"},{"line_number":545,"context_line":"                    e.response.status_code in retry_on):"},{"line_number":546,"context_line":"                log.debug(\u0027Waiting %s seconds to retry\u0027, retry_wait)"},{"line_number":547,"context_line":"                time.sleep(retry_wait)"},{"line_number":548,"context_line":"                continue"},{"line_number":549,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_fed00653","line":546,"in_reply_to":"df87a7cf_5163321b","updated":"2017-12-05 00:41:35.000000000","message":"Great suggestion, done.","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7dc38fc2e0469b148ce4f0d97b8de392f38464cc","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                log.debug(\u0027Waiting %s seconds to retry\u0027, retry_wait)"},{"line_number":547,"context_line":"                time.sleep(retry_wait)"},{"line_number":548,"context_line":"                continue"},{"line_number":549,"context_line":"            else:"},{"line_number":550,"context_line":"                if kwargs[\u0027error_message\u0027] is None:"},{"line_number":551,"context_line":"                    error_message \u003d str(e)"},{"line_number":552,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_b1e15e9d","line":549,"updated":"2017-12-04 16:08:40.000000000","message":"This can just be:\n\n  else:\n    raise\n\nerror_message should have been passed down so the original exception should be intact, and that way we don\u0027t lose the original traceback.","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"27e6a8be08c34004fbb6ac7d8dae8d7647f48559","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                log.debug(\u0027Waiting %s seconds to retry\u0027, retry_wait)"},{"line_number":547,"context_line":"                time.sleep(retry_wait)"},{"line_number":548,"context_line":"                continue"},{"line_number":549,"context_line":"            else:"},{"line_number":550,"context_line":"                if kwargs[\u0027error_message\u0027] is None:"},{"line_number":551,"context_line":"                    error_message \u003d str(e)"},{"line_number":552,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_fe13260c","line":549,"in_reply_to":"df87a7cf_b1e15e9d","updated":"2017-12-05 00:41:35.000000000","message":"Done","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7dc38fc2e0469b148ce4f0d97b8de392f38464cc","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                raise exc.OpenStackCloudException(error_message)"},{"line_number":555,"context_line":"        # Break out of the loop, since the loop should only continue"},{"line_number":556,"context_line":"        # when we encounter a known connection error."},{"line_number":557,"context_line":"        break"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"def parse_range(value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_3140ee56","line":557,"updated":"2017-12-04 16:08:40.000000000","message":"It\u0027s not important in the calls it\u0027s being used for in this patch, but this should prboably return whatever was returned from the client call above.","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"27e6a8be08c34004fbb6ac7d8dae8d7647f48559","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                raise exc.OpenStackCloudException(error_message)"},{"line_number":555,"context_line":"        # Break out of the loop, since the loop should only continue"},{"line_number":556,"context_line":"        # when we encounter a known connection error."},{"line_number":557,"context_line":"        break"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"def parse_range(value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_9ef8dac4","line":557,"in_reply_to":"df87a7cf_3140ee56","updated":"2017-12-05 00:41:35.000000000","message":"Great catch! Going ahead and changing now.","commit_id":"161219df31a876dc0a69023bb496af05e5fad7fa"}],"shade/tests/unit/test_baremetal_node.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"be166a12ca5d2327465123f3ace0d51483ff3cf7","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        self.assert_calls()"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_set_machine_power_on_with_retires(self):"},{"line_number":557,"context_line":"        # NOTE(TheJulia): This logic ends up testing power on/off and reboot"},{"line_number":558,"context_line":"        # as they all utilize the same helper method."},{"line_number":559,"context_line":"        self.register_uris(["}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_0a7231e4","line":556,"range":{"start_line":556,"start_character":39,"end_line":556,"end_character":46},"updated":"2017-12-05 15:19:56.000000000","message":"nit: s/retires/retries/","commit_id":"44bafb8cdaf86a87c131d5e12ca1a0af6d951ff4"}]}
