)]}'
{"shade/meta.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"21d745aa406915031a273f126c2f0f5956f2d564","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # reachable. Otherwise we\u0027re just debug log spamming on every listing"},{"line_number":223,"context_line":"        # of private ip addresses"},{"line_number":224,"context_line":"        for address in addresses:"},{"line_number":225,"context_line":"            # Return the first one that is reachable"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                connect_socket \u003d socket.socket(family, socket.SOCK_STREAM, 0)"},{"line_number":228,"context_line":"                connect_socket.settimeout(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_cbb3af09","line":225,"updated":"2018-01-16 13:58:33.000000000","message":"Even with the current bug fixed, I\u0027d like to discuss whether the current logic is sane. I may be able to connect to something completely different when trying to connect to the private IP address of an instance. Why doesn\u0027t the code prefer the floating IP when cloud_public\u003d\u003dTrue?","commit_id":"ac98fdc8861d8b4ef4c10e1268d1f2be0d0c4bcf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"21d745aa406915031a273f126c2f0f5956f2d564","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                connect_socket \u003d socket.socket(family, socket.SOCK_STREAM, 0)"},{"line_number":228,"context_line":"                connect_socket.settimeout(1)"},{"line_number":229,"context_line":"                if family \u003d\u003d socket.AF_INET4:"},{"line_number":230,"context_line":"                    connect_socket.connect((address, 22))"},{"line_number":231,"context_line":"                else:"},{"line_number":232,"context_line":"                    connect_socket.connect((address, 22, 0, 0))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_6bfdbbaf","line":229,"updated":"2018-01-16 13:58:33.000000000","message":"I\u0027ve actually wondered whether this case switch is good enough or whether there should be a more generic solution similar to what has been used in https://review.openstack.org/#/c/507823/3/tempest/common/compute.py","commit_id":"ac98fdc8861d8b4ef4c10e1268d1f2be0d0c4bcf"}]}