)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"change_message_id":"bf79a650ba5b672bcfe7d80ccbee7d909991f240","unresolved":false,"context_lines":[{"line_number":7750,"context_line":"                      dns_nameservers\u003dNone, host_routes\u003dNone,"},{"line_number":7751,"context_line":"                      ipv6_ra_mode\u003dNone, ipv6_address_mode\u003dNone,"},{"line_number":7752,"context_line":"                      use_default_subnetpool\u003dFalse,"},{"line_number":7753,"context_line":"                      subnetpool_name_or_id\u003dNone):"},{"line_number":7754,"context_line":"        \"\"\"Create a subnet on a specified network."},{"line_number":7755,"context_line":""},{"line_number":7756,"context_line":"        :param string network_name_or_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbf25_17ee0322","line":7753,"range":{"start_line":7753,"start_character":0,"end_line":7753,"end_character":50},"updated":"2018-03-01 12:52:54.000000000","message":"I\u0027m unsure what\u0027s best here; subnetpool_name_or_id seems to be quite a long variable name.  If I understand the coding guidelines correctly, this is the correct variable name - but I see foo_name_or_id being used relatively infrequently otherwise in the code, the norm is to have a parameter foo that can be either name or id, or a parameter foo_id if only id is accepted.","commit_id":"3dab4e882142485e59ebd9d000b85cdab27bd7f7"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d74b74156c8b67d2bde59032717087653a3cea01","unresolved":false,"context_lines":[{"line_number":7750,"context_line":"                      dns_nameservers\u003dNone, host_routes\u003dNone,"},{"line_number":7751,"context_line":"                      ipv6_ra_mode\u003dNone, ipv6_address_mode\u003dNone,"},{"line_number":7752,"context_line":"                      use_default_subnetpool\u003dFalse,"},{"line_number":7753,"context_line":"                      subnetpool_name_or_id\u003dNone):"},{"line_number":7754,"context_line":"        \"\"\"Create a subnet on a specified network."},{"line_number":7755,"context_line":""},{"line_number":7756,"context_line":"        :param string network_name_or_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbf25_ce71c10e","line":7753,"range":{"start_line":7753,"start_character":0,"end_line":7753,"end_character":50},"in_reply_to":"1f9dbf25_17ee0322","updated":"2018-03-04 15:23:17.000000000","message":"I think subnetpool that takes name or id (or a subnetpool dict) seems better. We should update the coding guidelines I think to reflect that.","commit_id":"3dab4e882142485e59ebd9d000b85cdab27bd7f7"}]}