)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"change_message_id":"cb6eb4716b50262b71ff4d35468a3c90fe87f9af","unresolved":false,"context_lines":[{"line_number":10754,"context_line":"        if user:"},{"line_number":10755,"context_line":"            filters \u003d {}"},{"line_number":10756,"context_line":"            if not is_keystone_v2 and user_domain:"},{"line_number":10757,"context_line":"                filters[\u0027domain_id\u0027] \u003d self.get_domain("},{"line_number":10758,"context_line":"                    name_or_id\u003duser_domain)[\u0027id\u0027]"},{"line_number":10759,"context_line":"            data[\u0027user\u0027] \u003d self.get_user(user, filters\u003dfilters)"},{"line_number":10760,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_21f52dcc","line":10757,"updated":"2018-03-05 14:03:22.000000000","message":"Optimize for speed or code simplicity?  The current code causes a call for the domain list and then an iteration through it to find anything matching the name_or_id - this could be avoided by adding an `if _utils._is_uuid_like(user_domain)`, at the expense of some few more lines of code.  Hm.","commit_id":"67544fa82d559aa9a0a1c21f2d8fba7c3d4d4d59"},{"author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"change_message_id":"3960bfced2faaf61082f73ab6ccc12c73756ce0e","unresolved":false,"context_lines":[{"line_number":10756,"context_line":"            if not is_keystone_v2 and user_domain:"},{"line_number":10757,"context_line":"                filters[\u0027domain_id\u0027] \u003d self.get_domain("},{"line_number":10758,"context_line":"                    name_or_id\u003duser_domain)[\u0027id\u0027]"},{"line_number":10759,"context_line":"            data[\u0027user\u0027] \u003d self.get_user(user, filters\u003dfilters)"},{"line_number":10760,"context_line":""},{"line_number":10761,"context_line":"        if project:"},{"line_number":10762,"context_line":"            filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbf25_66c1d254","line":10759,"range":{"start_line":10759,"start_character":0,"end_line":10759,"end_character":63},"updated":"2018-03-01 22:44:37.000000000","message":"I just did a recheck on my previous work in changeset I43c97981d9e76f595efa2051b17a8425404179c4. Actually this does not solve our problem.\n\nThe functional tests passes fine towards the devstack, the problem in our production environment was that users outside the default domain was not visible by default, hence filtering by domain is pointless, domain_id has to be passed explicitly as a parameter to get_user in order to find users outside the default domain.","commit_id":"67544fa82d559aa9a0a1c21f2d8fba7c3d4d4d59"}]}