)]}'
{"id":"openstack%2Fshade~549744","triplet_id":"openstack%2Fshade~master~I5a93c6f53a176bd53560fa3b31b9ad9738e580dd","project":"openstack/shade","branch":"master","topic":"storyboard_2001302_task_5904","hashtags":[],"change_id":"I5a93c6f53a176bd53560fa3b31b9ad9738e580dd","subject":"Allow grant_role to select users in a different domain","status":"ABANDONED","created":"2018-03-05 11:56:37.000000000","updated":"2018-10-17 14:54:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"781ff30a4974bb546839dd328932c2385fd84a47","_number":549744,"virtual_id_number":549744,"owner":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-03-07 13:13:38.000000000","_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},{"value":1,"date":"2018-03-07 14:04:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-07 14:04:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c23f6cdb3bbd7d8cb404f18ef6780e90552c403f","author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"date":"2018-03-05 11:56:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9bb0c95cfadc5b79adcd2aa0c1a0c88ba919713","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-05 12:44:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/44/549744/1/check/openstack-tox-pep8/9401704/ : SUCCESS in 2m 11s\n- openstack-tox-py27 http://logs.openstack.org/44/549744/1/check/openstack-tox-py27/5765af1/ : SUCCESS in 2m 37s\n- openstack-tox-py35 http://logs.openstack.org/44/549744/1/check/openstack-tox-py35/05df105/ : SUCCESS in 2m 26s\n- openstack-tox-cover http://logs.openstack.org/44/549744/1/check/openstack-tox-cover/bf3d2e2/cover/ : SUCCESS in 3m 34s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/44/549744/1/check/build-openstack-sphinx-docs/a847ecd/html/ : SUCCESS in 2m 38s\n- shade-functional-devstack-tips http://logs.openstack.org/44/549744/1/check/shade-functional-devstack-tips/b880934/ : SUCCESS in 35m 20s\n- shade-functional-devstack-tips-python3 http://logs.openstack.org/44/549744/1/check/shade-functional-devstack-tips-python3/3d96337/ : SUCCESS in 31m 23s\n- shade-tox-py27-tips http://logs.openstack.org/44/549744/1/check/shade-tox-py27-tips/78c3e78/ : SUCCESS in 2m 56s\n- shade-tox-py35-tips http://logs.openstack.org/44/549744/1/check/shade-tox-py35-tips/11fa785/ : SUCCESS in 3m 01s\n- bifrost-integration-tinyipa http://logs.openstack.org/44/549744/1/check/bifrost-integration-tinyipa/6ba631a/ : SUCCESS in 16m 11s\n- bifrost-integration-tinyipa-opensuse-423 http://logs.openstack.org/44/549744/1/check/bifrost-integration-tinyipa-opensuse-423/3ac5929/ : SUCCESS in 17m 05s\n- shade-ansible-devel-functional-devstack http://logs.openstack.org/44/549744/1/check/shade-ansible-devel-functional-devstack/88c1772/ : SUCCESS in 31m 03s (non-voting)\n- shade-ansible-functional-devstack http://logs.openstack.org/44/549744/1/check/shade-ansible-functional-devstack/0580580/ : SUCCESS in 28m 02s\n- shade-functional-devstack http://logs.openstack.org/44/549744/1/check/shade-functional-devstack/252972e/ : SUCCESS in 32m 18s\n- shade-functional-devstack-magnum http://logs.openstack.org/44/549744/1/check/shade-functional-devstack-magnum/acbbf6a/ : SUCCESS in 34m 46s (non-voting)\n- shade-functional-devstack-python3 http://logs.openstack.org/44/549744/1/check/shade-functional-devstack-python3/bbc434a/ : SUCCESS in 41m 28s","accounts_in_message":[],"_revision_number":1},{"id":"3fe7f3746451ebe87935cc9dbad028ff0f293273","author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"date":"2018-03-05 16:18:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"175bb5bd6257d43b44e6fe7832db05ca6ff3bdc0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-05 17:05:20.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/44/549744/2/check/openstack-tox-pep8/c102784/ : SUCCESS in 2m 18s\n- openstack-tox-py27 http://logs.openstack.org/44/549744/2/check/openstack-tox-py27/5fc4924/ : SUCCESS in 2m 53s\n- openstack-tox-py35 http://logs.openstack.org/44/549744/2/check/openstack-tox-py35/78ee498/ : SUCCESS in 2m 50s\n- openstack-tox-cover http://logs.openstack.org/44/549744/2/check/openstack-tox-cover/4ddcbc8/cover/ : SUCCESS in 2m 52s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/44/549744/2/check/build-openstack-sphinx-docs/3299145/html/ : SUCCESS in 2m 47s\n- shade-functional-devstack-tips http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-tips/e6736c3/ : SUCCESS in 33m 34s\n- shade-functional-devstack-tips-python3 http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-tips-python3/0927644/ : SUCCESS in 39m 39s\n- shade-tox-py27-tips http://logs.openstack.org/44/549744/2/check/shade-tox-py27-tips/15639ce/ : SUCCESS in 3m 01s\n- shade-tox-py35-tips http://logs.openstack.org/44/549744/2/check/shade-tox-py35-tips/79379d0/ : SUCCESS in 2m 32s\n- bifrost-integration-tinyipa http://logs.openstack.org/44/549744/2/check/bifrost-integration-tinyipa/6ccba65/ : FAILURE in 5m 28s\n- bifrost-integration-tinyipa-opensuse-423 http://logs.openstack.org/44/549744/2/check/bifrost-integration-tinyipa-opensuse-423/da4f115/ : SUCCESS in 14m 39s\n- shade-ansible-functional-devstack http://logs.openstack.org/44/549744/2/check/shade-ansible-functional-devstack/6316c89/ : SUCCESS in 33m 36s\n- shade-functional-devstack http://logs.openstack.org/44/549744/2/check/shade-functional-devstack/b466d3c/ : SUCCESS in 32m 50s\n- shade-functional-devstack-magnum http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-magnum/4e16a9f/ : SUCCESS in 37m 12s (non-voting)\n- shade-functional-devstack-python3 http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-python3/494296b/ : SUCCESS in 35m 32s\n- shade-ansible-devel-functional-devstack http://logs.openstack.org/44/549744/2/check/shade-ansible-devel-functional-devstack/a1ec4a6/ : SUCCESS in 27m 19s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5356c390211cfc9513d0d1992ce3a78acc836311","author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"date":"2018-03-07 13:13:21.000000000","message":"Patch Set 2:\n\npatch set 2 contains only unit tests, I don\u0027t think the zuul check failure is related to patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b5653515acd6b05533e170d06a0520c7fcf0ea29","author":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"date":"2018-03-07 13:13:38.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"6367edd6146abefc53b87857238a3934d35a75a4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-07 14:04:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/44/549744/2/check/openstack-tox-pep8/f9350a7/ : SUCCESS in 2m 09s\n- openstack-tox-py27 http://logs.openstack.org/44/549744/2/check/openstack-tox-py27/2248ea3/ : SUCCESS in 2m 21s\n- openstack-tox-py35 http://logs.openstack.org/44/549744/2/check/openstack-tox-py35/4a9a821/ : SUCCESS in 2m 46s\n- openstack-tox-cover http://logs.openstack.org/44/549744/2/check/openstack-tox-cover/1bbcfe9/cover/ : SUCCESS in 2m 34s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/44/549744/2/check/build-openstack-sphinx-docs/979191c/html/ : SUCCESS in 3m 08s\n- shade-functional-devstack-tips http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-tips/c0bc5f9/ : SUCCESS in 32m 41s\n- shade-functional-devstack-tips-python3 http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-tips-python3/db10283/ : SUCCESS in 35m 32s\n- shade-tox-py27-tips http://logs.openstack.org/44/549744/2/check/shade-tox-py27-tips/264f561/ : SUCCESS in 2m 52s\n- shade-tox-py35-tips http://logs.openstack.org/44/549744/2/check/shade-tox-py35-tips/3c72956/ : SUCCESS in 2m 43s\n- bifrost-integration-tinyipa http://logs.openstack.org/44/549744/2/check/bifrost-integration-tinyipa/b4781d4/ : SUCCESS in 15m 43s\n- bifrost-integration-tinyipa-opensuse-423 http://logs.openstack.org/44/549744/2/check/bifrost-integration-tinyipa-opensuse-423/9032954/ : SUCCESS in 16m 12s\n- shade-ansible-functional-devstack http://logs.openstack.org/44/549744/2/check/shade-ansible-functional-devstack/553375c/ : SUCCESS in 31m 57s\n- shade-functional-devstack http://logs.openstack.org/44/549744/2/check/shade-functional-devstack/3f8bb78/ : SUCCESS in 34m 31s\n- shade-functional-devstack-magnum http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-magnum/e30338b/ : SUCCESS in 31m 53s (non-voting)\n- shade-functional-devstack-python3 http://logs.openstack.org/44/549744/2/check/shade-functional-devstack-python3/e8f013c/ : SUCCESS in 32m 18s\n- shade-ansible-devel-functional-devstack http://logs.openstack.org/44/549744/2/check/shade-ansible-devel-functional-devstack/c90e3d2/ : SUCCESS in 33m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"09dcd06f8505638ae30c92b2316aa22980a81021","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-10-17 14:54:09.000000000","message":"Abandoned\n\nShade is in maintenance mode and is not accepting new features. New features should be directed to openstasksdk. If this is a bugfix and you feel it has been abandoned in error, please restore the change and the shade team will work with you on it.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5e3fe1a25712516efbf89838bffc1ba6408d1d0e","revisions":{"5b951d91a765fb4b8bbb2c55ef20296187eb78f9":{"kind":"REWORK","_number":1,"created":"2018-03-05 11:56:37.000000000","uploader":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"ref":"refs/changes/44/549744/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/shade","ref":"refs/changes/44/549744/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/shade refs/changes/44/549744/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/shade refs/changes/44/549744/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/shade refs/changes/44/549744/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/shade refs/changes/44/549744/1"}}},"commit":{"parents":[{"commit":"f6d117cd67e43133043016b792fb4d0370ca7811","subject":"Fix proper domain support in user role grants","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/shade/commit/f6d117cd67e43133043016b792fb4d0370ca7811"}]}],"author":{"name":"Tobias Brox","email":"tobias@redpill-linpro.com","date":"2018-03-05 11:34:09.000000000","tz":60},"committer":{"name":"Tobias Brox","email":"tobias@redpill-linpro.com","date":"2018-03-05 11:44:55.000000000","tz":60},"subject":"Allow grant_role to select users in a different domain","message":"Allow grant_role to select users in a different domain\n\nIn our environment the admin user (belonging to the default domain)\nwas unable to grant rights to uses outside the default domain, as the\nget_user method would not find the user without the domain_id\nattribute set.  Adding the domain_id in the filter does not help, as\nit\u0027s only filtering away results from the search.\n\nUnfortunately I have not been able to reproduce this problem in\nfunctional tests against a clean devstack - there the get_user method\nhas no problem finding users in different domains.\n\nThis is a redo of an earlier change that was reverted out by Sam\nYaple, as he wanted to deprecate the domain parameter in favor of\nuser_domain, group_domain and project_domain in the grant methods.\nThe parent changeset fixes that.\n\nUnit tests have been mended to check that the domain_id is passed.\n\nChange-Id: I5a93c6f53a176bd53560fa3b31b9ad9738e580dd\nTask: 5853\nStory: 2001302\nRelated-Id: I7dfb45e5c6c4f7a7318ae6705269dd9d3e6100b2\nRelated-Id: Ia9f0bdf58a0df539d14b14a3b7e368a06ff6ed88\nRelated-Id: I43c97981d9e76f595efa2051b17a8425404179c4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/shade/commit/5b951d91a765fb4b8bbb2c55ef20296187eb78f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/shade/commit/5b951d91a765fb4b8bbb2c55ef20296187eb78f9"}]},"branch":"refs/heads/master"},"5e3fe1a25712516efbf89838bffc1ba6408d1d0e":{"kind":"REWORK","_number":2,"created":"2018-03-05 16:18:45.000000000","uploader":{"_account_id":27338,"name":"Tobias Brox","email":"tobias@redpill-linpro.com","username":"tobixen"},"ref":"refs/changes/44/549744/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/shade","ref":"refs/changes/44/549744/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/shade refs/changes/44/549744/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/shade refs/changes/44/549744/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/shade refs/changes/44/549744/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/shade refs/changes/44/549744/2"}}},"commit":{"parents":[{"commit":"f6d117cd67e43133043016b792fb4d0370ca7811","subject":"Fix proper domain support in user role grants","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/shade/commit/f6d117cd67e43133043016b792fb4d0370ca7811"}]}],"author":{"name":"Tobias Brox","email":"tobias@redpill-linpro.com","date":"2018-03-05 11:34:09.000000000","tz":60},"committer":{"name":"Tobias Brox","email":"tobias@redpill-linpro.com","date":"2018-03-05 16:17:34.000000000","tz":60},"subject":"Allow grant_role to select users in a different domain","message":"Allow grant_role to select users in a different domain\n\nIn our environment the admin user (belonging to the default domain)\nwas unable to grant rights to uses outside the default domain, as the\nget_user method would not find the user without the domain_id\nattribute set.  Adding the domain_id in the filter does not help, as\nit\u0027s only filtering away results from the search.\n\nUnfortunately I have not been able to reproduce this problem in\nfunctional tests against a clean devstack - there the get_user method\nhas no problem finding users in different domains.\n\nThis is a redo of an earlier change that was reverted out by Sam\nYaple, as he wanted to deprecate the domain parameter in favor of\nuser_domain, group_domain and project_domain in the grant methods.\nThe parent changeset fixes that.\n\nUnit tests have been mended to check that the domain_id is passed.\n\nNew unit tests have been added to excersise passing of the\nuser_domain_id, project_domain_id and group_domain_id parameters.\n\nChange-Id: I5a93c6f53a176bd53560fa3b31b9ad9738e580dd\nTask: 5853\nStory: 2001302\nRelated-Id: I7dfb45e5c6c4f7a7318ae6705269dd9d3e6100b2\nRelated-Id: Ia9f0bdf58a0df539d14b14a3b7e368a06ff6ed88\nRelated-Id: I43c97981d9e76f595efa2051b17a8425404179c4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/shade/commit/5e3fe1a25712516efbf89838bffc1ba6408d1d0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/shade/commit/5e3fe1a25712516efbf89838bffc1ba6408d1d0e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}