)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b233a32f526e450a78f16d1adff3e3e4fbf84bd9","unresolved":false,"context_lines":[{"line_number":9383,"context_line":"                    changes\u003dchange_list"},{"line_number":9384,"context_line":"                )"},{"line_number":9385,"context_line":""},{"line_number":9386,"context_line":"    def validate_node(self, uuid):"},{"line_number":9387,"context_line":"        # TODO(TheJulia): There are soooooo many other interfaces"},{"line_number":9388,"context_line":"        # that we can support validating, while these are essential,"},{"line_number":9389,"context_line":"        # we should support more."}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_0d47f34d","line":9386,"updated":"2018-03-07 14:56:11.000000000","message":"Lets add a doc string to this. It looks like we are now just returning the response which is a slightly different behavior.  I guess all is good until there is a doc string ;)","commit_id":"849432f55b7601a0e5d6e6ea3643cc752a796707"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"844e660d59f4ca95430ff89cffed8b283d83db2b","unresolved":false,"context_lines":[{"line_number":9383,"context_line":"                    changes\u003dchange_list"},{"line_number":9384,"context_line":"                )"},{"line_number":9385,"context_line":""},{"line_number":9386,"context_line":"    def validate_node(self, uuid):"},{"line_number":9387,"context_line":"        # TODO(TheJulia): There are soooooo many other interfaces"},{"line_number":9388,"context_line":"        # that we can support validating, while these are essential,"},{"line_number":9389,"context_line":"        # we should support more."}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_b08e6025","line":9386,"in_reply_to":"df7087c5_0d47f34d","updated":"2018-03-07 15:43:19.000000000","message":"Done","commit_id":"849432f55b7601a0e5d6e6ea3643cc752a796707"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c84af2b45fec40980f31b428b61d0d4dfa436e2","unresolved":false,"context_lines":[{"line_number":9405,"context_line":"            \u0027result\u0027, False) or"},{"line_number":9406,"context_line":"            not validate_resp.get("},{"line_number":9407,"context_line":"                \u0027power\u0027, {\u0027result\u0027: False}).get("},{"line_number":9408,"context_line":"                \u0027result\u0027, False)):"},{"line_number":9409,"context_line":"            raise OpenStackCloudException("},{"line_number":9410,"context_line":"                \"ironic node %s failed to validate. \""},{"line_number":9411,"context_line":"                \"(deploy: {}, power: {})\".format("}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_4f914d99","line":9408,"updated":"2018-03-08 09:24:59.000000000","message":"IMO it is little bit unreadable now. Maybe You could do something like:\n\n    deploy \u003d validate_resp.get(\"deploy\", {\u0027result\u0027: False})\n    power \u003d validate_resp.get(\"power\", {\u0027result\u0027: False})\n    if not deploy[\u0027result\u0027] or not power[\u0027result\u0027]:\n        do_something()","commit_id":"807876ab97fe7e0a549eefeeacd6f3bb8d2061ae"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a8b650feb1a6fa384784e49714bdcb6475615f85","unresolved":false,"context_lines":[{"line_number":9405,"context_line":"            \u0027result\u0027, False) or"},{"line_number":9406,"context_line":"            not validate_resp.get("},{"line_number":9407,"context_line":"                \u0027power\u0027, {\u0027result\u0027: False}).get("},{"line_number":9408,"context_line":"                \u0027result\u0027, False)):"},{"line_number":9409,"context_line":"            raise OpenStackCloudException("},{"line_number":9410,"context_line":"                \"ironic node %s failed to validate. \""},{"line_number":9411,"context_line":"                \"(deploy: {}, power: {})\".format("}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_4a35bbd9","line":9408,"in_reply_to":"df7087c5_4f914d99","updated":"2018-03-08 09:56:42.000000000","message":"Done","commit_id":"807876ab97fe7e0a549eefeeacd6f3bb8d2061ae"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c84af2b45fec40980f31b428b61d0d4dfa436e2","unresolved":false,"context_lines":[{"line_number":9410,"context_line":"                \"ironic node %s failed to validate. \""},{"line_number":9411,"context_line":"                \"(deploy: {}, power: {})\".format("},{"line_number":9412,"context_line":"                    validate_resp[\u0027deploy\u0027],"},{"line_number":9413,"context_line":"                    validate_resp[\u0027power\u0027]))"},{"line_number":9414,"context_line":"        return validate_resp"},{"line_number":9415,"context_line":""},{"line_number":9416,"context_line":"    def node_set_provision_state(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_4fbf0dfb","line":9413,"updated":"2018-03-08 09:24:59.000000000","message":"In L9404 and 9407 You are using get() with some default value in case when \u0027deploy\u0027 or \u0027power\u0027 keys are not there but here You assume that both keys are always in validate_resp. Please do it consistent in all places :)","commit_id":"807876ab97fe7e0a549eefeeacd6f3bb8d2061ae"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a8b650feb1a6fa384784e49714bdcb6475615f85","unresolved":false,"context_lines":[{"line_number":9410,"context_line":"                \"ironic node %s failed to validate. \""},{"line_number":9411,"context_line":"                \"(deploy: {}, power: {})\".format("},{"line_number":9412,"context_line":"                    validate_resp[\u0027deploy\u0027],"},{"line_number":9413,"context_line":"                    validate_resp[\u0027power\u0027]))"},{"line_number":9414,"context_line":"        return validate_resp"},{"line_number":9415,"context_line":""},{"line_number":9416,"context_line":"    def node_set_provision_state(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_0a4d8371","line":9413,"in_reply_to":"df7087c5_4fbf0dfb","updated":"2018-03-08 09:56:42.000000000","message":"Done","commit_id":"807876ab97fe7e0a549eefeeacd6f3bb8d2061ae"}],"shade/tests/unit/test_baremetal_node.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c84af2b45fec40980f31b428b61d0d4dfa436e2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                 json\u003dvalidate_return),"},{"line_number":143,"context_line":"        ])"},{"line_number":144,"context_line":"        self.assertRaises("},{"line_number":145,"context_line":"            exc.OpenStackCloudException,"},{"line_number":146,"context_line":"            self.op_cloud.validate_node,"},{"line_number":147,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027])"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_af47c91d","line":145,"updated":"2018-03-08 09:24:59.000000000","message":"shouldn\u0027t You also validate error message here?","commit_id":"807876ab97fe7e0a549eefeeacd6f3bb8d2061ae"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a8b650feb1a6fa384784e49714bdcb6475615f85","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                 json\u003dvalidate_return),"},{"line_number":143,"context_line":"        ])"},{"line_number":144,"context_line":"        self.assertRaises("},{"line_number":145,"context_line":"            exc.OpenStackCloudException,"},{"line_number":146,"context_line":"            self.op_cloud.validate_node,"},{"line_number":147,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027])"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_2a52c714","line":145,"in_reply_to":"df7087c5_af47c91d","updated":"2018-03-08 09:56:42.000000000","message":"Done","commit_id":"807876ab97fe7e0a549eefeeacd6f3bb8d2061ae"}]}