)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5120b42ef528ada2149b6b34141a23c27cd0b56c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For instance on call to cloud.node_set_provision_state(uuid, \u0027dummy\u0027)"},{"line_number":10,"context_line":"the API currently only returns:"},{"line_number":11,"context_line":"(400) Client Error for url: http://127.0.0.1:6385/v1/nodes/a25aef66-50d5-411d-b0c7-491dfbb0d6f8/states/provision Bad Request"},{"line_number":12,"context_line":"whereas the HTTP request also contains some more valuable information in the body:"},{"line_number":13,"context_line":"The requested action \"dummy\" can not be performed on node \"a25aef66-50d5-411d-b0c7-491dfbb0d6f8\" while it is in state \"enroll\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8412a2fd4ba78ad4f43ac2f13b1404dd3c151ce5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_3f73f482","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":126},"updated":"2018-03-07 22:43:33.000000000","message":"please make lines up to 72 chars according to https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a3a9124d53babbf576f4768093aff3aa9b3c3894","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For instance on call to cloud.node_set_provision_state(uuid, \u0027dummy\u0027)"},{"line_number":10,"context_line":"the API currently only returns:"},{"line_number":11,"context_line":"(400) Client Error for url: http://127.0.0.1:6385/v1/nodes/a25aef66-50d5-411d-b0c7-491dfbb0d6f8/states/provision Bad Request"},{"line_number":12,"context_line":"whereas the HTTP request also contains some more valuable information in the body:"},{"line_number":13,"context_line":"The requested action \"dummy\" can not be performed on node \"a25aef66-50d5-411d-b0c7-491dfbb0d6f8\" while it is in state \"enroll\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8412a2fd4ba78ad4f43ac2f13b1404dd3c151ce5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_db2c4749","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":126},"in_reply_to":"df7087c5_3f73f482","updated":"2018-03-08 05:06:52.000000000","message":"Done, sorry about this","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"}],"shade/exc.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c821c40e9bf0df130a7dd4cef5aeee053301fa97","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    except AttributeError:"},{"line_number":142,"context_line":"        if response.reason:"},{"line_number":143,"context_line":"            remote_error +\u003d \" {reason}\".format(reason\u003dresponse.reason)"},{"line_number":144,"context_line":"        try:"},{"line_number":145,"context_line":"            json_resp \u003d json.loads(details[detail_key])"},{"line_number":146,"context_line":"            fault_string \u003d json_resp.get(\u0027faultstring\u0027, None)"},{"line_number":147,"context_line":"            if fault_string:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_2d12f759","line":144,"updated":"2018-03-07 14:54:00.000000000","message":"It would be good to put a unit test in to test that this works, and another test that ensures upon failure we still don\u0027t raise an error.","commit_id":"80af89c9a1d79162bc2fcd71c8227f2a1a3e54fd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5120b42ef528ada2149b6b34141a23c27cd0b56c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            remote_error +\u003d \" {reason}\".format(reason\u003dresponse.reason)"},{"line_number":144,"context_line":"        try:"},{"line_number":145,"context_line":"            json_resp \u003d json.loads(details[detail_key])"},{"line_number":146,"context_line":"            fault_string \u003d json_resp.get(\u0027faultstring\u0027, None)"},{"line_number":147,"context_line":"            if fault_string:"},{"line_number":148,"context_line":"                remote_error +\u003d \" {fault}\".format(fault\u003dfault_string)"},{"line_number":149,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_7f272c66","line":146,"range":{"start_line":146,"start_character":56,"end_line":146,"end_character":60},"updated":"2018-03-07 22:43:33.000000000","message":"You don\u0027t need this None here as it is default value","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a3a9124d53babbf576f4768093aff3aa9b3c3894","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            remote_error +\u003d \" {reason}\".format(reason\u003dresponse.reason)"},{"line_number":144,"context_line":"        try:"},{"line_number":145,"context_line":"            json_resp \u003d json.loads(details[detail_key])"},{"line_number":146,"context_line":"            fault_string \u003d json_resp.get(\u0027faultstring\u0027, None)"},{"line_number":147,"context_line":"            if fault_string:"},{"line_number":148,"context_line":"                remote_error +\u003d \" {fault}\".format(fault\u003dfault_string)"},{"line_number":149,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_3b1b031c","line":146,"range":{"start_line":146,"start_character":56,"end_line":146,"end_character":60},"in_reply_to":"df7087c5_7f272c66","updated":"2018-03-08 05:06:52.000000000","message":"Done","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"}],"shade/tests/unit/test_baremetal_node.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5120b42ef528ada2149b6b34141a23c27cd0b56c","unresolved":false,"context_lines":[{"line_number":874,"context_line":"            exc.OpenStackCloudException,"},{"line_number":875,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":876,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":877,"context_line":"            \u0027dummy\u0027)"},{"line_number":878,"context_line":"        self.assert_calls()"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def test_node_set_provision_state_bad_request_bad_json(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_dfd75823","line":877,"updated":"2018-03-07 22:43:33.000000000","message":"IMO You should verify also message of such raised exception here","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"d0324379401ab8c215ea07cccf4309bb71f06038","unresolved":false,"context_lines":[{"line_number":874,"context_line":"            exc.OpenStackCloudException,"},{"line_number":875,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":876,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":877,"context_line":"            \u0027dummy\u0027)"},{"line_number":878,"context_line":"        self.assert_calls()"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def test_node_set_provision_state_bad_request_bad_json(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_febb39e2","line":877,"in_reply_to":"df7087c5_5b18371c","updated":"2018-03-08 06:36:25.000000000","message":"Done","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a3a9124d53babbf576f4768093aff3aa9b3c3894","unresolved":false,"context_lines":[{"line_number":874,"context_line":"            exc.OpenStackCloudException,"},{"line_number":875,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":876,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":877,"context_line":"            \u0027dummy\u0027)"},{"line_number":878,"context_line":"        self.assert_calls()"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def test_node_set_provision_state_bad_request_bad_json(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_5b18371c","line":877,"in_reply_to":"df7087c5_dfd75823","updated":"2018-03-08 05:06:52.000000000","message":"Definitely agree and I tried to achieve this but did not find any example on how to achieve this in the existing code","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5120b42ef528ada2149b6b34141a23c27cd0b56c","unresolved":false,"context_lines":[{"line_number":893,"context_line":"            exc.OpenStackCloudException,"},{"line_number":894,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":895,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":896,"context_line":"            \u0027dummy\u0027)"},{"line_number":897,"context_line":"        self.assert_calls()"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"    def test_wait_for_baremetal_node_lock_locked(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_9fe1e001","line":896,"updated":"2018-03-07 22:43:33.000000000","message":"ditto","commit_id":"46d3acf145c1462d96f98f4f9fb18487d6007d70"}]}