)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc5a0a60bcc4e4a46ca83d426f0b5d413f2f5f27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds toggle port security on network create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new property, \u0027port_security_enabled\u0027 which is a boolean to enable or disable port_secuirty during network creation. The default behavior will enable port security, security group and anti spoofing will act as before. When the attribute is set to False, security group and anti spoofing are disabled on the ports created on this network."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If984a82ca5f6fb69ee644f4fa84333df09d7f8bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_58e267d7","line":9,"updated":"2018-03-08 20:33:36.000000000","message":"please make lines at max 72 chars long","commit_id":"1b471625bab6d9f251fec52f543c3d7505532f5b"}],"releasenotes/notes/toggle-port-security-f5bc606e82141feb.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"09295f8bd7ad13b581669e7c1755219d90756308","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added a new property, \u0027port_security_enabled\u0027 which is a boolean"},{"line_number":5,"context_line":"    to enable or disable port_secuirty during network creation. The "},{"line_number":6,"context_line":"    default behavior will enable port security, security group and "},{"line_number":7,"context_line":"    anti spoofing will act as before. When the attribute is set to "},{"line_number":8,"context_line":"    False, security group and anti spoofing are disabled on the ports"},{"line_number":9,"context_line":"    created on this network."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df7087c5_5accb688","line":7,"updated":"2018-03-07 23:51:03.000000000","message":"These 3 lines have trailing whitespace so if you need to do another revision it\u0027d be good to fix them.","commit_id":"82a018f4174ef3297a584a256c5b42338cbe4c8f"}],"shade/openstackcloud.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc5a0a60bcc4e4a46ca83d426f0b5d413f2f5f27","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"        if external:"},{"line_number":3478,"context_line":"            network[\u0027router:external\u0027] \u003d True"},{"line_number":3479,"context_line":""},{"line_number":3480,"context_line":"        if not port_security_enabled:"},{"line_number":3481,"context_line":"            network[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":3482,"context_line":""},{"line_number":3483,"context_line":"        data \u003d self._network_client.post(\"/networks.json\","}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_38069388","line":3480,"updated":"2018-03-08 20:33:36.000000000","message":"it means that if someone will pass None as argument it will be disabled in fact. IMO it might be little bit confusing for users","commit_id":"1b471625bab6d9f251fec52f543c3d7505532f5b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d8ad6fce014f4d68049c4506f521e9cefcc2aa21","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"        if external:"},{"line_number":3478,"context_line":"            network[\u0027router:external\u0027] \u003d True"},{"line_number":3479,"context_line":""},{"line_number":3480,"context_line":"        if not port_security_enabled:"},{"line_number":3481,"context_line":"            network[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":3482,"context_line":""},{"line_number":3483,"context_line":"        data \u003d self._network_client.post(\"/networks.json\","}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_a294ad45","line":3480,"in_reply_to":"df7087c5_38069388","updated":"2018-03-09 00:09:57.000000000","message":"This is technically correct but the same can be said for shared or external.  The docstring states it\u0027s a bool parameter and saying \"port_security_enabled\u003dNone\" and getting no port security isn\u0027t *that* confusing is it?\n\nIf it is too confusing how do you suggest this is resolved?","commit_id":"1b471625bab6d9f251fec52f543c3d7505532f5b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f7ee35d895f85fb206da0d78adc9d6d03dfc6db","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"        if external:"},{"line_number":3478,"context_line":"            network[\u0027router:external\u0027] \u003d True"},{"line_number":3479,"context_line":""},{"line_number":3480,"context_line":"        if not port_security_enabled:"},{"line_number":3481,"context_line":"            network[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":3482,"context_line":""},{"line_number":3483,"context_line":"        data \u003d self._network_client.post(\"/networks.json\","}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_849c105e","line":3480,"in_reply_to":"df7087c5_a294ad45","updated":"2018-03-09 08:34:30.000000000","message":"Personally I would make it that if port_security_enabled \u003d None then just don\u0027t send this parameter to Neutron - let\u0027s server choose default option :)","commit_id":"1b471625bab6d9f251fec52f543c3d7505532f5b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ee4bc52013ded607c7cf153e23b9ef544d3472db","unresolved":false,"context_lines":[{"line_number":3481,"context_line":"            if not isinstance(port_security_enabled, bool):"},{"line_number":3482,"context_line":"                raise OpenStackCloudException("},{"line_number":3483,"context_line":"                    \"Parameter \u0027port_security_enabled\u0027 must be a bool\")"},{"line_number":3484,"context_line":"            network[\u0027port_security_enabled\u0027] \u003d port_security_enabled"},{"line_number":3485,"context_line":""},{"line_number":3486,"context_line":"        data \u003d self._network_client.post(\"/networks.json\","},{"line_number":3487,"context_line":"                                         json\u003d{\u0027network\u0027: network})"}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_90120a09","line":3484,"updated":"2018-03-09 11:24:32.000000000","message":"thx :)","commit_id":"5b81959b32c52b37ff1465cc3a8d39c8b3a47dee"}],"shade/tests/functional/test_network.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e7dd79659d3ffb2a6e5980029ebadacc07b051b3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        )"},{"line_number":105,"context_line":"        self.assertIn(\u0027id\u0027, net1)"},{"line_number":106,"context_line":"        self.assertEqual(self.network_name, net1[\u0027name\u0027])"},{"line_number":107,"context_line":"        self.assertTrue(net1[\u0027shared\u0027])"},{"line_number":108,"context_line":"        self.assertTrue(net1[\u0027admin_state_up\u0027])"},{"line_number":109,"context_line":"        self.assertFalse(net1[\u0027router:external\u0027])"},{"line_number":110,"context_line":"        self.assertFalse(net1[\u0027port_security_enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_75f98c7e","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":39},"updated":"2018-03-08 02:30:05.000000000","message":"This can either be omitted or changed to assertFalse()\n\nYou can see the failure here: http://logs.openstack.org/46/550646/2/check/shade-functional-devstack-tips/d4e77b3/job-output.txt.gz#_2018-03-08_00_48_20_578597\n\nWhich basically means we picked a bad test to copy rather than anything major being wrong.  Check you assertions with test_create_network_basic","commit_id":"5552f0d0670a8d5e01e7732f3c19564d8e956bf3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc5a0a60bcc4e4a46ca83d426f0b5d413f2f5f27","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertTrue(net1[\u0027admin_state_up\u0027])"},{"line_number":108,"context_line":"        self.assertFalse(net1[\u0027shared\u0027])"},{"line_number":109,"context_line":"        self.assertFalse(net1[\u0027router:external\u0027])"},{"line_number":110,"context_line":"        self.assertFalse(net1[\u0027port_security_enabled\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_list_networks_filtered(self):"},{"line_number":113,"context_line":"        net1 \u003d self.operator_cloud.create_network(name\u003dself.network_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_78f3ab9f","line":110,"updated":"2018-03-08 20:33:36.000000000","message":"can You also add (maybe to existing test) check that in \"normal\" case port_security is enabled?","commit_id":"1b471625bab6d9f251fec52f543c3d7505532f5b"}]}