)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"2467c28265463c9a29c98e73648216400fcb8810","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"        if get_extra is None:"},{"line_number":1693,"context_line":"            get_extra \u003d self._extra_config[\u0027get_flavor_extra_specs\u0027]"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"        # This method is already cache-decorated. We don\u0027t want to call the"},{"line_number":1696,"context_line":"        # decorated inner-method, we want to call the method it is decorating."},{"line_number":1697,"context_line":"        return connection.Connection.list_flavors.func("},{"line_number":1698,"context_line":"            self, get_extra\u003dget_extra)"},{"line_number":1699,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_8f78d67e","line":1696,"range":{"start_line":1695,"start_character":0,"end_line":1696,"end_character":78},"updated":"2018-07-11 17:23:59.000000000","message":"This seems really funky needing to know such internals. If we ever change how that works in sdk that would cause this code to break, we\u0027d need to release a new shade, too. Any way we can just undecorate the method here and just use sdk\u0027s caching? That may not actually work, but worth asking.","commit_id":"295f540d4592a8963a1b23dc590be1d5a20d6676"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c2955f2fa4912afd6f74b0bb7aa497cdddd8e25a","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"        if get_extra is None:"},{"line_number":1693,"context_line":"            get_extra \u003d self._extra_config[\u0027get_flavor_extra_specs\u0027]"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"        # This method is already cache-decorated. We don\u0027t want to call the"},{"line_number":1696,"context_line":"        # decorated inner-method, we want to call the method it is decorating."},{"line_number":1697,"context_line":"        return connection.Connection.list_flavors.func("},{"line_number":1698,"context_line":"            self, get_extra\u003dget_extra)"},{"line_number":1699,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_a9e8007b","line":1696,"range":{"start_line":1695,"start_character":0,"end_line":1696,"end_character":78},"in_reply_to":"5f7c97a3_8f78d67e","updated":"2018-07-13 11:14:19.000000000","message":"Yeah - I think this is a point-in-time thing. We\u0027ve got cache defined in two places, which is not ideal.\n\nThe next patch in this series should delete the shade caching layer and then most of the methods, leaving only ones where we want to override argument order or something.\n\nThat said - our caching decorators do some fancy things, so we still might have to get clever.","commit_id":"295f540d4592a8963a1b23dc590be1d5a20d6676"}],"shade/tests/unit/test_baremetal_node.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"82579bece78e87592bcee50924b1733826832884","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        ])"},{"line_number":872,"context_line":"        self.assertRaisesRegexp("},{"line_number":873,"context_line":"            exc.OpenStackCloudException,"},{"line_number":874,"context_line":"            \u0027^Baremetal .* to dummy.*/states/provision.*invalid state\u0027,"},{"line_number":875,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":876,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":877,"context_line":"            \u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_cf31eebd","line":874,"range":{"start_line":874,"start_character":0,"end_line":874,"end_character":71},"updated":"2018-07-11 17:27:36.000000000","message":"Why was this change needed?","commit_id":"295f540d4592a8963a1b23dc590be1d5a20d6676"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c2955f2fa4912afd6f74b0bb7aa497cdddd8e25a","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        ])"},{"line_number":872,"context_line":"        self.assertRaisesRegexp("},{"line_number":873,"context_line":"            exc.OpenStackCloudException,"},{"line_number":874,"context_line":"            \u0027^Baremetal .* to dummy.*/states/provision.*invalid state\u0027,"},{"line_number":875,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":876,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":877,"context_line":"            \u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_226519b0","line":874,"range":{"start_line":874,"start_character":0,"end_line":874,"end_character":71},"in_reply_to":"5f7c97a3_cf31eebd","updated":"2018-07-13 11:14:19.000000000","message":"sdk adds a little more information into the exception message based on the requests response (which is nice information) but the string here was too strict to deal with it.","commit_id":"295f540d4592a8963a1b23dc590be1d5a20d6676"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"82579bece78e87592bcee50924b1733826832884","unresolved":false,"context_lines":[{"line_number":891,"context_line":"        ])"},{"line_number":892,"context_line":"        self.assertRaisesRegexp("},{"line_number":893,"context_line":"            exc.OpenStackCloudException,"},{"line_number":894,"context_line":"            \u0027^Baremetal .* to dummy.*/states/provision\u0027,"},{"line_number":895,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":896,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":897,"context_line":"            \u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_ef362ab4","line":894,"range":{"start_line":894,"start_character":0,"end_line":894,"end_character":56},"updated":"2018-07-11 17:27:36.000000000","message":"Ditto on why....","commit_id":"295f540d4592a8963a1b23dc590be1d5a20d6676"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c2955f2fa4912afd6f74b0bb7aa497cdddd8e25a","unresolved":false,"context_lines":[{"line_number":891,"context_line":"        ])"},{"line_number":892,"context_line":"        self.assertRaisesRegexp("},{"line_number":893,"context_line":"            exc.OpenStackCloudException,"},{"line_number":894,"context_line":"            \u0027^Baremetal .* to dummy.*/states/provision\u0027,"},{"line_number":895,"context_line":"            self.op_cloud.node_set_provision_state,"},{"line_number":896,"context_line":"            self.fake_baremetal_node[\u0027uuid\u0027],"},{"line_number":897,"context_line":"            \u0027dummy\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_c2ff85af","line":894,"range":{"start_line":894,"start_character":0,"end_line":894,"end_character":56},"in_reply_to":"5f7c97a3_ef362ab4","updated":"2018-07-13 11:14:19.000000000","message":"Same","commit_id":"295f540d4592a8963a1b23dc590be1d5a20d6676"}]}