)]}'
{"shade/openstackcloud.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"f31c3a78456819ceb432bc172453d5802991dc78","unresolved":false,"context_lines":[{"line_number":3531,"context_line":"            if not isinstance(mtu_size, int):"},{"line_number":3532,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":3533,"context_line":"                    \"Parameter \u0027mtu_size\u0027 must be a integer\")"},{"line_number":3534,"context_line":"            if not mtu_size \u003e\u003d 68:"},{"line_number":3535,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":3536,"context_line":"                    \"Parameter \u0027mtu_size\u0027 must be greater than 67.\")"},{"line_number":3537,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_af8f7b74","line":3534,"range":{"start_line":3534,"start_character":31,"end_line":3534,"end_character":33},"updated":"2018-07-03 07:19:29.000000000","message":"My guess is that it\u0027s not possible to tell if it\u0027s ipv6 here?","commit_id":"eccb09e90767cb4e6ae34be18bfae17fba6bc224"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b86588ba33bfe160098b5060f4053223c73f7a1d","unresolved":false,"context_lines":[{"line_number":3531,"context_line":"            if not isinstance(mtu_size, int):"},{"line_number":3532,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":3533,"context_line":"                    \"Parameter \u0027mtu_size\u0027 must be a integer\")"},{"line_number":3534,"context_line":"            if not mtu_size \u003e\u003d 68:"},{"line_number":3535,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":3536,"context_line":"                    \"Parameter \u0027mtu_size\u0027 must be greater than 67.\")"},{"line_number":3537,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d0462623","line":3534,"range":{"start_line":3534,"start_character":15,"end_line":3534,"end_character":30},"updated":"2018-07-15 21:19:22.000000000","message":"it\u0027s not possible as it is done during subnet creation. Also one network can contain more than one subnet and it might be IPv4 and IPv6 subnets combined together.\nAccording to that I would say that this check is not necessary here and should be removed.","commit_id":"eccb09e90767cb4e6ae34be18bfae17fba6bc224"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b86588ba33bfe160098b5060f4053223c73f7a1d","unresolved":false,"context_lines":[{"line_number":11273,"context_line":"                json\u003ddict(removeProjectAccess\u003dpayload),"},{"line_number":11274,"context_line":"                error_message\u003d\"Unable to revoke {project} \""},{"line_number":11275,"context_line":"                              \"to use volume type {name}\".format("},{"line_number":11276,"context_line":"                    name\u003dname_or_id, project\u003dproject_id))"},{"line_number":11277,"context_line":""},{"line_number":11278,"context_line":"    def set_compute_quotas(self, name_or_id, **kwargs):"},{"line_number":11279,"context_line":"        \"\"\" Set a quota in a project"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_505c56ef","line":11276,"updated":"2018-07-15 21:19:22.000000000","message":"is it related somehow to this patch? (and same question for all other similar changes also)","commit_id":"eccb09e90767cb4e6ae34be18bfae17fba6bc224"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b86588ba33bfe160098b5060f4053223c73f7a1d","unresolved":false,"context_lines":[{"line_number":11346,"context_line":""},{"line_number":11347,"context_line":"        :returns: Munch object with the usage"},{"line_number":11348,"context_line":"        \"\"\""},{"line_number":11349,"context_line":""},{"line_number":11350,"context_line":"        def parse_date(date):"},{"line_number":11351,"context_line":"            try:"},{"line_number":11352,"context_line":"                return iso8601.parse_date(date)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_705f12e4","line":11349,"updated":"2018-07-15 21:19:22.000000000","message":"unrelated change IMO","commit_id":"eccb09e90767cb4e6ae34be18bfae17fba6bc224"}],"shade/tests/unit/test_network.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4894609096690788b3677b10508cb25e22b3de8d","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            self.cloud.create_network(\"netname\","},{"line_number":291,"context_line":"                                      mtu_size\u003dmtu_size"},{"line_number":292,"context_line":"                                      )"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_delete_network(self):"},{"line_number":295,"context_line":"        network_id \u003d \"test-net-id\""},{"line_number":296,"context_line":"        network_name \u003d \"network\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1c7d021d","line":293,"updated":"2018-07-21 08:18:51.000000000","message":"why You removed those 2 unit tests?","commit_id":"186797ed74d5b23f1de14ceb74920edb8e79acc4"}]}
