)]}'
{"shotgun/driver.py":[{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"c990f76c9039c9285f9e8790f7282135a4db5a0d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                        \"Running remote command: host: %s command: %s\","},{"line_number":119,"context_line":"                        self.host, command)"},{"line_number":120,"context_line":"                    try:"},{"line_number":121,"context_line":"                        if self.ssh_user is not \u0027root\u0027:"},{"line_number":122,"context_line":"                            output \u003d fabric.api.sudo(command,"},{"line_number":123,"context_line":"                                                     stdout\u003draw_stdout)"},{"line_number":124,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_5e52b5de","line":121,"updated":"2016-03-01 11:02:34.000000000","message":"Please, do not compare strings using \"is\" operator. It\u0027s incorrect, since in Python implementations without string pool it won\u0027t work.","commit_id":"0d85f09f580a57e6902f804699a7c6f8c297044f"},{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"c990f76c9039c9285f9e8790f7282135a4db5a0d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                        self.host, command)"},{"line_number":120,"context_line":"                    try:"},{"line_number":121,"context_line":"                        if self.ssh_user is not \u0027root\u0027:"},{"line_number":122,"context_line":"                            output \u003d fabric.api.sudo(command,"},{"line_number":123,"context_line":"                                                     stdout\u003draw_stdout)"},{"line_number":124,"context_line":"                        else:"},{"line_number":125,"context_line":"                            output \u003d fabric.api.run(command, stdout\u003draw_stdout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_1ef66dd7","line":122,"updated":"2016-03-01 11:02:34.000000000","message":"I don\u0027t think that \u0027root\u0027 user must be a reason to run every command with \u0027sudo\u0027.\n\nWhat about specifying \u0027sudo\u0027 per command?","commit_id":"0d85f09f580a57e6902f804699a7c6f8c297044f"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"fb0ef4e86aa048010e0b03e9279b61054259900f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                        self.host, command)"},{"line_number":120,"context_line":"                    try:"},{"line_number":121,"context_line":"                        if self.ssh_user is not \u0027root\u0027:"},{"line_number":122,"context_line":"                            output \u003d fabric.api.sudo(command,"},{"line_number":123,"context_line":"                                                     stdout\u003draw_stdout)"},{"line_number":124,"context_line":"                        else:"},{"line_number":125,"context_line":"                            output \u003d fabric.api.run(command, stdout\u003draw_stdout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_d986d464","line":122,"in_reply_to":"7af24918_1ef66dd7","updated":"2016-03-01 13:40:16.000000000","message":"Shotgun executes way too many commands and fetches way too many files. Some of them require sudo and this seems to be a much more cleaner solution IMO.","commit_id":"0d85f09f580a57e6902f804699a7c6f8c297044f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d77d0e0dfac863f4e61d38ed0074b4b002f9ddc4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                        self.host, command)"},{"line_number":120,"context_line":"                    try:"},{"line_number":121,"context_line":"                        if self.ssh_user is not \u0027root\u0027:"},{"line_number":122,"context_line":"                            output \u003d fabric.api.sudo(command,"},{"line_number":123,"context_line":"                                                     stdout\u003draw_stdout)"},{"line_number":124,"context_line":"                        else:"},{"line_number":125,"context_line":"                            output \u003d fabric.api.run(command, stdout\u003draw_stdout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_abfff1a8","line":122,"in_reply_to":"7af24918_530e1535","updated":"2016-03-02 08:21:25.000000000","message":"I agree with Igor 100% percent. Introducing sudo for all commands just because some of them require sudo is way too naive. Let\u0027s leave this up to a shotgun user (nailgun in our case) to provide sudo only for those commands that really need this. In the future shotgun should be extended to support sudo by password, but now we just need to configure sudoers so it is possible to run sudo without password.","commit_id":"0d85f09f580a57e6902f804699a7c6f8c297044f"},{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"b393c1b984c49fe6f0a463100e77b1e7a58fd5d0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                        self.host, command)"},{"line_number":120,"context_line":"                    try:"},{"line_number":121,"context_line":"                        if self.ssh_user is not \u0027root\u0027:"},{"line_number":122,"context_line":"                            output \u003d fabric.api.sudo(command,"},{"line_number":123,"context_line":"                                                     stdout\u003draw_stdout)"},{"line_number":124,"context_line":"                        else:"},{"line_number":125,"context_line":"                            output \u003d fabric.api.run(command, stdout\u003draw_stdout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_530e1535","line":122,"in_reply_to":"7af24918_d986d464","updated":"2016-03-01 16:06:32.000000000","message":"It\u0027s easier way, yes, but it doesn\u0027t look like a right way to me. Shotgun is general tool for fetching files. It may be used even without Fuel.\n\nMoreover, it\u0027s generally not a truth that \u0027root\u0027 user doesn\u0027t require sudo or that any other user will require. Besides, what if user has a password? Who\u0027s responsible to pass it to shotgun? No one.\n\nSo it\u0027s up to Nailgun to provide sudo before commands, as well as user name that has permissions to requested files.","commit_id":"0d85f09f580a57e6902f804699a7c6f8c297044f"},{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"c990f76c9039c9285f9e8790f7282135a4db5a0d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                    logger.debug(\"Getting remote file: %s %s\","},{"line_number":166,"context_line":"                                 path, target_path)"},{"line_number":167,"context_line":"                    try:"},{"line_number":168,"context_line":"                        use_sudo \u003d self.ssh_user is not \u0027root\u0027"},{"line_number":169,"context_line":"                        return fabric.api.get(path, target_path,"},{"line_number":170,"context_line":"                                              use_sudo\u003duse_sudo)"},{"line_number":171,"context_line":"                    except SystemExit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_9e30bda0","line":168,"updated":"2016-03-01 11:02:34.000000000","message":"ditto","commit_id":"0d85f09f580a57e6902f804699a7c6f8c297044f"}]}
