)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"8545ea440a5685165f72d0ca5f4c7d2c7d2287ff","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-03-12 11:43:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: Instance Details for other role than admin"},{"line_number":8,"context_line":"uuid is only valid when specified by administrators."},{"line_number":9,"context_line":"uuid for non-admin is ignored."},{"line_number":10,"context_line":"Change-Id: I5fa5c696514212a2aef82e938d136b51b35b4963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bed31045_5cddedbd","line":8,"updated":"2024-05-08 08:10:09.000000000","message":"Here needs a blank line.","commit_id":"c47b2764f3bef93e04fd2b19b9d94a2eec4f3ce7"},{"author":{"_account_id":36121,"name":"tomasz","display_name":"toch","email":"tomasz_chendynski@polcom.com.pl","username":"Chendynski"},"change_message_id":"4bc4273a153193bc39cdfa7eefa4318a3e569511","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-03-12 11:43:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: Instance Details for other role than admin"},{"line_number":8,"context_line":"uuid is only valid when specified by administrators."},{"line_number":9,"context_line":"uuid for non-admin is ignored."},{"line_number":10,"context_line":"Change-Id: I5fa5c696514212a2aef82e938d136b51b35b4963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"35db8006_68f6530a","line":8,"in_reply_to":"bed31045_5cddedbd","updated":"2024-05-08 10:48:07.000000000","message":"Done","commit_id":"c47b2764f3bef93e04fd2b19b9d94a2eec4f3ce7"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"8545ea440a5685165f72d0ca5f4c7d2c7d2287ff","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: Instance Details for other role than admin"},{"line_number":8,"context_line":"uuid is only valid when specified by administrators."},{"line_number":9,"context_line":"uuid for non-admin is ignored."},{"line_number":10,"context_line":"Change-Id: I5fa5c696514212a2aef82e938d136b51b35b4963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1589df4f_64f4edff","line":9,"updated":"2024-05-08 08:10:09.000000000","message":"If possible, you can open an issue here to discuss.\nhttps://bugs.launchpad.net/skyline-apiserver\n\n:) thanks","commit_id":"c47b2764f3bef93e04fd2b19b9d94a2eec4f3ce7"},{"author":{"_account_id":36121,"name":"tomasz","display_name":"toch","email":"tomasz_chendynski@polcom.com.pl","username":"Chendynski"},"change_message_id":"4bc4273a153193bc39cdfa7eefa4318a3e569511","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: Instance Details for other role than admin"},{"line_number":8,"context_line":"uuid is only valid when specified by administrators."},{"line_number":9,"context_line":"uuid for non-admin is ignored."},{"line_number":10,"context_line":"Change-Id: I5fa5c696514212a2aef82e938d136b51b35b4963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f9d8718_00b482aa","line":9,"in_reply_to":"1589df4f_64f4edff","updated":"2024-05-08 10:48:07.000000000","message":"Done\nhttps://bugs.launchpad.net/skyline-apiserver/+bug/2065159","commit_id":"c47b2764f3bef93e04fd2b19b9d94a2eec4f3ce7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"6c4e99ac08223e244dd34b1120998b58a568d152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"498880ef_e8555114","updated":"2025-03-22 14:49:16.000000000","message":"Can we get this reviewed?","commit_id":"ca8fb83c1853fd82b5984e26e821f0d8659d7082"},{"author":{"_account_id":36121,"name":"tomasz","display_name":"toch","email":"tomasz_chendynski@polcom.com.pl","username":"Chendynski"},"change_message_id":"4bc4273a153193bc39cdfa7eefa4318a3e569511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f3f8faf_cab03bfb","updated":"2024-05-08 10:48:07.000000000","message":"Thank you Boxiang","commit_id":"ca8fb83c1853fd82b5984e26e821f0d8659d7082"},{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"7d4065cf9a124f8c6e0b2590c3ebd932bfd6e160","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35e08f8a_d0c2c9da","updated":"2025-03-26 23:53:17.000000000","message":"Firstly, thanks for your commit. I add bug link in commit message.\n\n1. I do test from web console, however couldn\u0027t reproduce this bug. API return a list rather than one server \u003d\u003d uuid, however skyline console only choose the correct one to show details. So this bug couldn\u0027t be reproduced from my side.\n2. For API itself, skyline logic follow nova is also OK, right?\n\nSo, it also could accept that skyline follow nova, \u0026 this code logic do not cause a  bug as description. I will discuss with other developers later.\n\nCorrect me if wrong, thanks very much!","commit_id":"69ad24ff60485419ddfa4c4dc39ce7bf8b24c6be"},{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"40d5b09db9b355a05c5d3f469881862dfe014ff3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98d43569_74aaa024","in_reply_to":"08479057_88eba56a","updated":"2025-03-28 12:35:29.000000000","message":"Thanks for your description!","commit_id":"69ad24ff60485419ddfa4c4dc39ce7bf8b24c6be"},{"author":{"_account_id":36121,"name":"tomasz","display_name":"toch","email":"tomasz_chendynski@polcom.com.pl","username":"Chendynski"},"change_message_id":"a244103f3328461c18190ad04409381dc3dd1d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"08479057_88eba56a","in_reply_to":"35e08f8a_d0c2c9da","updated":"2025-03-27 17:05:33.000000000","message":"I have conducted the test and can confirm that it works as you said. which surprised me.\n\nThan I found a fix, by jingbest commited in Jul 25, 2024, which in my humble opinion addresses the issue.that\u0027s why it now works as expected.\nopenstack\nskyline-console\n\nCommit 7513e64\n\nhttps://github.com/openstack/skyline-console/commit/7513e64f7c1d7a568539f89f1953c859d938aa3d\n\n\"fix: fix edit instance\nfix edit instance in the instance detail page for the non-admin user\"\n\n\nTherefore, I believe my proposal is redundant and can be closed.\nThank you","commit_id":"69ad24ff60485419ddfa4c4dc39ce7bf8b24c6be"}],"skyline_apiserver/client/openstack/nova.py":[{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"8545ea440a5685165f72d0ca5f4c7d2c7d2287ff","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            sort_dirs\u003dsort_dirs,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        results \u003d []"},{"line_number":54,"context_line":"        for server in servers:"},{"line_number":55,"context_line":"            if search_opts is not None and search_opts.get(\"uuid\") \u003d\u003d server.id:"},{"line_number":56,"context_line":"                return [server]"},{"line_number":57,"context_line":"            results.append(server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c692125_0f4a6dfa","line":54,"updated":"2024-05-08 08:10:09.000000000","message":"why we need to check the uuid here? If the role is non admin, so the uuid parameter will be ignore by nova api. then the servers will be none here.","commit_id":"c47b2764f3bef93e04fd2b19b9d94a2eec4f3ce7"},{"author":{"_account_id":36121,"name":"tomasz","display_name":"toch","email":"tomasz_chendynski@polcom.com.pl","username":"Chendynski"},"change_message_id":"4bc4273a153193bc39cdfa7eefa4318a3e569511","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            sort_dirs\u003dsort_dirs,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        results \u003d []"},{"line_number":54,"context_line":"        for server in servers:"},{"line_number":55,"context_line":"            if search_opts is not None and search_opts.get(\"uuid\") \u003d\u003d server.id:"},{"line_number":56,"context_line":"                return [server]"},{"line_number":57,"context_line":"            results.append(server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"efc76b31_139e444e","line":54,"in_reply_to":"3c692125_0f4a6dfa","updated":"2024-05-08 10:48:07.000000000","message":"Due to the UUID being ignored for non-administrator roles, we get a full list of servers from the current project.Therefore, you need to filter the list.","commit_id":"c47b2764f3bef93e04fd2b19b9d94a2eec4f3ce7"}]}
