)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"773135fd01c57d9c43b4a76be15630fd8d94b8c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"46f4c6de_53ebfd07","updated":"2024-05-24 02:40:48.000000000","message":"quick fix, will check insert/update.where later","commit_id":"ce7d977df497dafd9dd71dbe412e066187ba5d22"}],"skyline_apiserver/db/api.py":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"da57c55c0b95aea32b2298b3541074216ea46f6e","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d insert(Settings).values(key\u003dkey, value\u003dvalue)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5c24c275_9431a9c6","line":109,"range":{"start_line":109,"start_character":20,"end_line":109,"end_character":65},"updated":"2024-05-24 02:36:26.000000000","message":"@Reşit Demir\nThanks for your updates.\nWhy change this line, update.where seems correct, why use insert instead of it?","commit_id":"ce7d977df497dafd9dd71dbe412e066187ba5d22"},{"author":{"_account_id":20865,"name":"Gökhan","email":"gokhan.isik@tubitak.gov.tr","username":"gokhan.isik"},"change_message_id":"0fc6cc7e4d1cc2403b9bd9f74b7a4c99a4dd1768","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d insert(Settings).values(key\u003dkey, value\u003dvalue)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"97a2765d_c031fa07","line":109,"range":{"start_line":109,"start_character":20,"end_line":109,"end_character":65},"in_reply_to":"5c24c275_9431a9c6","updated":"2024-05-24 05:59:38.000000000","message":"Because of below error:\nskyline_apiserver/db/api.py:109:21: error: Incompatible types in assignment\n(expression has type \"Update\", variable has type \"Insert\")  [assignment]\n                query \u003d update(Settings).where(Settings.c.key \u003d\u003d key)","commit_id":"ce7d977df497dafd9dd71dbe412e066187ba5d22"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"83a226987163cec8cd5549a0b2bb225063cb3f2c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d insert(Settings).values(key\u003dkey, value\u003dvalue)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d38b390b_1a5dff74","line":109,"range":{"start_line":109,"start_character":20,"end_line":109,"end_character":65},"in_reply_to":"97a2765d_c031fa07","updated":"2024-05-24 06:45:55.000000000","message":"But when I test with the insert, if the setting exists, it will add a new data into DB.","commit_id":"ce7d977df497dafd9dd71dbe412e066187ba5d22"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"e9ad220d4745312f645041eb7695f61d48bcd909","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d insert(Settings).values(key\u003dkey, value\u003dvalue)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"365b5160_daf0f417","line":109,"range":{"start_line":109,"start_character":20,"end_line":109,"end_character":65},"in_reply_to":"d38b390b_1a5dff74","updated":"2024-05-24 07:05:57.000000000","message":"@Gökhan, fix here: https://review.opendev.org/c/openstack/skyline-apiserver/+/920372","commit_id":"ce7d977df497dafd9dd71dbe412e066187ba5d22"}]}