)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20865,"name":"Gökhan","email":"gokhan.isik@tubitak.gov.tr","username":"gokhan.isik"},"change_message_id":"6ee17b71290c42fcce82b2aa63032704fb52d84a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d7db92b_a4f6d9a7","updated":"2024-05-24 07:06:54.000000000","message":"mypy will give error for type consistency.","commit_id":"1732ccaae3b45455a3f1e2f55ad4131bf8f7ed31"}],"skyline_apiserver/db/api.py":[{"author":{"_account_id":20865,"name":"Gökhan","email":"gokhan.isik@tubitak.gov.tr","username":"gokhan.isik"},"change_message_id":"6ee17b71290c42fcce82b2aa63032704fb52d84a","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d update(Settings).where(Settings.c.key \u003d\u003d key)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dd6a0229_c74eb196","line":109,"updated":"2024-05-24 07:06:54.000000000","message":"using query variable for both insert and update operation leads to type inconsistency. you can try like below:\nif is_exist is None:\n            insert_query \u003d insert(Settings).values(key\u003dkey, value\u003dvalue)\n            await db.execute(insert_query)\n        else:\n            update_query \u003d update(Settings).where(Settings.c.key \u003d\u003d key).values(value\u003dvalue)\n            await db.execute(update_query)","commit_id":"1732ccaae3b45455a3f1e2f55ad4131bf8f7ed31"},{"author":{"_account_id":20865,"name":"Gökhan","email":"gokhan.isik@tubitak.gov.tr","username":"gokhan.isik"},"change_message_id":"63ef75ac2eef8dacf9f7d0cbdb314b886af0b06c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d update(Settings).where(Settings.c.key \u003d\u003d key)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c9dc8854_3c3e2414","line":109,"in_reply_to":"a493b613_410c3c50","updated":"2024-05-24 07:48:10.000000000","message":"thanks,nice :)","commit_id":"1732ccaae3b45455a3f1e2f55ad4131bf8f7ed31"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"40d3b40fa9170141aa92b6369605376526cd3a95","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            query \u003d insert(Settings)"},{"line_number":107,"context_line":"            await db.execute(query, {\"key\": key, \"value\": value})"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            query \u003d update(Settings).where(Settings.c.key \u003d\u003d key)"},{"line_number":110,"context_line":"            await db.execute(query, {\"value\": value})"},{"line_number":111,"context_line":"        result \u003d await db.fetch_one(get_query)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a493b613_410c3c50","line":109,"in_reply_to":"dd6a0229_c74eb196","updated":"2024-05-24 07:10:18.000000000","message":"Fix this now. the mypy error will occur becuase the query is Insert Type, and then in else it is Update Type. So here, I have define the type of stmt(old query) as Union type of Update and Insert now. So no error will be issued.","commit_id":"1732ccaae3b45455a3f1e2f55ad4131bf8f7ed31"}]}
