)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"a72a211bf7feb08f12969126873ecf04091cd884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f5dd2700_471806fa","updated":"2025-09-27 08:17:44.000000000","message":"Thank you for your commit. 1. The implementation of this submission itself has no issues. 2. I am curious about in which scenarios we need such a parameter? The Skyline Console has already set the default domain to \"Default\", so why does this parameter need to be configurable? Personally, I cannot think of any scenarios for setting this parameter. Please help explain the reasons.","commit_id":"785901730a1136c5ffb05bf2abc0ec2884ec246b"},{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"8819fe21576ae1c8da8a597eb5e4b7d9d891d6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b9260e1a_e8e67cc0","updated":"2025-09-27 14:33:46.000000000","message":"pep8: 36902 W commands[2]\u003e black --check --diff --color skyline_apiserver --line-length 98 [tox/tox_env/api.py:463]\n--- skyline_apiserver/api/v1/login.py\t2025-09-27 08:17:38.118049 +0000\n+++ skyline_apiserver/api/v1/login.py\t2025-09-27 08:20:31.367186 +0000\n@@ -211,22 +211,24 @@\n     else:\n         response.set_cookie(CONF.default.session_name, profile.toJWTPayload())\n         response.set_cookie(constants.TIME_EXPIRED_KEY, str(profile.exp))\n         return profile\n \n+\n @router.get(\n-        \"/config\",\n-        description\u003d\"User default Domain\",\n-        responses\u003d{\n-            200: {\"model\": schemas.UserDefaultDomain},\n-        },\n-        response_model\u003dschemas.UserDefaultDomain,\n-        status_code\u003dstatus.HTTP_200_OK,\n-        response_description\u003d\"OK\",\n+    \"/config\",\n+    description\u003d\"User default Domain\",\n+    responses\u003d{\n+        200: {\"model\": schemas.UserDefaultDomain},\n+    },\n+    response_model\u003dschemas.UserDefaultDomain,\n+    status_code\u003dstatus.HTTP_200_OK,\n+    response_description\u003d\"OK\",\n )\n async def get_domain_config(request: Request) -\u003e schemas.UserDefaultDomain:\n     return schemas.UserDefaultDomain(default_domain\u003dCONF.openstack.default_domain)\n+\n \n @router.get(\n     \"/sso\",\n     description\u003d\"SSO configuration.\",\n     responses\u003d{\nwould reformat skyline_apiserver/api/v1/login.py\n--- skyline_apiserver/schemas/login.py\t2025-09-27 08:17:38.141039 +0000\n+++ skyline_apiserver/schemas/login.py\t2025-09-27 08:20:31.545650 +0000\n@@ -119,7 +119,8 @@\n \n class SSO(BaseModel):\n     enable_sso: bool\n     protocols: List[SSOInfo]\n \n+\n class UserDefaultDomain(BaseModel):\n-    default_domain: str\n\\ No newline at end of file\n+    default_domain: str\nwould reformat skyline_apiserver/schemas/login.py\n\nOh no! 💥 💔 💥\n2 files would be reformatted, 94 files would be left unchanged.","commit_id":"785901730a1136c5ffb05bf2abc0ec2884ec246b"}],"skyline_apiserver/api/v1/login.py":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"208bbea24293b0fb5f20442b7a3cb42b5337f32e","unresolved":true,"context_lines":[{"line_number":223,"context_line":"        status_code\u003dstatus.HTTP_200_OK,"},{"line_number":224,"context_line":"        response_description\u003d\"OK\","},{"line_number":225,"context_line":")"},{"line_number":226,"context_line":"async def get_domain_config(request: Request) -\u003e schemas.UserDefaultDomain:"},{"line_number":227,"context_line":"    return schemas.UserDefaultDomain(default_domain\u003dCONF.openstack.default_domain)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"@router.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f8ff542_ce88effa","line":226,"range":{"start_line":226,"start_character":0,"end_line":226,"end_character":5},"updated":"2025-09-27 08:22:06.000000000","message":"1. Use sync instead of async.\n2. GET /config/default_domain maybe better?","commit_id":"785901730a1136c5ffb05bf2abc0ec2884ec246b"},{"author":{"_account_id":38294,"name":"Reet Srivastava","display_name":"Reet Srivastava","email":"reet.srivastava@rackspace.com","username":"reetsrivastava"},"change_message_id":"52147635e6fe8333f20ebd68d2deb96150ab0d28","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        status_code\u003dstatus.HTTP_200_OK,"},{"line_number":224,"context_line":"        response_description\u003d\"OK\","},{"line_number":225,"context_line":")"},{"line_number":226,"context_line":"async def get_domain_config(request: Request) -\u003e schemas.UserDefaultDomain:"},{"line_number":227,"context_line":"    return schemas.UserDefaultDomain(default_domain\u003dCONF.openstack.default_domain)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"@router.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ffcb94c3_9f05cb32","line":226,"range":{"start_line":226,"start_character":0,"end_line":226,"end_character":5},"in_reply_to":"5f8ff542_ce88effa","updated":"2025-09-28 16:17:32.000000000","message":"Removed the async.\n\nKeeping that as /config makes space for enhancements and are in conjunction with other endpoints as well. Apart from that, it already been used as /config in the skyline-console change here.\nhttps://review.opendev.org/c/openstack/skyline-console/+/959284/4/src/client/skyline/index.js#141","commit_id":"785901730a1136c5ffb05bf2abc0ec2884ec246b"}]}