)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca310bbf235750b53a484275c5e80a3abcf1916b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79531001_6ef6e566","updated":"2024-07-30 18:09:53.000000000","message":"Hello Boxiang Zhu and Jingwei.Zhang\n\nPlease see https://review.opendev.org/c/openstack/governance/+/924109/comments/510391ea_9cf4bc38\n\nWhat are your plans on addressing the setuptools incompatibility?","commit_id":"f70772ecc89f076525bd377fe711fcd1d4d97678"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5e4f2809ea1eef45953a0be2b596f253938c384","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e340921_15c3d1e9","in_reply_to":"1a63ed63_a6d3c822","updated":"2024-07-31 19:41:26.000000000","message":"Perhaps you should fix the CI build scripts because of this setuptools change?\nYou might need to special case stable branch builds instead of master.. \n\nYou do require using \"make\" to build the skyline-console package locally: https://docs.openstack.org/skyline-console/latest/install/source-install-ubuntu.html\n\nSo it\u0027s possible users can have setuptools pre-installed and the build process will fail. \n\nthere\u0027s some more feedback from the openstack-tc channel: https://meetings.opendev.org/irclogs/%23openstack-tc/%23openstack-tc.2024-07-31.log.html#t2024-07-31T19:26:06","commit_id":"f70772ecc89f076525bd377fe711fcd1d4d97678"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"cf66cd2dc3544f6b42815fff3a7b476aa5e47734","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"212c6c76_2e81a375","in_reply_to":"2e340921_15c3d1e9","updated":"2024-08-01 02:35:59.000000000","message":"Run \u0027make package\u0027 so the setuptools will be re-install as the locked version 69.2.0.","commit_id":"f70772ecc89f076525bd377fe711fcd1d4d97678"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"1c5284adf56c1019b84d225294a15fb852cc3d59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a63ed63_a6d3c822","in_reply_to":"79531001_6ef6e566","updated":"2024-07-31 02:16:54.000000000","message":"\u003e Hello Boxiang Zhu and Jingwei.Zhang\n\u003e \n\u003e Please see https://review.opendev.org/c/openstack/governance/+/924109/comments/510391ea_9cf4bc38\n\u003e \n\u003e What are your plans on addressing the setuptools incompatibility?\n\nHi @gouthampravi@gmail.com\nLock version of setuptools as 69.2.0 in the master dev when we do zuul playbook to build the development package tar.gz.\nThe tox -e package is only used in https://opendev.org/openstack/skyline-console/src/branch/master/playbooks/python-tarball/run.yaml#L26\n\nWhen we release the stable branch/tag of this skyline-console project, we will follow the openstack upstream zuul job.\n\nThe setuptools of ubuntu 22.04 from deb package is 45.2.0 version.\nGet:1 https://mirror.bhs1.ovh.opendev.org/ubuntu focal-updates/main amd64 python3-setuptools all 45.2.0-1ubuntu0.1 [330 kB]\nGet:2 https://mirror.bhs1.ovh.opendev.org/ubuntu focal-updates/universe amd64 python3-wheel all 0.34.2-1ubuntu0.1 [23.9 kB]\nGet:3 https://mirror.bhs1.ovh.opendev.org/ubuntu focal-updates/universe amd64 python3-pip all 20.0.2-5ubuntu1.10 [231 kB]\n\n\nSo this patch is only affected the development master branch.","commit_id":"f70772ecc89f076525bd377fe711fcd1d4d97678"}],"Makefile":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"39a83643b765710222d21f8b26c82c3ba3a386f9","unresolved":true,"context_lines":[{"line_number":78,"context_line":"\techo `git rev-parse --verify HEAD` \u003e $(ROOT_DIR)/skyline_console/static/commit_id.txt"},{"line_number":79,"context_line":"\t# fix setuptools version as 69.2.0"},{"line_number":80,"context_line":"\t# if we use higher version of this, we will get skyline_console tar.gz package"},{"line_number":81,"context_line":"\tpip install --upgrade setuptools\u003d\u003d69.2.0"},{"line_number":82,"context_line":"\tpython setup.py sdist"},{"line_number":83,"context_line":"\tpython setup.py bdist_wheel"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".PHONY: fmt"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cb1c03e3_38369a32","line":83,"range":{"start_line":81,"start_character":10,"end_line":83,"end_character":28},"updated":"2024-07-31 19:45:00.000000000","message":"another feedback is that invoking \"python setup.py\" is deprecated:\n\n```\npython setup.py and the use of setup.py as a command line tool are deprecated.\n\nThis means that commands such as the following MUST NOT be run anymore:\n\npython setup.py install\n\npython setup.py develop\n\npython setup.py sdist\n\npython setup.py bdist_wheel\n```\n\nhttps://packaging.python.org/en/latest/discussions/setup-py-deprecated/","commit_id":"f70772ecc89f076525bd377fe711fcd1d4d97678"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"cf66cd2dc3544f6b42815fff3a7b476aa5e47734","unresolved":true,"context_lines":[{"line_number":78,"context_line":"\techo `git rev-parse --verify HEAD` \u003e $(ROOT_DIR)/skyline_console/static/commit_id.txt"},{"line_number":79,"context_line":"\t# fix setuptools version as 69.2.0"},{"line_number":80,"context_line":"\t# if we use higher version of this, we will get skyline_console tar.gz package"},{"line_number":81,"context_line":"\tpip install --upgrade setuptools\u003d\u003d69.2.0"},{"line_number":82,"context_line":"\tpython setup.py sdist"},{"line_number":83,"context_line":"\tpython setup.py bdist_wheel"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".PHONY: fmt"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8fc927_58b1b67f","line":83,"range":{"start_line":81,"start_character":10,"end_line":83,"end_character":28},"in_reply_to":"cb1c03e3_38369a32","updated":"2024-08-01 02:35:59.000000000","message":"hi @gouthampravi@gmail.com\n\nhttps://opendev.org/zuul/zuul-jobs/src/branch/master/roles/build-python-release/tasks/main.yaml\n- name: Build a tarball and wheel\n  command: \"{{ release_python }} setup.py sdist bdist_wheel {{ bdist_wheel_xargs }}\"\n  args:\n    chdir: \"{{ zuul_work_dir }}\"\n  when: build_wheel\n- name: Just build a tarball\n  command: \"{{ release_python }} setup.py sdist\"\n  args:\n    chdir: \"{{ zuul_work_dir }}\"\n  when: not build_wheel\n  \nWe also still use setup.py sdist bdist_wheel here.","commit_id":"f70772ecc89f076525bd377fe711fcd1d4d97678"}]}
