)]}'
{"solum/api/controllers/v1/assembly.py":[{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"033f1f26fab5e99ae4e4be5db2c24d92895c1fbc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Create a new assembly.\"\"\""},{"line_number":80,"context_line":"        js_data \u003d data.as_dict(objects.registry.Assembly,"},{"line_number":81,"context_line":"                               self._additional_keys)"},{"line_number":82,"context_line":"        if data.plan_uri is not wsme.Unset and not data.plan_uri.startswith("},{"line_number":83,"context_line":"                pecan.request.host_url):"},{"line_number":84,"context_line":"            # TODO(asalkeld) we are not hosting the plan so"},{"line_number":85,"context_line":"            # download the plan and insert it into our db."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fye4%3D","line":82,"updated":"2014-03-04 04:51:15.000000000","message":"Could we separate this change in the if condition as a separate patch?","commit_id":"bd717532cc16300b936e5bde34215fd2d8a4c694"},{"author":{"_account_id":9537,"name":"Julien Vey","email":"vey.julien@gmail.com","username":"julienvey"},"change_message_id":"e37f2cf762942a1f4ef09d712d00ec0d207436b6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Create a new assembly.\"\"\""},{"line_number":80,"context_line":"        js_data \u003d data.as_dict(objects.registry.Assembly,"},{"line_number":81,"context_line":"                               self._additional_keys)"},{"line_number":82,"context_line":"        if data.plan_uri is not wsme.Unset and not data.plan_uri.startswith("},{"line_number":83,"context_line":"                pecan.request.host_url):"},{"line_number":84,"context_line":"            # TODO(asalkeld) we are not hosting the plan so"},{"line_number":85,"context_line":"            # download the plan and insert it into our db."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FvSM%3D","line":82,"in_reply_to":"AAAAVn%2F%2Fye4%3D","updated":"2014-03-04 11:31:40.000000000","message":"Actually, this change is related to this patch.\nAdding plan_uuid in the model makes the following statements useless\n    \n    pl_uuid \u003d plan_uri.split(\u0027/\u0027)[-1]\n    # download the plan and insert it into our db.\n    pl \u003d objects.registry.Plan.get_by_uuid(None, pl_uuid)\n    js_data[\u0027plan_id\u0027] \u003d pl.id\n\nThis is why I changed it here","commit_id":"bd717532cc16300b936e5bde34215fd2d8a4c694"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"e06ff7cb013bbeef6f835a39c97ae7b9b1c3fb71","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            if plan_uri.startswith(pecan.request.host_url):"},{"line_number":79,"context_line":"                pl_uuid \u003d plan_uri.split(\u0027/\u0027)[-1]"},{"line_number":80,"context_line":"                pl \u003d objects.registry.Plan.get_by_uuid(None, pl_uuid)"},{"line_number":81,"context_line":"                js_data[\u0027plan_id\u0027] \u003d pl.id"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                # TODO(asalkeld) we are not hosting the plan so"},{"line_number":84,"context_line":"                # download the plan and insert it into our db."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2B%2Bg0%3D","side":"PARENT","line":81,"updated":"2014-03-10 22:31:24.000000000","message":"I don\u0027t see any code that replaces this. So if I do use plan_uri to pass in the reference to my internal plan, the reference will not be set in the db. I think you need another setter in the model for \"plan_uri\" and this should work.","commit_id":"8a1bbc451cad3402b060612f173f5f3217b210ea"},{"author":{"_account_id":9537,"name":"Julien Vey","email":"vey.julien@gmail.com","username":"julienvey"},"change_message_id":"b6cd413f20c704fe5eaf0d959d34bb5e302f043f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            if plan_uri.startswith(pecan.request.host_url):"},{"line_number":79,"context_line":"                pl_uuid \u003d plan_uri.split(\u0027/\u0027)[-1]"},{"line_number":80,"context_line":"                pl \u003d objects.registry.Plan.get_by_uuid(None, pl_uuid)"},{"line_number":81,"context_line":"                js_data[\u0027plan_id\u0027] \u003d pl.id"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                # TODO(asalkeld) we are not hosting the plan so"},{"line_number":84,"context_line":"                # download the plan and insert it into our db."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2B6qI%3D","side":"PARENT","line":81,"in_reply_to":"AAAAVn%2F%2B%2Bg0%3D","updated":"2014-03-11 10:14:21.000000000","message":"I think that now that we have plan_uuid, we should use it for internal plan, rather than parsing a plan_uri. I don\u0027t see how plan_uri can be better in this case\n\nMaybe I missed something in the code elsewhere that was using it. Then just let me know and I will change it also\n\nplan_uri should be used only for plan that are stored somewhere else","commit_id":"8a1bbc451cad3402b060612f173f5f3217b210ea"},{"author":{"_account_id":8334,"name":"Noorul Islam K M","email":"noorul@noorul.com","username":"noorul"},"change_message_id":"86ec81f5cb7ab0ff7c67fe7578e5dd07000ecae6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            if plan_uri.startswith(pecan.request.host_url):"},{"line_number":79,"context_line":"                pl_uuid \u003d plan_uri.split(\u0027/\u0027)[-1]"},{"line_number":80,"context_line":"                pl \u003d objects.registry.Plan.get_by_uuid(None, pl_uuid)"},{"line_number":81,"context_line":"                js_data[\u0027plan_id\u0027] \u003d pl.id"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                # TODO(asalkeld) we are not hosting the plan so"},{"line_number":84,"context_line":"                # download the plan and insert it into our db."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2B5LE%3D","side":"PARENT","line":81,"in_reply_to":"AAAAVn%2F%2B6qI%3D","updated":"2014-03-11 13:55:50.000000000","message":"Yes, why do we need both?","commit_id":"8a1bbc451cad3402b060612f173f5f3217b210ea"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"71e8ada101d6f834c5424d092ba480d0be2745ad","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Create a new assembly.\"\"\""},{"line_number":75,"context_line":"        js_data \u003d data.as_dict(objects.registry.Assembly)"},{"line_number":76,"context_line":"        if data.plan_uri is not wsme.Unset and not data.plan_uri.startswith("},{"line_number":77,"context_line":"                pecan.request.host_url):"},{"line_number":78,"context_line":"            # TODO(asalkeld) we are not hosting the plan so"},{"line_number":79,"context_line":"            # download the plan and insert it into our db."},{"line_number":80,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2B2eU%3D","line":77,"updated":"2014-03-11 18:34:26.000000000","message":"In the earlier case, when the plan_uri started with host_url, we were extracting the plan_uuid from the pecan request and then getting the plan with that uuid. From that then we were setting js_data[\u0027plan_id\u0027].\n\nSince you have added \u0027not startswith(host_url), don\u0027t you have to still handle the case that when it does start with host_url we have to perform the above mentioned steps?","commit_id":"3176698a7ef3291e35e81e61ee94626bd779b9a5"},{"author":{"_account_id":9113,"name":"Arati Mahimane","email":"aratim0687@gmail.com","username":"arati.mahimane"},"change_message_id":"8632298c1a399b6af34b32550d3f1efff63cf4fd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Create a new assembly.\"\"\""},{"line_number":75,"context_line":"        js_data \u003d data.as_dict(objects.registry.Assembly)"},{"line_number":76,"context_line":"        if data.plan_uri is not wsme.Unset and not data.plan_uri.startswith("},{"line_number":77,"context_line":"                pecan.request.host_url):"},{"line_number":78,"context_line":"            # TODO(asalkeld) we are not hosting the plan so"},{"line_number":79,"context_line":"            # download the plan and insert it into our db."},{"line_number":80,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAVn%2F%2B1rE%3D","line":77,"in_reply_to":"AAAAVn%2F%2B2eU%3D","updated":"2014-03-11 20:20:50.000000000","message":"Agree with Dev.","commit_id":"3176698a7ef3291e35e81e61ee94626bd779b9a5"}],"solum/objects/sqlalchemy/assembly.py":[{"author":{"_account_id":8443,"name":"Georgy Okrokvertskhov","email":"gokrokvertskhov@mirantis.com","username":"gokrokvertskhov"},"change_message_id":"73dcab9b32968502001acd727056cd96b18fab12","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return objects.registry.Plan.get_by_id(None, self.plan_id).uuid"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @plan_uuid.setter"},{"line_number":43,"context_line":"    def plan_uuid(self, assembly_uuid):"},{"line_number":44,"context_line":"        plan \u003d objects.registry.Plan.get_by_uuid(None, assembly_uuid)"},{"line_number":45,"context_line":"        self.plan_id \u003d plan.id"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FfPg%3D","line":43,"updated":"2014-03-05 19:46:34.000000000","message":"I am not sure I understand how assembly_id is user here. There is no assembly_uuid in Plan model. Probably i am missing here something.","commit_id":"461f9a5e96fba54f56c17446c6c2a859ce88fe9e"},{"author":{"_account_id":9537,"name":"Julien Vey","email":"vey.julien@gmail.com","username":"julienvey"},"change_message_id":"0ee5c105c1676a619439776961b3d5533fb394d6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return objects.registry.Plan.get_by_id(None, self.plan_id).uuid"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @plan_uuid.setter"},{"line_number":43,"context_line":"    def plan_uuid(self, assembly_uuid):"},{"line_number":44,"context_line":"        plan \u003d objects.registry.Plan.get_by_uuid(None, assembly_uuid)"},{"line_number":45,"context_line":"        self.plan_id \u003d plan.id"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FYEo%3D","line":43,"in_reply_to":"AAAAVn%2F%2FfPg%3D","updated":"2014-03-06 14:37:51.000000000","message":"Right! Bad copy/paste :(","commit_id":"461f9a5e96fba54f56c17446c6c2a859ce88fe9e"}]}