)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"173a0a8cdc00d3d6f8ca8a8b9aef40a1fb770ae9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91a59a5c_eeb231e9","updated":"2024-08-29 07:53:35.000000000","message":"I think it is a good thing not to overwrite files by default and the error has been made by nova by having this file stored in git only for it to be overwritten in the build process, cf. https://review.opendev.org/c/openstack/nova/+/927471","commit_id":"9203cb91604e7d251c6e645e6b70250e37954b5e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"34ddca32eace6ee1e4433fcc382b7db098fce582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"457cb3e8_e121a8d2","updated":"2024-08-29 15:30:02.000000000","message":"I think we can probably abandon this now, given we resolved the issue in Nova [here](https://review.opendev.org/c/openstack/nova/+/927471)?","commit_id":"9203cb91604e7d251c6e645e6b70250e37954b5e"}],"sphinx_feature_classification/support_matrix.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3977aa0f47753c5fe20834d92efbbb8208dec3f9","unresolved":true,"context_lines":[{"line_number":480,"context_line":"        # Since Sphinx 8.0.0, user-supplied data will not be overwritten by"},{"line_number":481,"context_line":"        # default. The \u0027force\u0027 keyword arg must be used in order to overwrite."},{"line_number":482,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/12647"},{"line_number":483,"context_line":"        try:"},{"line_number":484,"context_line":"            copy_asset(src, dst, force\u003dTrue)"},{"line_number":485,"context_line":"        except TypeError as e:"},{"line_number":486,"context_line":"            # This is one way to make things also work for older Python"},{"line_number":487,"context_line":"            # versions (which could have older versions of Sphinx)."},{"line_number":488,"context_line":"            if \"got an unexpected keyword argument \u0027force\u0027\" in str(e):"},{"line_number":489,"context_line":"                copy_asset(src, dst)"},{"line_number":490,"context_line":"            else:"},{"line_number":491,"context_line":"                raise"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5d6f9e6c_a940d5b9","line":491,"range":{"start_line":483,"start_character":0,"end_line":491,"end_character":21},"updated":"2024-08-29 12:46:35.000000000","message":"Can we be a bit more explicit so that we know to drop this down the line (not being explicit means the code hangs around forever or requires diving into git history to figure out).\n\n```suggestion\n        if sphinx.version_info \u003e\u003d (8, 0):\n            copy_asset(src, dst, force\u003dTrue)\n        else:\n            copy_asset(src, dst)\n```\n\n(obviously add `import sphinx` at the top too)","commit_id":"9203cb91604e7d251c6e645e6b70250e37954b5e"}]}
