)]}'
{"stevedore/tests/test_extension.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c34d971d0506f221574ed9073cfaffa7b4c3640","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def setUp(self):"},{"line_number":178,"context_line":"        super(TestLoadRequirementsNewSetuptools, self).setUp()"},{"line_number":179,"context_line":"        self.mock_ep \u003d mock.Mock(spec\u003d[\u0027require\u0027, \u0027resolve\u0027, \u0027load\u0027, \u0027name\u0027])"},{"line_number":180,"context_line":"        self.em \u003d extension.ExtensionManager.make_test_instance([])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_verify_requirements(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_16591c35","line":179,"updated":"2015-01-05 21:34:35.000000000","message":"There is a condition in the code that both require and resolve are on the ep object, that\u0027s not tested here.  Can you assume that if resolve is there that require will be also?  This is kind of a nit pick comment, just thinking of the conditional testing.","commit_id":"37c94cd0d6677c5260624e7178d2ce7814889142"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"27e663cb5805dc564f93f3ca12b1f7b996d5e40f","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def setUp(self):"},{"line_number":178,"context_line":"        super(TestLoadRequirementsNewSetuptools, self).setUp()"},{"line_number":179,"context_line":"        self.mock_ep \u003d mock.Mock(spec\u003d[\u0027require\u0027, \u0027resolve\u0027, \u0027load\u0027, \u0027name\u0027])"},{"line_number":180,"context_line":"        self.em \u003d extension.ExtensionManager.make_test_instance([])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_verify_requirements(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a6ff3701","line":179,"in_reply_to":"3a961159_16591c35","updated":"2015-01-05 23:26:00.000000000","message":"It looks like resolve is the only one that was actually added in the new setuptools: https://bitbucket.org/pypa/setuptools/commits/a1a6a1ac9113b90009052ca7263174a488434099\n\nrequire was already there, so we could probably just check for resolve to see which version we\u0027re using.\n\nSo strictly speaking the old test should have a require attribute and no resolve, but since resolve is the one we actually care about I\u0027m kind of meh on the whole thing. :-)","commit_id":"37c94cd0d6677c5260624e7178d2ce7814889142"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee0cf26c55ea3ac7f61b2ca1d0d9af84d18a99c2","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def setUp(self):"},{"line_number":178,"context_line":"        super(TestLoadRequirementsNewSetuptools, self).setUp()"},{"line_number":179,"context_line":"        self.mock_ep \u003d mock.Mock(spec\u003d[\u0027require\u0027, \u0027resolve\u0027, \u0027load\u0027, \u0027name\u0027])"},{"line_number":180,"context_line":"        self.em \u003d extension.ExtensionManager.make_test_instance([])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_verify_requirements(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4d54ee53","line":179,"in_reply_to":"3a961159_a6ff3701","updated":"2015-01-06 02:08:39.000000000","message":"Works for me. :)\n\nSo do we do a release of stevedore now and then update global requirements to fix bug 1407736?","commit_id":"37c94cd0d6677c5260624e7178d2ce7814889142"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c34d971d0506f221574ed9073cfaffa7b4c3640","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def test_no_verify_requirements(self):"},{"line_number":189,"context_line":"        self.em._load_one_plugin(self.mock_ep, False, (), {},"},{"line_number":190,"context_line":"                                 verify_requirements\u003dFalse)"},{"line_number":191,"context_line":"        self.assertEqual(0, self.mock_ep.require.call_count)"},{"line_number":192,"context_line":"        self.mock_ep.resolve.assert_called_once_with()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_d604f416","line":191,"updated":"2015-01-05 21:34:35.000000000","message":"nit: could also be self.assertFalse(self.mock_ep.called)","commit_id":"37c94cd0d6677c5260624e7178d2ce7814889142"}]}