)]}'
{"id":"openstack%2Fstevedore~733747","triplet_id":"openstack%2Fstevedore~master~I28a50cac12670bb6987b4c7794a15e15aa1fe965","project":"openstack/stevedore","branch":"master","topic":"unittest.mock","hashtags":[],"change_id":"I28a50cac12670bb6987b4c7794a15e15aa1fe965","subject":"Replace external mock with built-in unittest.mock","status":"MERGED","created":"2020-06-05 05:51:28.000000000","updated":"2020-06-08 14:52:55.000000000","submitted":"2020-06-08 14:51:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"733747-1591627866526-ec5b561d","meta_rev_id":"483590173a6b595d93d9fe411e876ec1c2ada103","_number":733747,"virtual_id_number":733747,"owner":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-08 14:51:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-06-05 13:49:58.000000000","_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},{"value":2,"date":"2020-06-08 08:55:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":2,"date":"2020-06-08 13:17:21.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":1,"date":"2020-06-08 13:17:21.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-05 05:51:39.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2020-06-08 08:55:49.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-06-08 13:17:21.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-06-08 14:51:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ac47f87dab4d66436159083789069313447cbb24","author":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"date":"2020-06-05 05:51:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b9476add58195a054948a7d261c6164cbd6814f","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2020-06-05 05:51:39.000000000","message":"Patch Set 1:\n\nCongratulations, you\u0027ve proposed your first change in OpenDev.\n\nYour submission will now be tested automatically by Zuul, our gatekeeper,\nand reviewed by other friendly developers. They will give you feedback and\nmay require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches often take days (and sometimes weeks) to get reviewed, so be\npatient. Don\u0027t hesitate to ask for help, and answer questions about your\nwork promptly if you can. The more you get to know reviewers and get to be\nknown by them, the smoother the review and approval process will become. The\nfastest way to accomplish this is by reviewing other proposed changes\nyourself: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for participating in OpenDev, we look forward to seeing you\naround.\n\nWorkflow Guide: https://docs.openstack.org/infra/manual/developers.html","accounts_in_message":[],"_revision_number":1},{"id":"24676777ca00bc60c5df7eb3e9620ebbd8a1596f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 07:03:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/1bf9e251b5d04c00a50f067b1460bf8e : SUCCESS in 2m 59s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ec24eb7ee9cd4e5d87eba0b17744c79c : SUCCESS in 1h 11m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fe68722edb764abcadadb340a70dc630 : SUCCESS in 5m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/61f35c2fea064aa69596180c3c893751 : SUCCESS in 3m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/946a8ee15d3842769c03ae20b3664d1f : SUCCESS in 4m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9603cb347a5a405593943d9203d8f9d9 : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2f05f99a2c394189a517b6802fb2e59f : SUCCESS in 4m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/448385d1dbb24f099bd329d5f5865c6d : SUCCESS in 3m 47s","accounts_in_message":[],"_revision_number":1},{"id":"227604c1c0b4d949f6c9008899d3256c7812b402","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-05 09:38:44.000000000","message":"Patch Set 1:\n\n(6 comments)\n\nHello Michal,\n\nThanks for these changes, see my inline comments/suggestions:","accounts_in_message":[],"_revision_number":1},{"id":"bbf32032255a3cb4aa1e97b343525f36c6d82a0e","author":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"date":"2020-06-05 13:48:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"54de9388f947d0905f5843486fec203010fc350c","author":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"date":"2020-06-05 13:49:58.000000000","message":"Patch Set 2:\n\nThanks for your comments.  I think I\u0027ve addressed all of them, i.e. put the import in the right group according to style guide.","accounts_in_message":[],"_revision_number":2},{"id":"fc8166d17084dabe7f48a09dcad450cb262ec7be","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-06-05 14:12:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"59cdf01f33d28a2eb1ddd78fc66ee61423395229","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 15:25:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/47a906e4372641348046d372f6fdba74 : SUCCESS in 4m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e9fd24c2739f424ea5ecef98c089b2de : SUCCESS in 1h 30m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d852917278d54988b49670230de67c99 : SUCCESS in 5m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/239b41e41c354c10937c0b084d3b0099 : SUCCESS in 5m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/55b49ae1ac5e438b91151e372b8dbc15 : SUCCESS in 6m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7c057bf0018741bea08b8b0eb9caf506 : SUCCESS in 6m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/714d65cb19314545a94bbfee2634425c : SUCCESS in 6m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/061b114f8f8a41c1b7099077ea3b4e7c : SUCCESS in 5m 15s","accounts_in_message":[],"_revision_number":2},{"id":"9ab0195785cf698915428d8c21dde22224143a25","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-08 08:55:49.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nThanks for the updates, I think the travis file could be addressed through a follow up patch if needed","accounts_in_message":[],"_revision_number":2},{"id":"0c6c09a6ab941bd7d6990c4dcc189b2362732555","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-06-08 12:59:01.000000000","message":"Topic changed from mock to unittest.mock","accounts_in_message":[],"_revision_number":2},{"id":"acb830eff2680e359a2aa48e1c2b20835028f32f","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-06-08 13:17:21.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nClean up done in a follow up:\n\nhttps://review.opendev.org/734079","accounts_in_message":[],"_revision_number":2},{"id":"a3089a21d9342ad21cf83f9ae83613f832d71bb5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 13:17:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"012596bc2857c08ec2034a6c946f9148c6cfa2cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 14:51:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"44d306d1af6fa78f9f3a8edc7e4e88ab1b3abfbf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 14:51:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/5da55fd937014626956390959f4af377 : SUCCESS in 3m 05s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c5593e0a54dc46a29e232263867d6017 : SUCCESS in 1h 27m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a6c5a1e21f664e008defc1a742680246 : SUCCESS in 5m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/85a67a0694884a9f9984dc7d4586b1a5 : SUCCESS in 3m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bd17192e40c744328d8dcba50437a27e : SUCCESS in 3m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ab48c850ba504676bae23fe7f2e9d02a : SUCCESS in 4m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/78b45045018f49de811410dc8548bf1e : SUCCESS in 4m 03s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a37bde58f2404058857081bed4b9781a : SUCCESS in 4m 01s","accounts_in_message":[],"_revision_number":2},{"id":"483590173a6b595d93d9fe411e876ec1c2ada103","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 14:52:55.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a49218542ed74f689591d203291ac170 : SUCCESS in 1m 29s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9654a657cd0742adac84760af9edf23e : SUCCESS in 1m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"34b9a130495e0b327a1516da483af3d217ea8f51","revisions":{"b124914a7bfad4e38e5e150621032d53bc59ee49":{"kind":"REWORK","_number":1,"created":"2020-06-05 05:51:28.000000000","uploader":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"ref":"refs/changes/47/733747/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/stevedore","ref":"refs/changes/47/733747/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/stevedore refs/changes/47/733747/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/stevedore refs/changes/47/733747/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/stevedore refs/changes/47/733747/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/stevedore refs/changes/47/733747/1"}}},"commit":{"parents":[{"commit":"0c10f5cf215f0b801fd8648d7d1c00ec8b2a610c","subject":"Merge \"Stop to use the __future__ module.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/stevedore/commit/0c10f5cf215f0b801fd8648d7d1c00ec8b2a610c"}]}],"author":{"name":"Michał Górny","email":"mgorny@gentoo.org","date":"2020-06-05 05:50:39.000000000","tz":120},"committer":{"name":"Michał Górny","email":"mgorny@gentoo.org","date":"2020-06-05 05:50:39.000000000","tz":120},"subject":"Replace external mock with built-in unittest.mock","message":"Replace external mock with built-in unittest.mock\n\nNow that stevedore does not support Python 2 anymore, there is no need\nto ever use the external \u0027mock\u0027 package.  Python 3.3+ has it integrated\nas \u0027unittest.mock\u0027, so just use that.\n\nChange-Id: I28a50cac12670bb6987b4c7794a15e15aa1fe965\nSigned-off-by: Michał Górny \u003cmgorny@gentoo.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/stevedore/commit/b124914a7bfad4e38e5e150621032d53bc59ee49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/stevedore/commit/b124914a7bfad4e38e5e150621032d53bc59ee49"}]},"branch":"refs/heads/master"},"34b9a130495e0b327a1516da483af3d217ea8f51":{"kind":"REWORK","_number":2,"created":"2020-06-05 13:48:25.000000000","uploader":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"ref":"refs/changes/47/733747/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/stevedore","ref":"refs/changes/47/733747/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/stevedore refs/changes/47/733747/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/stevedore refs/changes/47/733747/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/stevedore refs/changes/47/733747/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/stevedore refs/changes/47/733747/2"}}},"commit":{"parents":[{"commit":"0c10f5cf215f0b801fd8648d7d1c00ec8b2a610c","subject":"Merge \"Stop to use the __future__ module.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/stevedore/commit/0c10f5cf215f0b801fd8648d7d1c00ec8b2a610c"}]}],"author":{"name":"Michał Górny","email":"mgorny@gentoo.org","date":"2020-06-05 05:50:39.000000000","tz":120},"committer":{"name":"Michał Górny","email":"mgorny@gentoo.org","date":"2020-06-05 13:46:27.000000000","tz":120},"subject":"Replace external mock with built-in unittest.mock","message":"Replace external mock with built-in unittest.mock\n\nNow that stevedore does not support Python 2 anymore, there is no need\nto ever use the external \u0027mock\u0027 package.  Python 3.3+ has it integrated\nas \u0027unittest.mock\u0027, so just use that.\n\nChange-Id: I28a50cac12670bb6987b4c7794a15e15aa1fe965\nSigned-off-by: Michał Górny \u003cmgorny@gentoo.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/stevedore/commit/34b9a130495e0b327a1516da483af3d217ea8f51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/stevedore/commit/34b9a130495e0b327a1516da483af3d217ea8f51"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}