)]}'
{"Engine/swift/storlet_middleware/storlet_handler.py":[{"author":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"change_message_id":"60df30740988653284053cc8f7ad2512c4eaf0c9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                                    self.app)[\u0027meta\u0027]"},{"line_number":128,"context_line":"                    storlets_enabled \u003d account_meta.get(\u0027storlet-enabled\u0027,"},{"line_number":129,"context_line":"                                                        \u0027False\u0027)"},{"line_number":130,"context_line":"                    if not config_true_value(storlets_enabled):"},{"line_number":131,"context_line":"                        self.logger.info(\u0027Account disabled for storlets\u0027)"},{"line_number":132,"context_line":"                        return HTTPBadRequest(\u0027Account disabled for storlets\u0027)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_97968a4a","line":130,"updated":"2015-12-11 23:16:13.000000000","message":"Great catch, I like this a lot conceptually !\n\nOne slight concern though, it seems by far and large the use case of this is for parsing the CONF files;  Looking at the implementation though it\u0027s clear it\u0027ll work here that\u0027s not an issue;  Just worried if they in the future change the meaning of config_true_value so to speak, to what I\u0027m not sure.\n\nI\u0027d be more comfortable if it was called string_true_values for example.\n\n\nI don\u0027t think it\u0027s a very rational concern though : )","commit_id":"95a2eed6dde65271ed469c56840298d0ec2a32a3"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"4383f83e91ba445fcf2acf52ed6e6d610112b64d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                                    self.app)[\u0027meta\u0027]"},{"line_number":128,"context_line":"                    storlets_enabled \u003d account_meta.get(\u0027storlet-enabled\u0027,"},{"line_number":129,"context_line":"                                                        \u0027False\u0027)"},{"line_number":130,"context_line":"                    if not config_true_value(storlets_enabled):"},{"line_number":131,"context_line":"                        self.logger.info(\u0027Account disabled for storlets\u0027)"},{"line_number":132,"context_line":"                        return HTTPBadRequest(\u0027Account disabled for storlets\u0027)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_aa5c6d19","line":130,"in_reply_to":"7a740942_97968a4a","updated":"2015-12-12 21:00:08.000000000","message":"Relying on the name only, I can see the concern. Looking at Swift\u0027s code, however, this is used all over the place and not only for config options. see e.g. form the proxy\u0027s base controller: self.newest \u003d config_true_value(req.headers.get(\u0027x-newest\u0027, \u0027f\u0027))","commit_id":"95a2eed6dde65271ed469c56840298d0ec2a32a3"},{"author":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"change_message_id":"b16c2e4a529b6f030466f4eeffa3d4c2797663e5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                                    self.app)[\u0027meta\u0027]"},{"line_number":128,"context_line":"                    storlets_enabled \u003d account_meta.get(\u0027storlet-enabled\u0027,"},{"line_number":129,"context_line":"                                                        \u0027False\u0027)"},{"line_number":130,"context_line":"                    if not config_true_value(storlets_enabled):"},{"line_number":131,"context_line":"                        self.logger.info(\u0027Account disabled for storlets\u0027)"},{"line_number":132,"context_line":"                        return HTTPBadRequest(\u0027Account disabled for storlets\u0027)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_578ed12e","line":130,"in_reply_to":"7a740942_aa5c6d19","updated":"2015-12-13 02:46:06.000000000","message":"Thanks Eran ! I\u0027m convinced :)","commit_id":"95a2eed6dde65271ed469c56840298d0ec2a32a3"}]}