)]}'
{"Engine/swift/storlet_middleware/storlet_handler.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"b1385a2907709735b65de1bd192eff0f952fcebb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            if storlet_execution:"},{"line_number":83,"context_line":"                header_parameters \u003d \\"},{"line_number":84,"context_line":"                    self._extract_parameters_from_headers(req)"},{"line_number":85,"context_line":"                req.params.update(header_parameters)"},{"line_number":86,"context_line":"            if self.execution_server \u003d\u003d \u0027object\u0027 and storlet_execution:"},{"line_number":87,"context_line":"                if req.method \u003d\u003d \u0027GET\u0027:"},{"line_number":88,"context_line":"                    self.logger.info(\u0027GET. Run storlet\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_ebabc2d4","line":85,"updated":"2016-01-19 19:35:41.000000000","message":"This may be alright, but I do have the following doubt:\nWe do not differentiate between storlet specific parameters and parameters coming from the query string, while parameters coming from the query string are not necessarily targeted for a storlet (which is a problem with the current way we do parameters)","commit_id":"25a97f7df698955784de47f2cccc23c867e63d2b"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"b1385a2907709735b65de1bd192eff0f952fcebb","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def _extract_parameters_from_headers(self, req):"},{"line_number":238,"context_line":"        parameters \u003d {}"},{"line_number":239,"context_line":"        for param in req.headers:"},{"line_number":240,"context_line":"            if param.startswith(\u0027X-Storlet-Parameter\u0027):"},{"line_number":241,"context_line":"                keyvalue \u003d req.headers[param]"},{"line_number":242,"context_line":"                keyvalue \u003d urllib.unquote(keyvalue)"},{"line_number":243,"context_line":"                [key, value] \u003d keyvalue.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_d05a2950","line":240,"updated":"2016-01-19 19:35:41.000000000","message":"Should we change this to param.lower().startswith(\u0027x-storlet-parameter\u0027)","commit_id":"25a97f7df698955784de47f2cccc23c867e63d2b"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6e9a86d20d39395ac20fda85ab2292535e63d538","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            return req.get_response(self.app)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # The target should be object"},{"line_number":64,"context_line":"        if not (account and container and obj):"},{"line_number":65,"context_line":"            return req.get_response(self.app)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_3ee813b4","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":8},"updated":"2016-01-20 11:03:33.000000000","message":"Line 53, and lines 59-64 seem to override a previous commit by Takashi. I think you need to rebase.","commit_id":"8b8fa3e33150382ac03f2d9d9feafe20fc0ecb62"}]}