)]}'
{"Engine/swift/storlet_middleware/storlet_handler.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5311f158b4ac4e85de837996c5ca4f942ca82a8a","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            request_handler \u003d self.handler_class("},{"line_number":386,"context_line":"                req, self.gateway_conf, self.app, self.logger)"},{"line_number":387,"context_line":"            self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"},{"line_number":388,"context_line":"                              (self.exec_server, request_handler.account,"},{"line_number":389,"context_line":"                               request_handler.container, request_handler.obj))"},{"line_number":390,"context_line":"        except HTTPException:"},{"line_number":391,"context_line":"            raise"},{"line_number":392,"context_line":"        except (ValueError, NotStorletRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ce4b94af","line":389,"range":{"start_line":388,"start_character":49,"end_line":389,"end_character":77},"updated":"2016-02-15 09:49:20.000000000","message":"I prefer removing unnecessary accesses to class member from outside.\nHow about printing req.path instead, or moving this line into Handler class?","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e39a9c4def36a070e5388db4df8bcb972252e990","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            request_handler \u003d self.handler_class("},{"line_number":386,"context_line":"                req, self.gateway_conf, self.app, self.logger)"},{"line_number":387,"context_line":"            self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"},{"line_number":388,"context_line":"                              (self.exec_server, request_handler.account,"},{"line_number":389,"context_line":"                               request_handler.container, request_handler.obj))"},{"line_number":390,"context_line":"        except HTTPException:"},{"line_number":391,"context_line":"            raise"},{"line_number":392,"context_line":"        except (ValueError, NotStorletRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1902c36f","line":389,"range":{"start_line":388,"start_character":49,"end_line":389,"end_character":77},"in_reply_to":"dae33548_47176751","updated":"2016-02-16 01:03:26.000000000","message":"agree","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f60966dc0bcceee15d3a68b138807c1361d4249e","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            request_handler \u003d self.handler_class("},{"line_number":386,"context_line":"                req, self.gateway_conf, self.app, self.logger)"},{"line_number":387,"context_line":"            self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"},{"line_number":388,"context_line":"                              (self.exec_server, request_handler.account,"},{"line_number":389,"context_line":"                               request_handler.container, request_handler.obj))"},{"line_number":390,"context_line":"        except HTTPException:"},{"line_number":391,"context_line":"            raise"},{"line_number":392,"context_line":"        except (ValueError, NotStorletRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_47176751","line":389,"range":{"start_line":388,"start_character":49,"end_line":389,"end_character":77},"in_reply_to":"dae33548_ce4b94af","updated":"2016-02-15 10:47:08.000000000","message":"Good idea. Either to fix here or later followup is fine to me but... I like in follow up to split the patch into each small purpose. Thought?","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5311f158b4ac4e85de837996c5ca4f942ca82a8a","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"},{"line_number":388,"context_line":"                              (self.exec_server, request_handler.account,"},{"line_number":389,"context_line":"                               request_handler.container, request_handler.obj))"},{"line_number":390,"context_line":"        except HTTPException:"},{"line_number":391,"context_line":"            raise"},{"line_number":392,"context_line":"        except (ValueError, NotStorletRequest):"},{"line_number":393,"context_line":"            return req.get_response(self.app)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        try:"},{"line_number":396,"context_line":"            return request_handler.handle_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ced8b420","line":393,"range":{"start_line":390,"start_character":8,"end_line":393,"end_character":45},"updated":"2016-02-15 09:49:20.000000000","message":"Can we merge this exception handling into the following one?","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e39a9c4def36a070e5388db4df8bcb972252e990","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"},{"line_number":388,"context_line":"                              (self.exec_server, request_handler.account,"},{"line_number":389,"context_line":"                               request_handler.container, request_handler.obj))"},{"line_number":390,"context_line":"        except HTTPException:"},{"line_number":391,"context_line":"            raise"},{"line_number":392,"context_line":"        except (ValueError, NotStorletRequest):"},{"line_number":393,"context_line":"            return req.get_response(self.app)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        try:"},{"line_number":396,"context_line":"            return request_handler.handle_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_593bab38","line":393,"range":{"start_line":390,"start_character":8,"end_line":393,"end_character":45},"in_reply_to":"dae33548_c21a456e","updated":"2016-02-16 01:03:26.000000000","message":"OK. I think we can improve exception handling a little more, after some more refactoring.","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f60966dc0bcceee15d3a68b138807c1361d4249e","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            self.logger.debug(\u0027storlet_handler call in %s: with %s/%s/%s\u0027 %"},{"line_number":388,"context_line":"                              (self.exec_server, request_handler.account,"},{"line_number":389,"context_line":"                               request_handler.container, request_handler.obj))"},{"line_number":390,"context_line":"        except HTTPException:"},{"line_number":391,"context_line":"            raise"},{"line_number":392,"context_line":"        except (ValueError, NotStorletRequest):"},{"line_number":393,"context_line":"            return req.get_response(self.app)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        try:"},{"line_number":396,"context_line":"            return request_handler.handle_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_c21a456e","line":393,"range":{"start_line":390,"start_character":8,"end_line":393,"end_character":45},"in_reply_to":"dae33548_ced8b420","updated":"2016-02-15 10:47:08.000000000","message":"Ditto. And I noticed the ValueError handling here anymore, good call :)","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"}],"tests/unit/swift/storlet_middleware/test_storlet_handler.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5311f158b4ac4e85de837996c5ca4f942ca82a8a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027execution_server\u0027: \u0027proxy\u0027}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class TestStorletsMiddleware(unittest.TestCase):"},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        self.got_statuses \u003d []"},{"line_number":40,"context_line":"        self.got_headers \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_916531e3","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":18},"updated":"2016-02-15 09:49:20.000000000","message":"We had better unify this in \"Storlet\" or \"Storlets\"","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f60966dc0bcceee15d3a68b138807c1361d4249e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027execution_server\u0027: \u0027proxy\u0027}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class TestStorletsMiddleware(unittest.TestCase):"},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        self.got_statuses \u003d []"},{"line_number":40,"context_line":"        self.got_headers \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_627c1973","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":18},"in_reply_to":"dae33548_916531e3","updated":"2016-02-15 10:47:08.000000000","message":"Done","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5311f158b4ac4e85de837996c5ca4f942ca82a8a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            self.fail(\u0027Application loading got an error\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class TestStorletMiddlewareProxy(TestStorletsMiddleware):"},{"line_number":69,"context_line":"    def setUp(self):"},{"line_number":70,"context_line":"        super(TestStorletMiddlewareProxy, self).setUp()"},{"line_number":71,"context_line":"        self.conf[\u0027execution_server\u0027] \u003d \u0027proxy\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_11a001f4","line":68,"range":{"start_line":68,"start_character":10,"end_line":68,"end_character":17},"updated":"2016-02-15 09:49:20.000000000","message":"ditto","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f60966dc0bcceee15d3a68b138807c1361d4249e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            self.fail(\u0027Application loading got an error\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class TestStorletMiddlewareProxy(TestStorletsMiddleware):"},{"line_number":69,"context_line":"    def setUp(self):"},{"line_number":70,"context_line":"        super(TestStorletMiddlewareProxy, self).setUp()"},{"line_number":71,"context_line":"        self.conf[\u0027execution_server\u0027] \u003d \u0027proxy\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_c28d257d","line":68,"range":{"start_line":68,"start_character":10,"end_line":68,"end_character":17},"in_reply_to":"dae33548_11a001f4","updated":"2016-02-15 10:47:08.000000000","message":"Done","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5311f158b4ac4e85de837996c5ca4f942ca82a8a","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            get(\u0027/v1/AUTH_a/dependency/dependency\u0027)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"class TestStorletMiddlewareObject(TestStorletsMiddleware):"},{"line_number":407,"context_line":"    def setUp(self):"},{"line_number":408,"context_line":"        super(TestStorletMiddlewareObject, self).setUp()"},{"line_number":409,"context_line":"        self.conf[\u0027execution_server\u0027] \u003d \u0027object\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_51aa89d5","line":406,"range":{"start_line":406,"start_character":10,"end_line":406,"end_character":17},"updated":"2016-02-15 09:49:20.000000000","message":"ditto","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f60966dc0bcceee15d3a68b138807c1361d4249e","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            get(\u0027/v1/AUTH_a/dependency/dependency\u0027)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"class TestStorletMiddlewareObject(TestStorletsMiddleware):"},{"line_number":407,"context_line":"    def setUp(self):"},{"line_number":408,"context_line":"        super(TestStorletMiddlewareObject, self).setUp()"},{"line_number":409,"context_line":"        self.conf[\u0027execution_server\u0027] \u003d \u0027object\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_82931da3","line":406,"range":{"start_line":406,"start_character":10,"end_line":406,"end_character":17},"in_reply_to":"dae33548_51aa89d5","updated":"2016-02-15 10:47:08.000000000","message":"Done","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5311f158b4ac4e85de837996c5ca4f942ca82a8a","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            \u0027/v1/acc/cont/obj\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027GET\u0027},"},{"line_number":560,"context_line":"            headers\u003d{\u0027X-Backend-Storlet-Policy-Index\u0027: \u00270\u0027,"},{"line_number":561,"context_line":"                     \u0027X-Run-Storlet\u0027: \u0027Storlet-1.0.jar\u0027})"},{"line_number":562,"context_line":"        # TODO(kota_): make the validation method and change this with"},{"line_number":563,"context_line":"        #             the validation mock"},{"line_number":564,"context_line":"        with mock.patch(\u0027storlet_middleware.storlet_handler.get_account_info\u0027,"},{"line_number":565,"context_line":"                        return_value\u003d{\u0027meta\u0027: {\u0027storlet-enabled\u0027: \u0027true\u0027}}):"},{"line_number":566,"context_line":"            handler \u003d self.handler_class("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_d11a196e","line":563,"range":{"start_line":562,"start_character":8,"end_line":563,"end_character":41},"updated":"2016-02-15 09:49:20.000000000","message":"I\u0027m going to deal with this in my ut refactoring patch[1].\n\n1. https://review.openstack.org/#/c/277322/","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f60966dc0bcceee15d3a68b138807c1361d4249e","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            \u0027/v1/acc/cont/obj\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027GET\u0027},"},{"line_number":560,"context_line":"            headers\u003d{\u0027X-Backend-Storlet-Policy-Index\u0027: \u00270\u0027,"},{"line_number":561,"context_line":"                     \u0027X-Run-Storlet\u0027: \u0027Storlet-1.0.jar\u0027})"},{"line_number":562,"context_line":"        # TODO(kota_): make the validation method and change this with"},{"line_number":563,"context_line":"        #             the validation mock"},{"line_number":564,"context_line":"        with mock.patch(\u0027storlet_middleware.storlet_handler.get_account_info\u0027,"},{"line_number":565,"context_line":"                        return_value\u003d{\u0027meta\u0027: {\u0027storlet-enabled\u0027: \u0027true\u0027}}):"},{"line_number":566,"context_line":"            handler \u003d self.handler_class("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_c20085ad","line":563,"range":{"start_line":562,"start_character":8,"end_line":563,"end_character":41},"in_reply_to":"dae33548_d11a196e","updated":"2016-02-15 10:47:08.000000000","message":"Thanks! Change the assignee to you!","commit_id":"3626ac59b676ac4b06171ebfdc25a68018a04c05"}]}