)]}'
{"Engine/storlet_daemon_factory/daemon_factory.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"a0136aa2ea84c213b12b6324d1ead73e596ea7bb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            str_library_path \u003d str_prfx"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # TODO(takashi): We should not set environ value here, because this"},{"line_number":115,"context_line":"        #                affects the base process"},{"line_number":116,"context_line":"        os.environ[\u0027CLASSPATH\u0027] \u003d str_dmn_clspth"},{"line_number":117,"context_line":"        os.environ[\u0027LD_LIBRARY_PATH\u0027] \u003d str_library_path"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_178082f6","line":114,"updated":"2016-07-30 19:13:58.000000000","message":"I agree. The original code used parts to pass these, then at some point the who changed this to environ claimed he could not make  work purely via pargs. I am not sure why though... perhaps parts is limited in length?","commit_id":"7ebd49cf3141a082e9c2a9f9979fa65fb57dfb40"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"a0136aa2ea84c213b12b6324d1ead73e596ea7bb","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            error_text \u003d \u0027Failed to start subprocess %s\u0027 % str(pargs)"},{"line_number":180,"context_line":"            self.logger.exception(error_text)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # TODO(takashi): Now we return error text in tuple, but I think we had"},{"line_number":183,"context_line":"        #                better make this raise Exception including message"},{"line_number":184,"context_line":"        return b_status, error_text"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7771fe43","line":182,"updated":"2016-07-30 19:13:58.000000000","message":"Agree. I do not like this tuple being returned as well.","commit_id":"7ebd49cf3141a082e9c2a9f9979fa65fb57dfb40"}]}