)]}'
{"Engine/SBus/SBusPythonFacade/SBusDatagram.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"4e86b70c6c5cc35e188d3fb9e0af371eb50012cf","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SBusDatagram(object):"},{"line_number":34,"context_line":"    def __init__(self, command, fds, metadata, params\u003dNone,"},{"line_number":35,"context_line":"                 task_id\u003dNone):"},{"line_number":36,"context_line":"        self.command \u003d command"},{"line_number":37,"context_line":"        self.fds \u003d fds"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_4864e2b7","line":34,"updated":"2016-08-01 19:50:43.000000000","message":"task_id is used only on the client side, and params is a dictionary on the client and string on the server","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e0565f2a754edbe8244ad6455290484d8076782","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SBusDatagram(object):"},{"line_number":34,"context_line":"    def __init__(self, command, fds, metadata, params\u003dNone,"},{"line_number":35,"context_line":"                 task_id\u003dNone):"},{"line_number":36,"context_line":"        self.command \u003d command"},{"line_number":37,"context_line":"        self.fds \u003d fds"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_2eab3d8b","line":34,"in_reply_to":"9ad45d7e_881d01c0","updated":"2016-08-08 15:32:31.000000000","message":"\u003e\u003e     task_id is used only on the client side\n\u003e need to fix, thanks!\n\nAfter some thoughts I\u0027d like to change my previous comments.\nCurrently we don\u0027t use task_id in server side, but it is needed when we introduce python SDaemon, right?\n\nIf that is true, I\u0027d like to keep my current code. It\u0027s not so strange thing to have task_id at both sides","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b21c753e4559cdeb555c6db855360f6bb203ebd","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SBusDatagram(object):"},{"line_number":34,"context_line":"    def __init__(self, command, fds, metadata, params\u003dNone,"},{"line_number":35,"context_line":"                 task_id\u003dNone):"},{"line_number":36,"context_line":"        self.command \u003d command"},{"line_number":37,"context_line":"        self.fds \u003d fds"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_881d01c0","line":34,"in_reply_to":"bacf61ea_4864e2b7","updated":"2016-08-08 15:00:21.000000000","message":"\u003e task_id is used only on the client side\n\nneed to fix, thanks!\n\n\u003e params is a dictionary on the client and string on the server\n\nAs far as I understand, daemon_factory treats params as dictionary.","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"4e86b70c6c5cc35e188d3fb9e0af371eb50012cf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cmd_params \u003d property(_get_cmd_params, _set_cmd_params)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def serialized_cmd_params(self):"},{"line_number":64,"context_line":"        return json.dumps(self.cmd_params)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_28e7ee40","line":63,"updated":"2016-08-01 19:50:43.000000000","message":"This is required only on the client side","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b21c753e4559cdeb555c6db855360f6bb203ebd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cmd_params \u003d property(_get_cmd_params, _set_cmd_params)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def serialized_cmd_params(self):"},{"line_number":64,"context_line":"        return json.dumps(self.cmd_params)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_88eea1ea","line":63,"in_reply_to":"bacf61ea_28e7ee40","updated":"2016-08-08 15:00:21.000000000","message":"will fix","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"4e86b70c6c5cc35e188d3fb9e0af371eb50012cf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return json.dumps(self.cmd_params)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def serialized_md(self):"},{"line_number":68,"context_line":"        return json.dumps(self.metadata)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_88cc1abc","line":67,"updated":"2016-08-01 19:50:43.000000000","message":"This is required only on the client side","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b21c753e4559cdeb555c6db855360f6bb203ebd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return json.dumps(self.cmd_params)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def serialized_md(self):"},{"line_number":68,"context_line":"        return json.dumps(self.metadata)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e8b91dee","line":67,"in_reply_to":"bacf61ea_88cc1abc","updated":"2016-08-08 15:00:21.000000000","message":"will fix","commit_id":"386cf75f0bd16189447a5140cac9a35f1da8207a"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"011781655d4f54bb08fcd7898379fc3a3841a5c4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from SBusPythonFacade.SBusFileDescription import SBUS_FD_SERVICE_OUT"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class FDMetadata(object):"},{"line_number":34,"context_line":"    def __init__(self, fdtype, storlets_metadata\u003dNone, storage_metadata\u003dNone):"},{"line_number":35,"context_line":"        self.fdtype \u003d fdtype"},{"line_number":36,"context_line":"        self.storlets_metadata \u003d storlets_metadata or {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_e77a4387","line":33,"updated":"2016-08-17 19:56:05.000000000","message":"Nice! Certainly belongs here and not in runtime...","commit_id":"6803b0eb5271f65fb39ea36cb36d1c0236d7a298"}]}