)]}'
{"Engine/swift/storlet_gateway/gateways/docker/gateway.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"268e7891b188be82375faae3c9e6c45cc2fee4fb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            if name.endswith(\u0027.py\u0027):"},{"line_number":123,"context_line":"                cls_name \u003d params[\u0027Main\u0027]"},{"line_number":124,"context_line":"                if not cls_name.startswith(name[:-3] + \u0027.\u0027):"},{"line_number":125,"context_line":"                    raise ValueError(\u0027Main class should be included in \u0027"},{"line_number":126,"context_line":"                                     \u0027storlet file\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"                if len(cls_name.split(\u0027.\u0027)) !\u003d 2:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_28414f3a","line":125,"updated":"2016-09-02 20:44:21.000000000","message":"I got confused by the message here.\nLooking at the tests I gather that the rule is:\nif name \u003d \"myteststorlet.py\"\nthen the class name should be myteststorlet.mymainclassname\n\nSo  the error message should probably be something like:\n\"Main class must be prefixed by storlet file\"\n\nIts not very important - I am mainly checking if I got the intention right...","commit_id":"49bc2e45302ba2484044f7efc9f796cf80d69874"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a677a6e31e443da9063b8339aca3e3e88cfc65d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            if name.endswith(\u0027.py\u0027):"},{"line_number":123,"context_line":"                cls_name \u003d params[\u0027Main\u0027]"},{"line_number":124,"context_line":"                if not cls_name.startswith(name[:-3] + \u0027.\u0027):"},{"line_number":125,"context_line":"                    raise ValueError(\u0027Main class should be included in \u0027"},{"line_number":126,"context_line":"                                     \u0027storlet file\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"                if len(cls_name.split(\u0027.\u0027)) !\u003d 2:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_41966995","line":125,"in_reply_to":"9a89bdaa_28414f3a","updated":"2016-09-03 06:36:35.000000000","message":"You are totally right.\n\nThe only thing I\u0027m worried about your suggestion is that it may let users to think that main class should be name like like \u0027myteststorlet.py.foo\u0027 .\n\nHow about this?\n\n\u0027Main class should be included in the storlet module:  %s\u0027 %  name[:-3]","commit_id":"49bc2e45302ba2484044f7efc9f796cf80d69874"}]}