)]}'
{"install/storlets/roles/docker_registry/tasks/main.yml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"53db09b2badb19d108662ced1b5005257bbbf9d1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    mode: 0755"},{"line_number":25,"context_line":"  when: not st0.stat.exists"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Start Docker repository service"},{"line_number":28,"context_line":"  shell: bash -c \"/usr/sbin/service docker-registry start\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Update docker service to restart docker-registry"},{"line_number":31,"context_line":"  shell: perl -0777 -pi -e \u0027s/;;\\n\\n\\tstop\\)/service docker-registry restart\\n\\t\\t;;\\n\\n\\tstop\\)/igs\u0027 /etc/init.d/docker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_985e0075","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":58},"updated":"2016-09-09 13:50:35.000000000","message":"If we register docker registry as service, using service module[1] seems more reasonable for me.\n\n[1] http://docs.ansible.com/ansible/service_module.html","commit_id":"bfa45510654f8977dccf0c57e1a01d36c6288d4b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1037edb2fe7c99ada4ebcfa4ed736877a6a26769","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    mode: 0755"},{"line_number":25,"context_line":"  when: not st0.stat.exists"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Start Docker repository service"},{"line_number":28,"context_line":"  shell: bash -c \"/usr/sbin/service docker-registry start\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Update docker service to restart docker-registry"},{"line_number":31,"context_line":"  shell: perl -0777 -pi -e \u0027s/;;\\n\\n\\tstop\\)/service docker-registry restart\\n\\t\\t;;\\n\\n\\tstop\\)/igs\u0027 /etc/init.d/docker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_79f8427d","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":58},"in_reply_to":"9a89bdaa_7925b4ac","updated":"2016-09-10 06:48:33.000000000","message":"OK. We can currently keep this, but IMO it is better to migrate to service module after fixing that problem.\nCan you share the error you faced when installing in docker container? I\u0027ll have a look later.","commit_id":"bfa45510654f8977dccf0c57e1a01d36c6288d4b"},{"author":{"_account_id":8330,"name":"Doron Chen","email":"cdoron@il.ibm.com","username":"cdoron"},"change_message_id":"49965e9aaa89e75ecb94caa12d45760f390252fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    mode: 0755"},{"line_number":25,"context_line":"  when: not st0.stat.exists"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Start Docker repository service"},{"line_number":28,"context_line":"  shell: bash -c \"/usr/sbin/service docker-registry start\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Update docker service to restart docker-registry"},{"line_number":31,"context_line":"  shell: perl -0777 -pi -e \u0027s/;;\\n\\n\\tstop\\)/service docker-registry restart\\n\\t\\t;;\\n\\n\\tstop\\)/igs\u0027 /etc/init.d/docker"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_7925b4ac","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":58},"in_reply_to":"9a89bdaa_985e0075","updated":"2016-09-09 18:06:18.000000000","message":"I am having problems with the ansible service module. It does not work for me when I try to install swift and the storlet engine in a docker container.","commit_id":"bfa45510654f8977dccf0c57e1a01d36c6288d4b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"53db09b2badb19d108662ced1b5005257bbbf9d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- name: Start Docker repository service"},{"line_number":28,"context_line":"  shell: bash -c \"/usr/sbin/service docker-registry start\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Update docker service to restart docker-registry"},{"line_number":31,"context_line":"  shell: perl -0777 -pi -e \u0027s/;;\\n\\n\\tstop\\)/service docker-registry restart\\n\\t\\t;;\\n\\n\\tstop\\)/igs\u0027 /etc/init.d/docker"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Test repository"},{"line_number":34,"context_line":"  shell: docker images | grep my_busybox | wc -l"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_d8696827","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":120},"updated":"2016-09-09 13:50:35.000000000","message":"Why do we need this?","commit_id":"bfa45510654f8977dccf0c57e1a01d36c6288d4b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1037edb2fe7c99ada4ebcfa4ed736877a6a26769","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- name: Start Docker repository service"},{"line_number":28,"context_line":"  shell: bash -c \"/usr/sbin/service docker-registry start\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Update docker service to restart docker-registry"},{"line_number":31,"context_line":"  shell: perl -0777 -pi -e \u0027s/;;\\n\\n\\tstop\\)/service docker-registry restart\\n\\t\\t;;\\n\\n\\tstop\\)/igs\u0027 /etc/init.d/docker"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Test repository"},{"line_number":34,"context_line":"  shell: docker images | grep my_busybox | wc -l"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_19073682","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":120},"in_reply_to":"9a89bdaa_992a787d","updated":"2016-09-10 06:48:33.000000000","message":"I\u0027m afraid this can cause a problem, when one tries to update docker package after storlet installation.\n\nDoes it make sense to restart policy intead? [1]\nMaybe we can set --restart unless-stopped\n\n[1] https://docs.docker.com/engine/reference/run/#restart-policies-restart","commit_id":"bfa45510654f8977dccf0c57e1a01d36c6288d4b"},{"author":{"_account_id":8330,"name":"Doron Chen","email":"cdoron@il.ibm.com","username":"cdoron"},"change_message_id":"49965e9aaa89e75ecb94caa12d45760f390252fc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- name: Start Docker repository service"},{"line_number":28,"context_line":"  shell: bash -c \"/usr/sbin/service docker-registry start\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Update docker service to restart docker-registry"},{"line_number":31,"context_line":"  shell: perl -0777 -pi -e \u0027s/;;\\n\\n\\tstop\\)/service docker-registry restart\\n\\t\\t;;\\n\\n\\tstop\\)/igs\u0027 /etc/init.d/docker"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Test repository"},{"line_number":34,"context_line":"  shell: docker images | grep my_busybox | wc -l"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_992a787d","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":120},"in_reply_to":"9a89bdaa_d8696827","updated":"2016-09-09 18:06:18.000000000","message":"Currently, when we restart the docker service, the docker registry docker container stops. These lines are here to change the docker service so that when it is started or restarted, it also starts the docker-registry service.","commit_id":"bfa45510654f8977dccf0c57e1a01d36c6288d4b"}]}
