)]}'
{"Engine/agent/storlet_daemon/files.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"d1829dfb3745139e5a6c272db3ad66eaf1b17002","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return copy.deepcopy(self._metadata)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def set_metadata(self, md):"},{"line_number":97,"context_line":"        if self.md_file.closed:"},{"line_number":98,"context_line":"            raise IOError(\u0027Sending metadata twice is not allowed\u0027)"},{"line_number":99,"context_line":"        self.md_file.write(json.dumps(md))"},{"line_number":100,"context_line":"        self._metadata \u003d md"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_8f3f50d5","line":97,"updated":"2016-09-15 14:38:03.000000000","message":"Does it also make sense to check: if self.close raise...","commit_id":"193b3049a86cca760e10508a2e705c8c11a4cbcd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94e2c381a55bf960dfa0d3e10ac683b28d027b54","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return copy.deepcopy(self._metadata)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def set_metadata(self, md):"},{"line_number":97,"context_line":"        if self.md_file.closed:"},{"line_number":98,"context_line":"            raise IOError(\u0027Sending metadata twice is not allowed\u0027)"},{"line_number":99,"context_line":"        self.md_file.write(json.dumps(md))"},{"line_number":100,"context_line":"        self._metadata \u003d md"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_85100faa","line":97,"in_reply_to":"7a8ec9b2_8f3f50d5","updated":"2016-09-15 15:00:53.000000000","message":"When we close obj_file, we also close md_file (See L104-105), so IMO it is not necessary.","commit_id":"193b3049a86cca760e10508a2e705c8c11a4cbcd"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"719f7eb6face6f163cbbfa07f814185be2947208","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return copy.deepcopy(self._metadata)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def set_metadata(self, md):"},{"line_number":97,"context_line":"        if self.md_file.closed:"},{"line_number":98,"context_line":"            raise IOError(\u0027Sending metadata twice is not allowed\u0027)"},{"line_number":99,"context_line":"        self.md_file.write(json.dumps(md))"},{"line_number":100,"context_line":"        self._metadata \u003d md"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_be5a7c4e","line":97,"in_reply_to":"7a8ec9b2_8f3f50d5","updated":"2016-09-15 15:33:07.000000000","message":"missed that. sorry.","commit_id":"193b3049a86cca760e10508a2e705c8c11a4cbcd"}]}