)]}'
{"build.xml":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u003c/target\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \u003ctarget name\u003d\"uninstall_engine\"\u003e"},{"line_number":33,"context_line":"        \u003cant dir\u003d\"src/java\" target\u003d\"install\" /\u003e"},{"line_number":34,"context_line":"    \u003c/target\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \u003c!-- Storlets Samples build --\u003e"}],"source_content_type":"application/xml","patch_set":50,"id":"9a629dbe_c7ba256e","line":33,"range":{"start_line":33,"start_character":36,"end_line":33,"end_character":43},"updated":"2016-11-09 08:49:17.000000000","message":"Should this be uninstall?","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u003c/target\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \u003ctarget name\u003d\"uninstall_engine\"\u003e"},{"line_number":33,"context_line":"        \u003cant dir\u003d\"src/java\" target\u003d\"install\" /\u003e"},{"line_number":34,"context_line":"    \u003c/target\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \u003c!-- Storlets Samples build --\u003e"}],"source_content_type":"application/xml","patch_set":50,"id":"7a77a97e_1e7fd166","line":33,"range":{"start_line":33,"start_character":36,"end_line":33,"end_character":43},"in_reply_to":"9a629dbe_c7ba256e","updated":"2016-11-17 16:35:15.000000000","message":"Done","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"}],"doc/source/installation.rst":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"c2e67a4ab1ff3b76d76e9707b1cfeb0a0f5e3e2b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Note: The hosts file used for running the playbook is also used by the admin tool to deploy future images. Thus, the ssh information kept in"},{"line_number":122,"context_line":"this file must also apply when used from the storlet-mgmt node."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Install only Storlets package"},{"line_number":125,"context_line":"-------"},{"line_number":126,"context_line":"You can install only storlets package, without updating any configraiton files, by the following two steps:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":56,"id":"5a74a57a_a6cc6f62","line":124,"updated":"2016-11-30 20:46:48.000000000","message":"I think that specifying this section here is somewhat misleading as this doc describes how to install storlets over an existing Swift installation. I think that this belongs to the \"Intall Storlets\" section in doc/source/engine_dev_installation.rst.\nMore specificaly, I think that what we need is this:\nhttps://gist.github.com/anonymous/625a8dad0dfac617a34bf29328fcc563","commit_id":"0bef0a89d2da666dea2cc514f441705464428f98"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5f9ff0b68e836b5fb18dc843bb992bf844e7cbf","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Note: The hosts file used for running the playbook is also used by the admin tool to deploy future images. Thus, the ssh information kept in"},{"line_number":122,"context_line":"this file must also apply when used from the storlet-mgmt node."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Install only Storlets package"},{"line_number":125,"context_line":"-------"},{"line_number":126,"context_line":"You can install only storlets package, without updating any configraiton files, by the following two steps:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":56,"id":"5a74a57a_3426c016","line":124,"in_reply_to":"5a74a57a_a6cc6f62","updated":"2016-12-01 01:30:35.000000000","message":"Done\n\nMerged, thanks a lot!","commit_id":"0bef0a89d2da666dea2cc514f441705464428f98"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"c2e67a4ab1ff3b76d76e9707b1cfeb0a0f5e3e2b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  $ sudo ./install_libs.sh"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  # install storlets python package"},{"line_number":134,"context_line":"  $ sudo python setup.py"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Note: you don\u0027t need sudo for \u0027python setup.py\u0027 when you install storlets package into your python virtualenv."}],"source_content_type":"text/x-rst","patch_set":56,"id":"5a74a57a_86ddb372","line":134,"range":{"start_line":134,"start_character":16,"end_line":134,"end_character":24},"updated":"2016-11-30 20:46:48.000000000","message":"setup.py install (?)","commit_id":"0bef0a89d2da666dea2cc514f441705464428f98"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5f9ff0b68e836b5fb18dc843bb992bf844e7cbf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  $ sudo ./install_libs.sh"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  # install storlets python package"},{"line_number":134,"context_line":"  $ sudo python setup.py"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Note: you don\u0027t need sudo for \u0027python setup.py\u0027 when you install storlets package into your python virtualenv."}],"source_content_type":"text/x-rst","patch_set":56,"id":"5a74a57a_d47bccf2","line":134,"range":{"start_line":134,"start_character":16,"end_line":134,"end_character":24},"in_reply_to":"5a74a57a_86ddb372","updated":"2016-12-01 01:30:35.000000000","message":"Done","commit_id":"0bef0a89d2da666dea2cc514f441705464428f98"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5f9ff0b68e836b5fb18dc843bb992bf844e7cbf","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  # install storlets python package"},{"line_number":134,"context_line":"  $ sudo python setup.py"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Note: you don\u0027t need sudo for \u0027python setup.py\u0027 when you install storlets package into your python virtualenv."}],"source_content_type":"text/x-rst","patch_set":56,"id":"5a74a57a_54689c21","line":136,"range":{"start_line":136,"start_character":31,"end_line":136,"end_character":46},"updated":"2016-12-01 01:30:35.000000000","message":"also fixed","commit_id":"0bef0a89d2da666dea2cc514f441705464428f98"}],"install/storlets/prepare_storlets_install.sh":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"sudo apt-get install -y python-setuptools"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Build c/java engine codes"},{"line_number":44,"context_line":"sudo ./install_libs.sh"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Build Storlets"},{"line_number":47,"context_line":"ant build_storlets"}],"source_content_type":"text/x-sh","patch_set":50,"id":"9a629dbe_7ae1eccf","line":44,"updated":"2016-11-09 08:49:17.000000000","message":"Any chance that this is redundant, given the role: host_storlet_engine_install which call install_libs.sh after copying?","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"30f7ccef699cd2ad69ef91fa46ead084b8610f21","unresolved":false,"context_lines":[{"line_number":41,"context_line":"sudo apt-get install -y python-setuptools"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Build c/java engine codes"},{"line_number":44,"context_line":"sudo ./install_libs.sh"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Build Storlets"},{"line_number":47,"context_line":"ant build_storlets"}],"source_content_type":"text/x-sh","patch_set":50,"id":"7a77a97e_3fb2c794","line":44,"in_reply_to":"7a77a97e_64403235","updated":"2016-11-17 17:01:42.000000000","message":"Sorry, I reverted this because I found out that this is needed. Currently we need to copy c libs or other built files from local host to remote host where we install storlets, for docker building, so we need to build files here.","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":41,"context_line":"sudo apt-get install -y python-setuptools"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Build c/java engine codes"},{"line_number":44,"context_line":"sudo ./install_libs.sh"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Build Storlets"},{"line_number":47,"context_line":"ant build_storlets"}],"source_content_type":"text/x-sh","patch_set":50,"id":"7a77a97e_64403235","line":44,"in_reply_to":"9a629dbe_7ae1eccf","updated":"2016-11-17 16:35:15.000000000","message":"Done","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"sudo ./install_libs.sh"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Build Storlets"},{"line_number":47,"context_line":"ant build_storlets"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# The rest of the operations are all relative to"},{"line_number":50,"context_line":"# install/storlets/"}],"source_content_type":"text/x-sh","patch_set":50,"id":"9a629dbe_7a4e4c97","line":47,"updated":"2016-11-09 08:49:17.000000000","message":"Since we copy all the repo to the remote host, where the storlets binaries are not required, we may want to postpone this step to the end, or even not include it at all in the installation, and add it instead to the func tests scripts","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":44,"context_line":"sudo ./install_libs.sh"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Build Storlets"},{"line_number":47,"context_line":"ant build_storlets"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# The rest of the operations are all relative to"},{"line_number":50,"context_line":"# install/storlets/"}],"source_content_type":"text/x-sh","patch_set":50,"id":"7a77a97e_c4758698","line":47,"in_reply_to":"9a629dbe_7a4e4c97","updated":"2016-11-17 16:35:15.000000000","message":"Done","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"}],"install/storlets/roles/docker_base_jre_image/templates/ubuntu_14.04_jre8_Dockerfile":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# to prevent docker images from including apt cache file."},{"line_number":22,"context_line":"RUN apt-get update \u0026\u0026 \\"},{"line_number":23,"context_line":"    apt-get install python -y \u0026\u0026 \\"},{"line_number":24,"context_line":"    apt-get install git -y \u0026\u0026 \\"},{"line_number":25,"context_line":"    apt-get install software-properties-common -y \u0026\u0026 \\"},{"line_number":26,"context_line":"    add-apt-repository ppa:openjdk-r/ppa -y \u0026\u0026 \\"},{"line_number":27,"context_line":"    apt-get update \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":50,"id":"9a629dbe_9a132066","line":24,"updated":"2016-11-09 08:49:17.000000000","message":"Do we need git in the container?","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# to prevent docker images from including apt cache file."},{"line_number":22,"context_line":"RUN apt-get update \u0026\u0026 \\"},{"line_number":23,"context_line":"    apt-get install python -y \u0026\u0026 \\"},{"line_number":24,"context_line":"    apt-get install git -y \u0026\u0026 \\"},{"line_number":25,"context_line":"    apt-get install software-properties-common -y \u0026\u0026 \\"},{"line_number":26,"context_line":"    add-apt-repository ppa:openjdk-r/ppa -y \u0026\u0026 \\"},{"line_number":27,"context_line":"    apt-get update \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":50,"id":"7a77a97e_fe55b5c1","line":24,"in_reply_to":"9a629dbe_9a132066","updated":"2016-11-17 16:35:15.000000000","message":"This is needed when we install storlets package. Currently we use pbr for installation, and pbr requires some information retrieved via git.","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"}],"install/storlets/roles/docker_storlet_engine_image/tasks/main.yml":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - \"src/java/SCommon/bin/SCommon.jar\""},{"line_number":43,"context_line":"    - \"src/java/SDaemon/bin/SDaemon.jar\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Copy python codes"},{"line_number":46,"context_line":"  copy:"},{"line_number":47,"context_line":"    src: \"{{ storlet_source_dir }}\""},{"line_number":48,"context_line":"    dest: \"/data/registry/repositories/{{ base_os_image }}_jre8_storlets/storlets\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9a629dbe_3de4ce39","line":45,"updated":"2016-11-09 08:49:17.000000000","message":"Given that we copy the whole repo here, can we save on  lines 29-43 and change the Dockerfile accordingly? Not very important as we are going to get rid of this anyway soon...","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - \"src/java/SCommon/bin/SCommon.jar\""},{"line_number":43,"context_line":"    - \"src/java/SDaemon/bin/SDaemon.jar\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Copy python codes"},{"line_number":46,"context_line":"  copy:"},{"line_number":47,"context_line":"    src: \"{{ storlet_source_dir }}\""},{"line_number":48,"context_line":"    dest: \"/data/registry/repositories/{{ base_os_image }}_jre8_storlets/storlets\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"7a77a97e_de8e392d","line":45,"in_reply_to":"9a629dbe_3de4ce39","updated":"2016-11-17 16:35:15.000000000","message":"Maybe we can improve this somehow, but I\u0027d like to keep it currently, to achieve our goal (refactor package) first, and then think about refactor installation to make it more effective.","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"}],"install_libs.sh":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Install required libraries written in c and java"},{"line_number":4,"context_line":"# "},{"line_number":5,"context_line":"# NOTE: The libraries are currently installed under /usr/lib/storlets"},{"line_number":6,"context_line":"#       so you may nee root priviledge to execute this script"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-sh","patch_set":50,"id":"9a629dbe_9a42400f","line":4,"range":{"start_line":4,"start_character":1,"end_line":4,"end_character":2},"updated":"2016-11-09 08:49:17.000000000","message":"nit: redundant space","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Install required libraries written in c and java"},{"line_number":4,"context_line":"# "},{"line_number":5,"context_line":"# NOTE: The libraries are currently installed under /usr/lib/storlets"},{"line_number":6,"context_line":"#       so you may nee root priviledge to execute this script"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-sh","patch_set":50,"id":"7a77a97e_9e712147","line":4,"range":{"start_line":4,"start_character":1,"end_line":4,"end_character":2},"in_reply_to":"9a629dbe_9a42400f","updated":"2016-11-17 16:35:15.000000000","message":"Done","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Install required libraries written in c and java"},{"line_number":4,"context_line":"# "},{"line_number":5,"context_line":"# NOTE: The libraries are currently installed under /usr/lib/storlets"},{"line_number":6,"context_line":"#       so you may nee root priviledge to execute this script"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# build scripts"},{"line_number":9,"context_line":"cd scripts"}],"source_content_type":"text/x-sh","patch_set":50,"id":"9a629dbe_fa47bc1a","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":22},"updated":"2016-11-09 08:49:17.000000000","message":"need","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Install required libraries written in c and java"},{"line_number":4,"context_line":"# "},{"line_number":5,"context_line":"# NOTE: The libraries are currently installed under /usr/lib/storlets"},{"line_number":6,"context_line":"#       so you may nee root priviledge to execute this script"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# build scripts"},{"line_number":9,"context_line":"cd scripts"}],"source_content_type":"text/x-sh","patch_set":50,"id":"7a77a97e_be909d44","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":22},"in_reply_to":"9a629dbe_fa47bc1a","updated":"2016-11-17 16:35:15.000000000","message":"Done","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2c925c6b3f8b2451b152a6977435de25f46957fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"7a77a97e_b4118006","updated":"2016-11-18 08:00:29.000000000","message":"Should this be in install dir?\n\nIt looks like no installation script except s2aio.sh should not be at the top directory in the repo.\n\nProbably sdeploy.sh which we don\u0027t touch with this patch also should be into there.","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"707ba5089e7a7bf3bf45a9f721c09313b0a69219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"7a77a97e_c259da36","in_reply_to":"7a77a97e_b4118006","updated":"2016-11-18 08:32:13.000000000","message":"I place this file at the top directory, because this file is used to install storlets package like setup.py, while some scripts under install is used to setup storlets env.","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"c5c1eec93ef56bcd3a64867a80d55dfe97834724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"7a77a97e_581bfac9","in_reply_to":"7a77a97e_c259da36","updated":"2016-11-18 10:58:14.000000000","message":"Hmmm... if so, I\u0027d like to identify the role for the following files:\n\n- sdeploy.sh\n- s2aio.sh\n- install_libs.sh\n\nThose look similar and it\u0027s difficult to know the difference from the names. All looks the scripts for deployment.\n\nI thought you\u0027re trying to make s2aio.sh for the entry point to install all-in-one environment and all of the package will be installed via setup tools but it seems that i was missing something.\n\nEven if we need to setup script for java/c code native library, less files at the top directly always helps to understand how to deploy this...\n\nEither is fine to use \u0027ant\u0027, \u0027make\u0027 or \u0027setuptools\u0027 but I think the easy way (the goal I thought) is likely:\n\n make host # setup all host-related component\n make guest # setup all container-side component\n make all # both of them\n make built-test # build, deploy sample storlets\n make test # run functional\n\n etc...\n\nfor the example above, setuptools and ant will help to build and install them.\n\ne.g.\nhttps://gist.github.com/bloodeagle40234/d93f7cfec1746171723fbecf2ee14f05","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"}],"scripts/send_halt_cmd_to_daemon_factory.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2c925c6b3f8b2451b152a6977435de25f46957fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"7a77a97e_345010d4","updated":"2016-11-18 08:00:29.000000000","message":"Should this file be in \"bin\" dir removing .py suffix?\n\nit looks executable script should be there.","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"707ba5089e7a7bf3bf45a9f721c09313b0a69219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"7a77a97e_429a2a6f","in_reply_to":"7a77a97e_345010d4","updated":"2016-11-18 08:32:13.000000000","message":"IMO, yes, but currently we have scripts directory because they are not placed under bin but under /data/scripts, where we place all management script about storlets. I think it is better to change that, but I\u0027d like to leave it as it is now, and do that as follow-up.","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"}],"setup.cfg":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[pbr]"},{"line_number":20,"context_line":"skip_authors \u003d True"},{"line_number":21,"context_line":"skip_changelog \u003d True"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[files]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":50,"id":"9a629dbe_38221c01","line":20,"updated":"2016-11-09 08:49:17.000000000","message":"At some point we will probably want to bring it back","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[pbr]"},{"line_number":20,"context_line":"skip_authors \u003d True"},{"line_number":21,"context_line":"skip_changelog \u003d True"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[files]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":50,"id":"7a77a97e_f954effe","line":20,"in_reply_to":"9a629dbe_38221c01","updated":"2016-11-17 16:35:15.000000000","message":"Please note that if we choose to bring them back, we need to remove our hand-made AUTHOR and CHANGELOG file, because they are created by pbr automatically.","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2c925c6b3f8b2451b152a6977435de25f46957fe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"paste.filter_factory \u003d"},{"line_number":32,"context_line":"    storlet_handler \u003d storlets.swift_middleware.storlet_handler:filter_factory"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"storlets.gateways \u003d"},{"line_number":35,"context_line":"    stub \u003d storlets.gateway.gateways.stub:StorletGatewayStub"},{"line_number":36,"context_line":"    docker \u003d storlets.gateway.gateways.docker:StorletGatewayDocker"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[build_sphinx]"},{"line_number":39,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":55,"id":"7a77a97e_f7dbfa79","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":66},"updated":"2016-11-18 08:00:29.000000000","message":"probably we can remove those entry points with a few changes in the gateway loader mechanism because the gateway module is now in storlets packages for your python environment. It seems package work but I\u0027m not sure we have to address this immediately.","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"c5c1eec93ef56bcd3a64867a80d55dfe97834724","unresolved":false,"context_lines":[{"line_number":31,"context_line":"paste.filter_factory \u003d"},{"line_number":32,"context_line":"    storlet_handler \u003d storlets.swift_middleware.storlet_handler:filter_factory"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"storlets.gateways \u003d"},{"line_number":35,"context_line":"    stub \u003d storlets.gateway.gateways.stub:StorletGatewayStub"},{"line_number":36,"context_line":"    docker \u003d storlets.gateway.gateways.docker:StorletGatewayDocker"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[build_sphinx]"},{"line_number":39,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":55,"id":"7a77a97e_f816864a","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":66},"in_reply_to":"7a77a97e_62e006ce","updated":"2016-11-18 10:58:14.000000000","message":"Ok, I think we can keep the loader for third-parties but no more reason to use entry point???","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"707ba5089e7a7bf3bf45a9f721c09313b0a69219","unresolved":false,"context_lines":[{"line_number":31,"context_line":"paste.filter_factory \u003d"},{"line_number":32,"context_line":"    storlet_handler \u003d storlets.swift_middleware.storlet_handler:filter_factory"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"storlets.gateways \u003d"},{"line_number":35,"context_line":"    stub \u003d storlets.gateway.gateways.stub:StorletGatewayStub"},{"line_number":36,"context_line":"    docker \u003d storlets.gateway.gateways.docker:StorletGatewayDocker"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[build_sphinx]"},{"line_number":39,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":55,"id":"7a77a97e_62e006ce","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":66},"in_reply_to":"7a77a97e_f7dbfa79","updated":"2016-11-18 08:32:13.000000000","message":"Makes sense to me, but I think we need some consideration about third-party gateway driver to decide the ideal goal.","commit_id":"e51e75fca765f93e7464c24d364609c1872a7447"}],"src/java/SBus/build.xml":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u003c/javah\u003e"},{"line_number":37,"context_line":"    \u003c/target\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    \u003ctarget name\u003d\"so\" depends\u003d\"h\"\u003e"},{"line_number":40,"context_line":"        \u003cexec dir\u003d\".\" executable\u003d\"gcc\"\u003e"},{"line_number":41,"context_line":"            \u003carg line\u003d\"-shared -o bin/libjsbus.so -fPIC\" /\u003e"},{"line_number":42,"context_line":"            \u003carg line\u003d\"-I/usr/lib/jvm/java-8-openjdk-amd64/include/\" /\u003e"}],"source_content_type":"application/xml","patch_set":50,"id":"9a629dbe_5d4b4287","line":39,"updated":"2016-11-09 08:49:17.000000000","message":"I was hesitating whether this should get its own Makefile.\nI guess its here since it depends on the h file being compiled with java...","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u003c/javah\u003e"},{"line_number":37,"context_line":"    \u003c/target\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    \u003ctarget name\u003d\"so\" depends\u003d\"h\"\u003e"},{"line_number":40,"context_line":"        \u003cexec dir\u003d\".\" executable\u003d\"gcc\"\u003e"},{"line_number":41,"context_line":"            \u003carg line\u003d\"-shared -o bin/libjsbus.so -fPIC\" /\u003e"},{"line_number":42,"context_line":"            \u003carg line\u003d\"-I/usr/lib/jvm/java-8-openjdk-amd64/include/\" /\u003e"}],"source_content_type":"application/xml","patch_set":50,"id":"7a77a97e_decd5932","line":39,"in_reply_to":"9a629dbe_5d4b4287","updated":"2016-11-17 16:35:15.000000000","message":"Now we use ant for all java related stuffs, and from that point it does not seem so bad for me to have this included in build.xml.","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"}],"storlets/gateway/gateways/docker/runtime.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"6f857f003d4cd5fac4a31b47ade30a509f6556a7","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        input_fd_metadata \u003d FDMetadata("},{"line_number":591,"context_line":"            sbus_fd.SBUS_FD_INPUT_OBJECT,"},{"line_number":592,"context_line":"            storage_metadata\u003dself.srequest.user_metadata)"},{"line_number":593,"context_line":"        if self.srequest.user_metadata:"},{"line_number":594,"context_line":"            input_fd_metadata.storage_metadata.update("},{"line_number":595,"context_line":"                self.srequest.user_metadata)"},{"line_number":596,"context_line":"        if self.srequest.has_range:"}],"source_content_type":"text/x-python","patch_set":50,"id":"9a629dbe_f86ee42d","line":593,"updated":"2016-11-09 08:49:17.000000000","message":"Seems like a bonus coming outside of this patch :-)","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dafb50173fb25ccdbd73b5cbe3eb7f69581a931","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        input_fd_metadata \u003d FDMetadata("},{"line_number":591,"context_line":"            sbus_fd.SBUS_FD_INPUT_OBJECT,"},{"line_number":592,"context_line":"            storage_metadata\u003dself.srequest.user_metadata)"},{"line_number":593,"context_line":"        if self.srequest.user_metadata:"},{"line_number":594,"context_line":"            input_fd_metadata.storage_metadata.update("},{"line_number":595,"context_line":"                self.srequest.user_metadata)"},{"line_number":596,"context_line":"        if self.srequest.has_range:"}],"source_content_type":"text/x-python","patch_set":50,"id":"7a77a97e_9ea5a148","line":593,"in_reply_to":"9a629dbe_f86ee42d","updated":"2016-11-17 16:35:15.000000000","message":"Oh sorry. I currently keep this because it surely causes merge conflict later, but please let me know if you think I should submit this for independent patch.","commit_id":"a039c7bfc2e63cb28bc504cacc622b0eb3403f19"}]}