)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31e6722d70762569d2a109d2999a98e5e0e6606f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihito Takai \u003ctakaiak@nttdata.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-24 06:44:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add simple functional tests for python written storlets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the following functional tests for python written storlets"},{"line_number":10,"context_line":"is nothing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a3905b3_76a44b07","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2017-01-24 07:02:26.000000000","message":"You should describe what is simple.","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"0413ffbf3e1eb0d8e3108856f5fd6af9c17e6b68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihito Takai \u003ctakaiak@nttdata.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-24 06:44:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add simple functional tests for python written storlets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the following functional tests for python written storlets"},{"line_number":10,"context_line":"is nothing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a461143_62bc3406","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"in_reply_to":"5a3905b3_76a44b07","updated":"2017-01-26 10:22:21.000000000","message":"Done","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31e6722d70762569d2a109d2999a98e5e0e6606f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add simple functional tests for python written storlets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the following functional tests for python written storlets"},{"line_number":10,"context_line":"is nothing."},{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":"They are in java\u0027s functional tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a3905b3_1646a74e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"updated":"2017-01-24 07:02:26.000000000","message":"Currently the following method of basic storlet request methods are not tested about python written storlets.","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"0413ffbf3e1eb0d8e3108856f5fd6af9c17e6b68","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add simple functional tests for python written storlets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the following functional tests for python written storlets"},{"line_number":10,"context_line":"is nothing."},{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":"They are in java\u0027s functional tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a461143_823760af","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"in_reply_to":"5a3905b3_1646a74e","updated":"2017-01-26 10:22:21.000000000","message":"Done","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31e6722d70762569d2a109d2999a98e5e0e6606f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is nothing."},{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":"They are in java\u0027s functional tests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit add the functional tests for python written storlets."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a3905b3_d666dfeb","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":36},"updated":"2017-01-24 07:02:26.000000000","message":"I think you can remove this line.","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"0413ffbf3e1eb0d8e3108856f5fd6af9c17e6b68","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is nothing."},{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":"They are in java\u0027s functional tests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit add the functional tests for python written storlets."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a461143_a23c5c94","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":36},"in_reply_to":"5a3905b3_d666dfeb","updated":"2017-01-26 10:22:21.000000000","message":"Done","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihito Takai \u003ctakaiak@nttdata.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 10:53:31 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add insufficient functional tests about basic request method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the following method of basic storlet request methods are"},{"line_number":10,"context_line":"not tested about python written storlets."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a461143_0d139167","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2017-01-26 16:48:27.000000000","message":"How about\n\n\"Improve coverage about storlet request method in functional tests\"\n\nor\n\n\"Add missing functional tests of some request method for python written storlet\"\n\nI\u0027m afraid this means that you are adding \"incomplete\" thing...","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"cfcb41742f44aa24425ab9e84bfe294103d62646","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihito Takai \u003ctakaiak@nttdata.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 10:53:31 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add insufficient functional tests about basic request method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the following method of basic storlet request methods are"},{"line_number":10,"context_line":"not tested about python written storlets."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a461143_495454c9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"in_reply_to":"3a461143_0d139167","updated":"2017-01-30 06:16:20.000000000","message":"Done","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit add the functional tests for python written storlets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I55bca44d7c5ab3f8312af77c11b8c337a261349e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a461143_2d168d55","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":15},"updated":"2017-01-26 16:48:27.000000000","message":"(nit) adds","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit add the functional tests for python written storlets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I55bca44d7c5ab3f8312af77c11b8c337a261349e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a461143_f8028108","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":65},"updated":"2017-01-26 16:48:27.000000000","message":"these missing tests?","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"cfcb41742f44aa24425ab9e84bfe294103d62646","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit add the functional tests for python written storlets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I55bca44d7c5ab3f8312af77c11b8c337a261349e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a461143_695110d8","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":15},"in_reply_to":"3a461143_2d168d55","updated":"2017-01-30 06:16:20.000000000","message":"Done","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"cfcb41742f44aa24425ab9e84bfe294103d62646","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- COPY request"},{"line_number":12,"context_line":"- large object PUT request"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit add the functional tests for python written storlets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I55bca44d7c5ab3f8312af77c11b8c337a261349e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a461143_8960fca6","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":65},"in_reply_to":"3a461143_f8028108","updated":"2017-01-30 06:16:20.000000000","message":"Done","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"}],"tests/functional/python/test_simple_storlet.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31e6722d70762569d2a109d2999a98e5e0e6606f","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @attr(\u0027slow\u0027)"},{"line_number":91,"context_line":"    def test_put_512MB_file(self):"},{"line_number":92,"context_line":"        gf_file_path \u003d \u0027/tmp/512MB_file\u0027"},{"line_number":93,"context_line":"        with self._filecontext(gf_file_path):"},{"line_number":94,"context_line":"            MBFile \u003d open(\u0027/tmp/512MB_file\u0027, \u0027w\u0027)"},{"line_number":95,"context_line":"            for _ in range(128):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_36d3a361","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":40},"updated":"2017-01-24 07:02:26.000000000","message":"I don\u0027t think you should merge this, but please have a look about my refactoring about temp file management [1]\n\n[1] https://review.openstack.org/#/c/420419/","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"0413ffbf3e1eb0d8e3108856f5fd6af9c17e6b68","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @attr(\u0027slow\u0027)"},{"line_number":91,"context_line":"    def test_put_512MB_file(self):"},{"line_number":92,"context_line":"        gf_file_path \u003d \u0027/tmp/512MB_file\u0027"},{"line_number":93,"context_line":"        with self._filecontext(gf_file_path):"},{"line_number":94,"context_line":"            MBFile \u003d open(\u0027/tmp/512MB_file\u0027, \u0027w\u0027)"},{"line_number":95,"context_line":"            for _ in range(128):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_42c9f877","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":40},"in_reply_to":"5a3905b3_36d3a361","updated":"2017-01-26 10:22:21.000000000","message":"we use modified \"test_put_1GB_file\" as a reference.","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31e6722d70762569d2a109d2999a98e5e0e6606f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.assertEqual(201, conn.getcode())"},{"line_number":158,"context_line":"        headers \u003d client.head_object(self.url, self.token,"},{"line_number":159,"context_line":"                                     \u0027myobjects\u0027, objname)"},{"line_number":160,"context_line":"        self.assertEqual(headers[\u0027content-length\u0027], str(len(self.content)))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        resp \u003d dict()"},{"line_number":163,"context_line":"        client.delete_object("}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_36ec8329","line":160,"range":{"start_line":160,"start_character":52,"end_line":160,"end_character":74},"updated":"2017-01-24 07:02:26.000000000","message":"(nit) This should be placed in left, as this is reference","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"0413ffbf3e1eb0d8e3108856f5fd6af9c17e6b68","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.assertEqual(201, conn.getcode())"},{"line_number":158,"context_line":"        headers \u003d client.head_object(self.url, self.token,"},{"line_number":159,"context_line":"                                     \u0027myobjects\u0027, objname)"},{"line_number":160,"context_line":"        self.assertEqual(headers[\u0027content-length\u0027], str(len(self.content)))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        resp \u003d dict()"},{"line_number":163,"context_line":"        client.delete_object("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_82a120ac","line":160,"range":{"start_line":160,"start_character":52,"end_line":160,"end_character":74},"in_reply_to":"5a3905b3_36ec8329","updated":"2017-01-26 10:22:21.000000000","message":"Done","commit_id":"5b74444a5c4c9da503081bba84c5465147fa7165"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                  headers, None, None, None, response)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            status \u003d response.get(\u0027status\u0027)"},{"line_number":100,"context_line":"            self.assertIn(status, [200, 201])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_copy_from(self):"},{"line_number":103,"context_line":"        resp \u003d dict()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_18582d32","line":100,"range":{"start_line":100,"start_character":35,"end_line":100,"end_character":38},"updated":"2017-01-26 16:48:27.000000000","message":"200 is never returned in PUT requests","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        self.assertEqual(201, resp[\u0027status\u0027])"},{"line_number":112,"context_line":"        resp_header \u003d resp[\u0027headers\u0027]"},{"line_number":113,"context_line":"        self.assertEqual(resp_header[\u0027x-storlet-generated-from\u0027],"},{"line_number":114,"context_line":"                         \u0027myobjects/%s\u0027 % self.storlet_file)"},{"line_number":115,"context_line":"        self.assertEqual(resp_header[\u0027x-storlet-generated-from-account\u0027],"},{"line_number":116,"context_line":"                         self.acct)"},{"line_number":117,"context_line":"        self.assertIn(\u0027x-storlet-generated-from-last-modified\u0027, resp_header)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        headers \u003d client.head_object(self.url, self.token,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_d8822552","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":35},"updated":"2017-01-26 16:48:27.000000000","message":"I don\u0027t think this is so critical, but placing reference value first is better (I mean, assertEqual(reference, real_value) is better thant assertEqual(real_value, reference))","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"cfcb41742f44aa24425ab9e84bfe294103d62646","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        self.assertEqual(201, resp[\u0027status\u0027])"},{"line_number":112,"context_line":"        resp_header \u003d resp[\u0027headers\u0027]"},{"line_number":113,"context_line":"        self.assertEqual(resp_header[\u0027x-storlet-generated-from\u0027],"},{"line_number":114,"context_line":"                         \u0027myobjects/%s\u0027 % self.storlet_file)"},{"line_number":115,"context_line":"        self.assertEqual(resp_header[\u0027x-storlet-generated-from-account\u0027],"},{"line_number":116,"context_line":"                         self.acct)"},{"line_number":117,"context_line":"        self.assertIn(\u0027x-storlet-generated-from-last-modified\u0027, resp_header)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        headers \u003d client.head_object(self.url, self.token,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_a965b8b5","line":116,"range":{"start_line":113,"start_character":0,"end_line":116,"end_character":35},"in_reply_to":"3a461143_d8822552","updated":"2017-01-30 06:16:20.000000000","message":"Done","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        resp \u003d dict()"},{"line_number":130,"context_line":"        client.delete_object("},{"line_number":131,"context_line":"            self.url, self.token, self.container, self.storlet_file,"},{"line_number":132,"context_line":"            response_dict\u003dresp)"},{"line_number":133,"context_line":"        self.assertEqual(204, resp[\u0027status\u0027])"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_b868f988","line":131,"range":{"start_line":131,"start_character":50,"end_line":131,"end_character":67},"updated":"2017-01-26 16:48:27.000000000","message":"When is this object put? I can\u0027t find that putting in this test case, and I don\u0027t think we should not \u0027clean up\u0027 something not created in this test case.","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"cfcb41742f44aa24425ab9e84bfe294103d62646","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        resp \u003d dict()"},{"line_number":130,"context_line":"        client.delete_object("},{"line_number":131,"context_line":"            self.url, self.token, self.container, self.storlet_file,"},{"line_number":132,"context_line":"            response_dict\u003dresp)"},{"line_number":133,"context_line":"        self.assertEqual(204, resp[\u0027status\u0027])"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_c95684cd","line":131,"range":{"start_line":131,"start_character":50,"end_line":131,"end_character":67},"in_reply_to":"3a461143_b868f988","updated":"2017-01-30 06:16:20.000000000","message":"Done","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398a0f275b407e3d11e4c44529f0722c918c1da1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            response_dict\u003dresp)"},{"line_number":156,"context_line":"        self.assertEqual(204, resp[\u0027status\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        resp \u003d dict()"},{"line_number":159,"context_line":"        client.delete_object("},{"line_number":160,"context_line":"            self.url, self.token, self.container, self.storlet_file,"},{"line_number":161,"context_line":"            response_dict\u003dresp)"},{"line_number":162,"context_line":"        self.assertEqual(204, resp[\u0027status\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TestSimpleStorletOnProxy(TestSimpleStorlet):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_98041dc1","line":162,"range":{"start_line":158,"start_character":0,"end_line":162,"end_character":45},"updated":"2017-01-26 16:48:27.000000000","message":"ditto","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"cfcb41742f44aa24425ab9e84bfe294103d62646","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            response_dict\u003dresp)"},{"line_number":156,"context_line":"        self.assertEqual(204, resp[\u0027status\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        resp \u003d dict()"},{"line_number":159,"context_line":"        client.delete_object("},{"line_number":160,"context_line":"            self.url, self.token, self.container, self.storlet_file,"},{"line_number":161,"context_line":"            response_dict\u003dresp)"},{"line_number":162,"context_line":"        self.assertEqual(204, resp[\u0027status\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TestSimpleStorletOnProxy(TestSimpleStorlet):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a461143_e95b40f4","line":162,"range":{"start_line":158,"start_character":0,"end_line":162,"end_character":45},"in_reply_to":"3a461143_98041dc1","updated":"2017-01-30 06:16:20.000000000","message":"Done","commit_id":"90ccabc800d69236402063dd8f78cf0a60cc4866"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"7601f6af656fec53d851efb934a521df81de7ae4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def test_copy_dest(self):"},{"line_number":130,"context_line":"        # No COPY in swiftclient. Using urllib instead..."},{"line_number":131,"context_line":"        url \u003d os.path.join(self.url, \u0027myobjects\u0027, self.storlet_file)"},{"line_number":132,"context_line":"        objname \u003d self.storlet_file + \u0027-copy\u0027"},{"line_number":133,"context_line":"        headers \u003d {\u0027X-Auth-Token\u0027: self.token,"},{"line_number":134,"context_line":"                   \u0027X-Run-Storlet\u0027: self.storlet_name,"},{"line_number":135,"context_line":"                   \u0027Destination\u0027: \u0027myobjects/%s\u0027 % objname}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a461143_865382e1","line":132,"updated":"2017-01-30 10:34:39.000000000","message":"I wonder if we want to have the object name as -copy-ex and also add the assertions appearing in lines 113-117.\nWhile these may be missing in the original test its my fault :-) and I guess we better have them","commit_id":"411bb312984f7bc5b002acb339eb9d83aaddee3b"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"9736c32a50762ac6d7b3b905b1a8eb2f4054122b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def test_copy_dest(self):"},{"line_number":130,"context_line":"        # No COPY in swiftclient. Using urllib instead..."},{"line_number":131,"context_line":"        url \u003d os.path.join(self.url, \u0027myobjects\u0027, self.storlet_file)"},{"line_number":132,"context_line":"        objname \u003d self.storlet_file + \u0027-copy\u0027"},{"line_number":133,"context_line":"        headers \u003d {\u0027X-Auth-Token\u0027: self.token,"},{"line_number":134,"context_line":"                   \u0027X-Run-Storlet\u0027: self.storlet_name,"},{"line_number":135,"context_line":"                   \u0027Destination\u0027: \u0027myobjects/%s\u0027 % objname}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a461143_8fec4e2b","line":132,"in_reply_to":"3a461143_865382e1","updated":"2017-01-31 10:36:41.000000000","message":"Thank you for your comment!\nI added the assertions.\n\nI will modify java\u0027s test code in another commit.","commit_id":"411bb312984f7bc5b002acb339eb9d83aaddee3b"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"b7af487ffac6c469953a147f94ee1d0c3f412405","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def test_copy_dest(self):"},{"line_number":130,"context_line":"        # No COPY in swiftclient. Using urllib instead..."},{"line_number":131,"context_line":"        url \u003d os.path.join(self.url, \u0027myobjects\u0027, self.storlet_file)"},{"line_number":132,"context_line":"        objname \u003d self.storlet_file + \u0027-copy\u0027"},{"line_number":133,"context_line":"        headers \u003d {\u0027X-Auth-Token\u0027: self.token,"},{"line_number":134,"context_line":"                   \u0027X-Run-Storlet\u0027: self.storlet_name,"},{"line_number":135,"context_line":"                   \u0027Destination\u0027: \u0027myobjects/%s\u0027 % objname}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a461143_decc4abd","line":132,"in_reply_to":"3a461143_865382e1","updated":"2017-01-31 09:10:11.000000000","message":"Thank you for your comment!\nWe added the assertions.\n\nWe will fix java\u0027s test in another commit.","commit_id":"411bb312984f7bc5b002acb339eb9d83aaddee3b"}]}
