)]}'
{"tests/functional/python/test_multiinput_storlet.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"39fa4b0f89c20811a258037a13f4575a1515590c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027X-Run-Storlet\u0027: self.storlet_name,"},{"line_number":45,"context_line":"            \u0027X-Storlet-Extra-Resources\u0027:"},{"line_number":46,"context_line":"            os.path.join(\u0027/\u0027 + self.container, obj2),"},{"line_number":47,"context_line":"            \u0027X-Storlet-Run-On-Proxy\u0027: \u0027\u0027"},{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        resp_headers, resp_content \u003d c.get_object("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_6f8df430","line":47,"updated":"2017-01-03 09:38:33.000000000","message":"I think the middleware needs to be smart enough to run this on the proxy when it sees the X-Storlet-Extra-Resources header (looking at the code, I strongly believe this is the case).\nI realise that this is also what is done in the Java test, but we should:\n1. Remove the X-Storlet-Run-On-Proxy headers here\n2. Run the on proxy conventional test by adding:\nWhile this will do exactly what is done in the base class (run on proxy, I believe this is good for backward compatibility, specifically, given the fact that we may want to enable this one day on object nodes)\nclass TestMultiInputStorletOnProxy(TestMultiInputStorlet):\n    def setUp(self):\n        super(TestMultiInputStorletOnProxy, self).setUp()\n        self.additional_headers \u003d {\u0027X-Storlet-Run-On-Proxy\u0027: \u0027\u0027}","commit_id":"3fa5e55f1b313909e2f14ce882dedb67ef0c2efa"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"b33af3df93251a60082de3b41db5ed7c936de56c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027X-Run-Storlet\u0027: self.storlet_name,"},{"line_number":45,"context_line":"            \u0027X-Storlet-Extra-Resources\u0027:"},{"line_number":46,"context_line":"            os.path.join(\u0027/\u0027 + self.container, obj2),"},{"line_number":47,"context_line":"            \u0027X-Storlet-Run-On-Proxy\u0027: \u0027\u0027"},{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        resp_headers, resp_content \u003d c.get_object("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_5882c6c9","line":47,"in_reply_to":"ba5201f7_6f8df430","updated":"2017-01-10 07:37:31.000000000","message":"Thank you for your comment.\nI fix it.\nAnd I also add \u0027header.update(self.additional_headers)\u0027.","commit_id":"3fa5e55f1b313909e2f14ce882dedb67ef0c2efa"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"83f7e6b67d310ca0c38b4cb759762d44c28e2abe","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(TestMultiInputStorletOnProxy, self).setUp()"},{"line_number":38,"context_line":"        self.additional_headers \u003d {\u0027X-Storlet-Run-On-Proxy\u0027: \u0027\u0027}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_get_extra_sources(self):"},{"line_number":41,"context_line":"        obj \u003d \u0027small\u0027"},{"line_number":42,"context_line":"        obj2 \u003d \u0027small2\u0027"},{"line_number":43,"context_line":"        c.put_object(self.url, self.token,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_f18369ca","line":40,"updated":"2017-01-16 07:26:15.000000000","message":"Please consider moving this test function and the next to the parent class (TestMultiInputStorlet). This way we will run the test twice:\n1. With the X-Storlet-Run-On-Proxy\n2. without X-Storlet-Run-On-Proxy\nIt is true that currently in both cases the storlet invocation would happen on the proxy, but this is part of what we want to test here....","commit_id":"de141db4394d3a46d15c335183c024d98e7a688e"},{"author":{"_account_id":17901,"name":"Akihito Takai","email":"takaiak@nttdata.co.jp","username":"AkihitoTakai"},"change_message_id":"ee161707660125b01747820b62da1902e27be335","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(TestMultiInputStorletOnProxy, self).setUp()"},{"line_number":38,"context_line":"        self.additional_headers \u003d {\u0027X-Storlet-Run-On-Proxy\u0027: \u0027\u0027}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_get_extra_sources(self):"},{"line_number":41,"context_line":"        obj \u003d \u0027small\u0027"},{"line_number":42,"context_line":"        obj2 \u003d \u0027small2\u0027"},{"line_number":43,"context_line":"        c.put_object(self.url, self.token,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_2f6908bf","line":40,"in_reply_to":"7a3c09a3_f18369ca","updated":"2017-01-16 08:10:13.000000000","message":"sorry...\nI understood your comments!\nI fix it!","commit_id":"de141db4394d3a46d15c335183c024d98e7a688e"}]}