)]}'
{".functests":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"769655b0484ed5b192764c4f423f476ead64ee41","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SRC_DIR\u003d$(python -c \"import os; print os.path.dirname(os.path.realpath(\u0027$0\u0027))\")"},{"line_number":20,"context_line":"if [ \"$FLAVOR\" \u003d\u003d \"jenkins\" ]; then"},{"line_number":21,"context_line":"    nosetests --exe -v $@ ${SRC_DIR}/tests/functional"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    nosetests --exe -v -a \u0027!slow\u0027 $@ ${SRC_DIR}/tests/functional"},{"line_number":24,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a30ddce_c2bed5fe","line":21,"updated":"2017-03-07 10:49:53.000000000","message":"I think this should be:\nnosetests --exe -v ${SRC_DIR}/tests/functional/$@\n\nOtherwise, if we e.g. run, ./.functests java/test_test_storlet.py we will run both the specified storlet as well as the whole suit...","commit_id":"b46a481abe825ef4da91b377d587a01eb1c2cef0"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e29c0cf0cd89292d23708affb48a9e969d99bc6b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SRC_DIR\u003d$(python -c \"import os; print os.path.dirname(os.path.realpath(\u0027$0\u0027))\")"},{"line_number":20,"context_line":"if [ \"$FLAVOR\" \u003d\u003d \"jenkins\" ]; then"},{"line_number":21,"context_line":"    nosetests --exe -v $@ ${SRC_DIR}/tests/functional"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    nosetests --exe -v -a \u0027!slow\u0027 $@ ${SRC_DIR}/tests/functional"},{"line_number":24,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a30ddce_7eabd5d6","line":21,"in_reply_to":"9a30ddce_c2bed5fe","updated":"2017-03-08 02:38:45.000000000","message":"Thanks, it\u0027s good catch.\n\nThinking of that we should address whole values in the $@ and I don\u0027t want to make it as a blocker for this, so simply I\u0027ll revert the change around here.","commit_id":"b46a481abe825ef4da91b377d587a01eb1c2cef0"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"769655b0484ed5b192764c4f423f476ead64ee41","unresolved":false,"context_lines":[{"line_number":20,"context_line":"if [ \"$FLAVOR\" \u003d\u003d \"jenkins\" ]; then"},{"line_number":21,"context_line":"    nosetests --exe -v $@ ${SRC_DIR}/tests/functional"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    nosetests --exe -v -a \u0027!slow\u0027 $@ ${SRC_DIR}/tests/functional"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":"rvalue\u003d$?"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a30ddce_a248012f","line":23,"updated":"2017-03-07 10:49:53.000000000","message":"ditto","commit_id":"b46a481abe825ef4da91b377d587a01eb1c2cef0"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e29c0cf0cd89292d23708affb48a9e969d99bc6b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"if [ \"$FLAVOR\" \u003d\u003d \"jenkins\" ]; then"},{"line_number":21,"context_line":"    nosetests --exe -v $@ ${SRC_DIR}/tests/functional"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    nosetests --exe -v -a \u0027!slow\u0027 $@ ${SRC_DIR}/tests/functional"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":"rvalue\u003d$?"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a30ddce_9eba4922","line":23,"in_reply_to":"9a30ddce_a248012f","updated":"2017-03-08 02:38:45.000000000","message":"ditto.","commit_id":"b46a481abe825ef4da91b377d587a01eb1c2cef0"}],"tests/functional/__init__.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"eb6baaec6ec0b47c0f43ac8770b58034540dea73","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from storlets.tools.utils import deploy_storlet, get_admin_auth, put_local_file"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONFIG_DIR \u003d os.environ.get(\u0027CLUSTER_CONF_DIR\u0027, os.getcwd())"},{"line_number":26,"context_line":"CONFIG_FILE \u003d os.path.join(CONFIG_DIR, \u0027cluster_config.json\u0027)"},{"line_number":27,"context_line":"PATH_TO_STORLETS \u003d os.environ.get("},{"line_number":28,"context_line":"    \u0027STORLET_SAMPLE_PATH\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_f3e71e3e","line":25,"updated":"2017-03-01 07:55:20.000000000","message":"I think this should be:\nCONFIG_DIR \u003d os.environ.get(\u0027CLUSTER_CONF_DIR\u0027,\nos.path.join(os.getcwd(),\u0027..\u0027,\u0027..\u0027)","commit_id":"534d2bf021124578269d5c91186d698208d7400e"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"aea264095f04b494e2bf1c79f2d27afeb76cf34a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from storlets.tools.utils import deploy_storlet, get_admin_auth, put_local_file"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONFIG_DIR \u003d os.environ.get(\u0027CLUSTER_CONF_DIR\u0027, os.getcwd())"},{"line_number":26,"context_line":"CONFIG_FILE \u003d os.path.join(CONFIG_DIR, \u0027cluster_config.json\u0027)"},{"line_number":27,"context_line":"PATH_TO_STORLETS \u003d os.environ.get("},{"line_number":28,"context_line":"    \u0027STORLET_SAMPLE_PATH\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_19f0e5c8","line":25,"in_reply_to":"ba2be162_f3e71e3e","updated":"2017-03-03 00:34:11.000000000","message":"oh, oh, my mistake is in .functests because I\u0027d like to change the design to work at {toxinidir}","commit_id":"534d2bf021124578269d5c91186d698208d7400e"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"eb6baaec6ec0b47c0f43ac8770b58034540dea73","unresolved":false,"context_lines":[{"line_number":27,"context_line":"PATH_TO_STORLETS \u003d os.environ.get("},{"line_number":28,"context_line":"    \u0027STORLET_SAMPLE_PATH\u0027,"},{"line_number":29,"context_line":"    # assuming, current working dir is at top of storlet repo"},{"line_number":30,"context_line":"    os.path.join(os.getcwd(), \u0027StorletSamples\u0027))"},{"line_number":31,"context_line":"CONSOLE_TIMEOUT \u003d 2"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_b3c4c692","line":30,"updated":"2017-03-01 07:55:20.000000000","message":"and this one:\nPATH_TO_STORLETS \u003d os.environ.get(\n    \u0027STORLET_SAMPLE_PATH\u0027,\n    os.path.join(CONFIG_DIR,\u0027StorletSamples\u0027)","commit_id":"534d2bf021124578269d5c91186d698208d7400e"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"aea264095f04b494e2bf1c79f2d27afeb76cf34a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"PATH_TO_STORLETS \u003d os.environ.get("},{"line_number":28,"context_line":"    \u0027STORLET_SAMPLE_PATH\u0027,"},{"line_number":29,"context_line":"    # assuming, current working dir is at top of storlet repo"},{"line_number":30,"context_line":"    os.path.join(os.getcwd(), \u0027StorletSamples\u0027))"},{"line_number":31,"context_line":"CONSOLE_TIMEOUT \u003d 2"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_99ae957f","line":30,"in_reply_to":"ba2be162_b3c4c692","updated":"2017-03-03 00:34:11.000000000","message":"I don\u0027t think so that is because I like CONFIG_FILE and Storlets Samples will be separated.\n\ne.g. storlet samples are in /home/ubuntu/storlets/StorletSamples but cluster config is in /etc/swift/cluster_config.json.\n\nThis case, expoert CONFIG_DIR\u003d/etc/swift/cluster_config.json and then, run `.functests` at the /home/ubuntu/storlets (top of storlets repository) that should still work?","commit_id":"534d2bf021124578269d5c91186d698208d7400e"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"eb6baaec6ec0b47c0f43ac8770b58034540dea73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba2be162_d31dba10","line":90,"updated":"2017-03-01 07:55:20.000000000","message":"I think that as we have a different container per test, it will be beneficial to add a tearDown method that deletes all the content of the uuid container.","commit_id":"534d2bf021124578269d5c91186d698208d7400e"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"aea264095f04b494e2bf1c79f2d27afeb76cf34a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba2be162_59c97d25","line":90,"in_reply_to":"ba2be162_d31dba10","updated":"2017-03-03 00:34:11.000000000","message":"+1, will do!","commit_id":"534d2bf021124578269d5c91186d698208d7400e"}],"tests/functional/java/test_compress_storlet.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"eb6baaec6ec0b47c0f43ac8770b58034540dea73","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        headers.update(self.additional_headers)"},{"line_number":35,"context_line":"        querystring \u003d \"action\u003dcompress\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # simply set 1KB string data to compress"},{"line_number":38,"context_line":"        data \u003d \u0027A\u0027 * 1024"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        response \u003d dict()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_73ddee41","line":37,"updated":"2017-03-01 07:55:20.000000000","message":"nice cleanup","commit_id":"534d2bf021124578269d5c91186d698208d7400e"}],"tests/functional/java/test_deploy_storlet.py":[{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"eb6baaec6ec0b47c0f43ac8770b58034540dea73","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestDeployStorlet(StorletBaseFunctionalTest):"},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestDeployStorlet, self).setUp()"},{"line_number":29,"context_line":"        self.deploy_storlet_path \u003d os.path.abspath(deploy_storlet.__file__)"},{"line_number":30,"context_line":"        self.execdep_storlet_path \u003d os.path.join(PATH_TO_STORLETS,"},{"line_number":31,"context_line":"                                                 \u0027java\u0027,"},{"line_number":32,"context_line":"                                                 \u0027ExecDepStorlet\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_d3e4da0e","line":29,"updated":"2017-03-01 07:55:20.000000000","message":"nice","commit_id":"534d2bf021124578269d5c91186d698208d7400e"}]}