)]}'
{"storlets/gateway/gateways/docker/runtime.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"836b8a7b354052655f8f9d1ee5e8533ef3384c0c","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as writer:"},{"line_number":836,"context_line":"                yield writer"},{"line_number":837,"context_line":"        except (OSError, TypeError, ValueError):"},{"line_number":838,"context_line":"            exc_type, exc_value, exc_traceback \u003d sys.exc_info()"},{"line_number":839,"context_line":"            six.reraise(exc_type, exc_value, exc_traceback)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def _write_input_data(self, fd, data_iter):"},{"line_number":842,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_7b7971fa","line":839,"range":{"start_line":838,"start_character":12,"end_line":839,"end_character":59},"updated":"2017-04-03 11:11:18.000000000","message":"This reraising looks redundant to me, as we don\u0027t try to close the fd here.","commit_id":"612709aa1c4d66f3feb99ecefdfde567687c3795"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"dccf296bf320e6d54e148db9e3d0f7191ffb6cab","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as writer:"},{"line_number":836,"context_line":"                yield writer"},{"line_number":837,"context_line":"        except (OSError, TypeError, ValueError):"},{"line_number":838,"context_line":"            exc_type, exc_value, exc_traceback \u003d sys.exc_info()"},{"line_number":839,"context_line":"            six.reraise(exc_type, exc_value, exc_traceback)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def _write_input_data(self, fd, data_iter):"},{"line_number":842,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_0c668d52","line":839,"range":{"start_line":838,"start_character":12,"end_line":839,"end_character":59},"in_reply_to":"dfeb2761_7b7971fa","updated":"2017-04-04 04:39:52.000000000","message":"Done","commit_id":"612709aa1c4d66f3feb99ecefdfde567687c3795"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fbb2c41865bf9adbee69c79e6de4db26b94da4aa","unresolved":false,"context_lines":[{"line_number":830,"context_line":"            raise"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    @contextmanager"},{"line_number":833,"context_line":"    def _open_writer(self, fd):"},{"line_number":834,"context_line":"        with os.fdopen(fd, \u0027w\u0027) as writer:"},{"line_number":835,"context_line":"            yield writer"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_d8ddff42","line":833,"range":{"start_line":833,"start_character":8,"end_line":833,"end_character":31},"updated":"2017-04-04 08:01:09.000000000","message":"I don\u0027t think this is a blocker, (and ok to land this patch as Eran already put his +2+A), but currently I have some doubt about keeping this method, as it only does very very trivial thing.","commit_id":"51ce5d9d1a6596712936fc08931674b05517490d"}],"tests/unit/gateway/gateways/docker/test_runtime.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"836b8a7b354052655f8f9d1ee5e8533ef3384c0c","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                    pass"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def _test_writer_with_exception(self, exception_cls):"},{"line_number":462,"context_line":"        pipes \u003d [os.pipe()]"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        def raise_in_the_context():"},{"line_number":465,"context_line":"            with self.protocol._open_writer(pipes[0][1]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_5bf34d74","line":462,"range":{"start_line":462,"start_character":8,"end_line":462,"end_character":27},"updated":"2017-04-03 11:11:18.000000000","message":"I\u0027m not sure this can be so critical issue, but I\u0027m afraid that some of the fd created here can be leaked in some cases.\n(ex. when we get error in assertRaises in L469)","commit_id":"612709aa1c4d66f3feb99ecefdfde567687c3795"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"dccf296bf320e6d54e148db9e3d0f7191ffb6cab","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                    pass"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def _test_writer_with_exception(self, exception_cls):"},{"line_number":462,"context_line":"        pipes \u003d [os.pipe()]"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        def raise_in_the_context():"},{"line_number":465,"context_line":"            with self.protocol._open_writer(pipes[0][1]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_2c639144","line":462,"range":{"start_line":462,"start_character":8,"end_line":462,"end_character":27},"in_reply_to":"dfeb2761_5bf34d74","updated":"2017-04-04 04:39:52.000000000","message":"Done\n\ntry/finally added to close both read/write fds.","commit_id":"612709aa1c4d66f3feb99ecefdfde567687c3795"}]}