)]}'
{"storlets/gateway/gateways/docker/gateway.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1ed745bf8f21b766560567b712252bf02b4db500","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            # This will change when we will head dependencies as well"},{"line_number":289,"context_line":"            fstat \u003d os.stat(cache_target_path)"},{"line_number":290,"context_line":"            storlet_or_size \u003d int("},{"line_number":291,"context_line":"                sreq.options[\u0027storlet_content_length\u0027].rstrip(\"L\"))"},{"line_number":292,"context_line":"            storlet_or_time \u003d float(sreq.options[\u0027storlet_x_timestamp\u0027])"},{"line_number":293,"context_line":"            b_storlet_size_changed \u003d fstat.st_size !\u003d storlet_or_size"},{"line_number":294,"context_line":"            b_storlet_file_updated \u003d float(fstat.st_mtime) \u003c storlet_or_time"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7aad2a81","line":291,"updated":"2018-10-29 10:40:20.000000000","message":"Perhaps, we need\n\n if isinstance(str, sreq.options[\u0027storlet_content_length\u0027])\n\nblock? Otherwise, rstrip could causes an error. Anyway, I should look at the sreq.options format.","commit_id":"ab31ba4806a775b9c7331f5ef2c66a0880d93d77"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"7a8b91589e4bf1a397ae5db325000c3a7b26a54f","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            # This will change when we will head dependencies as well"},{"line_number":289,"context_line":"            fstat \u003d os.stat(cache_target_path)"},{"line_number":290,"context_line":"            storlet_or_size \u003d int("},{"line_number":291,"context_line":"                sreq.options[\u0027storlet_content_length\u0027].rstrip(\"L\"))"},{"line_number":292,"context_line":"            storlet_or_time \u003d float(sreq.options[\u0027storlet_x_timestamp\u0027])"},{"line_number":293,"context_line":"            b_storlet_size_changed \u003d fstat.st_size !\u003d storlet_or_size"},{"line_number":294,"context_line":"            b_storlet_file_updated \u003d float(fstat.st_mtime) \u003c storlet_or_time"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3f36b202","line":291,"in_reply_to":"3f79a3b5_6901dcb4","updated":"2018-10-30 05:23:05.000000000","message":"Make sense, that means we can land this as it is. Thanks for clarification.","commit_id":"ab31ba4806a775b9c7331f5ef2c66a0880d93d77"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e2b7fbfa43fb727f3454444876cd8ca58dbe004e","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            # This will change when we will head dependencies as well"},{"line_number":289,"context_line":"            fstat \u003d os.stat(cache_target_path)"},{"line_number":290,"context_line":"            storlet_or_size \u003d int("},{"line_number":291,"context_line":"                sreq.options[\u0027storlet_content_length\u0027].rstrip(\"L\"))"},{"line_number":292,"context_line":"            storlet_or_time \u003d float(sreq.options[\u0027storlet_x_timestamp\u0027])"},{"line_number":293,"context_line":"            b_storlet_size_changed \u003d fstat.st_size !\u003d storlet_or_size"},{"line_number":294,"context_line":"            b_storlet_file_updated \u003d float(fstat.st_mtime) \u003c storlet_or_time"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6901dcb4","line":291,"in_reply_to":"3f79a3b5_7aad2a81","updated":"2018-10-30 01:26:01.000000000","message":"This \u0027options\u0027 is created in _get_storlet_invocation_options[1]\n\n[1] https://github.com/openstack/storlets/blob/master/storlets/swift_middleware/handlers/base.py#L460-L463\n\nIt comes from headers of swift.request.Request.\nIn my understanding \u0027headers\u0027 has strings as its key/value, so IMO we can assume that we get string here.","commit_id":"ab31ba4806a775b9c7331f5ef2c66a0880d93d77"}]}