)]}'
{"storlets/agent/daemon_factory/server.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a3494b4eb32015b33282a9860091e627078605e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from storlets.agent.common.server import command_handler, CommandSuccess, \\"},{"line_number":28,"context_line":"    CommandFailure, SBusServer"},{"line_number":29,"context_line":"from storlets.agent.common.utils import get_logger"},{"line_number":30,"context_line":"# from storlets.gateway.common.stob import DEFAULT_PY2, DEFAULT_PY3"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SDaemonError(Exception):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_0527dd14","line":30,"updated":"2019-03-06 06:07:37.000000000","message":"We can cleanup this.","commit_id":"7654cb0df172503aa250baaaa9705b5c1217ed3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a3494b4eb32015b33282a9860091e627078605e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def get_python_args(self, daemon_language, storlet_path, storlet_name,"},{"line_number":104,"context_line":"                        pool_size, uds_path, log_level, language_version):"},{"line_number":105,"context_line":"        language_version \u003d language_version or 2"},{"line_number":106,"context_line":"        if int(float(language_version)) \u003d\u003d 3:"},{"line_number":107,"context_line":"            language_version \u003d 3.5"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            language_version \u003d 2.7"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_056cbd34","line":106,"updated":"2019-03-06 06:07:37.000000000","message":"For example when language version 3.3 is passed, this let storlets to ignore microversion and run app with 3.5.\nI think it is better to return error if the specified version is not available.\n\nAlso, could we catch value error here and raise SDaemonError instead?","commit_id":"7654cb0df172503aa250baaaa9705b5c1217ed3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a3494b4eb32015b33282a9860091e627078605e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                    params[\u0027daemon_language\u0027], params[\u0027storlet_path\u0027],"},{"line_number":452,"context_line":"                    storlet_name, params[\u0027pool_size\u0027],"},{"line_number":453,"context_line":"                    params[\u0027uds_path\u0027], params[\u0027log_level\u0027],"},{"line_number":454,"context_line":"                    language_version\u003dparams.get(\"language_version\")):"},{"line_number":455,"context_line":"                msg \u003d \u0027OK\u0027"},{"line_number":456,"context_line":"            else:"},{"line_number":457,"context_line":"                msg \u003d \u0027{0} is already running\u0027.format(storlet_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_450de58e","line":454,"updated":"2019-03-06 06:07:37.000000000","message":"Does it make sense to rename this to \"deamon_language_version\" as we have daemon_ for language parameter?","commit_id":"7654cb0df172503aa250baaaa9705b5c1217ed3e"}]}