)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"35b15cf5f5cce0b8d1236eba304788668d32fa1f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid broken http header including white space"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The execution result header in user metadata looks invalid"},{"line_number":10,"context_line":"and it cuases the hang in the func CI tessting."},{"line_number":11,"context_line":"So let\u0027s remove the dangerous white space in the http"},{"line_number":12,"context_line":"header key with this patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib41735d8801f0c99ed0563213dcf414fefb5cbb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_b0a7d109","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":27},"updated":"2019-11-14 10:53:20.000000000","message":"It can be useful to speak about the test skipping too.","commit_id":"4b22322f57657f14d36182b70a5ffc942e3d144a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"dd09bb52980b695efb0379983520174037d6be84","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid broken http header including white space"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The execution result header in user metadata looks invalid"},{"line_number":10,"context_line":"and it cuases the hang in the func CI tessting."},{"line_number":11,"context_line":"So let\u0027s remove the dangerous white space in the http"},{"line_number":12,"context_line":"header key with this patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib41735d8801f0c99ed0563213dcf414fefb5cbb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_1f058614","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":27},"in_reply_to":"3fa7e38b_a925245e","updated":"2019-11-15 07:44:16.000000000","message":"Done","commit_id":"4b22322f57657f14d36182b70a5ffc942e3d144a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c9ba61362199a031aab1667357a93c4fc33a6454","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid broken http header including white space"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The execution result header in user metadata looks invalid"},{"line_number":10,"context_line":"and it cuases the hang in the func CI tessting."},{"line_number":11,"context_line":"So let\u0027s remove the dangerous white space in the http"},{"line_number":12,"context_line":"header key with this patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib41735d8801f0c99ed0563213dcf414fefb5cbb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_a925245e","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":27},"in_reply_to":"3fa7e38b_b0a7d109","updated":"2019-11-15 01:03:12.000000000","message":"+1","commit_id":"4b22322f57657f14d36182b70a5ffc942e3d144a"}],"tests/functional/java/test_identity_storlet.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"35b15cf5f5cce0b8d1236eba304788668d32fa1f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_put(self):"},{"line_number":154,"context_line":"        self.invoke_storlet(\u0027PUT\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @unittest.skipIf(six.PY3, \u0027execute can hang on py3 for some reason\u0027)"},{"line_number":157,"context_line":"    def test_put_execute(self):"},{"line_number":158,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027})"},{"line_number":159,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b0903198","side":"PARENT","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":70},"updated":"2019-11-14 10:53:20.000000000","message":"Do we need to understand that this test doesn\u0027t hanging anymore?\n\nI mean if this test is stuck with py3 and due to the fact that py2 is EOL maybe we just need to remove this test.\n\nThoughts?","commit_id":"b0c939fe249ce993d1a5bf4e402b5d324a9da586"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"dd09bb52980b695efb0379983520174037d6be84","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_put(self):"},{"line_number":154,"context_line":"        self.invoke_storlet(\u0027PUT\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @unittest.skipIf(six.PY3, \u0027execute can hang on py3 for some reason\u0027)"},{"line_number":157,"context_line":"    def test_put_execute(self):"},{"line_number":158,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027})"},{"line_number":159,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9f117660","side":"PARENT","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":70},"in_reply_to":"3fa7e38b_4914b0e9","updated":"2019-11-15 07:44:16.000000000","message":"\u003e Herve\n\nNo, this test is needed because this functional test checks the existing feature for running Storlet app written in Java so this test is NOT only for py2. The skip code has appreared in https://review.opendev.org/#/c/693549 that was so recent work during py3 migration. That means the skip test was just temporary work to check if we would have other failures w/o this test so we should fix instead of just removing.","commit_id":"b0c939fe249ce993d1a5bf4e402b5d324a9da586"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f6ca0574ee5576082f01cac6ca98f9abb8b82c9d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_put(self):"},{"line_number":154,"context_line":"        self.invoke_storlet(\u0027PUT\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @unittest.skipIf(six.PY3, \u0027execute can hang on py3 for some reason\u0027)"},{"line_number":157,"context_line":"    def test_put_execute(self):"},{"line_number":158,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027})"},{"line_number":159,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c2287534","side":"PARENT","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":70},"in_reply_to":"3fa7e38b_9f117660","updated":"2019-11-15 08:26:44.000000000","message":"Ok thanks guys for your explanations.","commit_id":"b0c939fe249ce993d1a5bf4e402b5d324a9da586"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c9ba61362199a031aab1667357a93c4fc33a6454","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_put(self):"},{"line_number":154,"context_line":"        self.invoke_storlet(\u0027PUT\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @unittest.skipIf(six.PY3, \u0027execute can hang on py3 for some reason\u0027)"},{"line_number":157,"context_line":"    def test_put_execute(self):"},{"line_number":158,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027})"},{"line_number":159,"context_line":"        self.invoke_storlet(\u0027PUT\u0027, {\u0027execute\u0027: \u0027true\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4914b0e9","side":"PARENT","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":70},"in_reply_to":"3fa7e38b_b0903198","updated":"2019-11-15 01:03:12.000000000","message":"The feature tested by this test case is valid both in py2 and py3, so I think we should keep this test cases and fix server-side codes to pass test cases on py3.","commit_id":"b0c939fe249ce993d1a5bf4e402b5d324a9da586"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"35b15cf5f5cce0b8d1236eba304788668d32fa1f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.invoke_storlet(\u0027GET\u0027, {\u0027double\u0027: \u0027true\u0027},"},{"line_number":173,"context_line":"                            header_parameters\u003dTrue)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @unittest.skipIf(six.PY3, \u0027execute can hang on py3 for some reason\u0027)"},{"line_number":176,"context_line":"    def test_get_execute(self):"},{"line_number":177,"context_line":"        self.invoke_storlet(\u0027GET\u0027, {\u0027execute\u0027: \u0027true\u0027})"},{"line_number":178,"context_line":"        self.invoke_storlet(\u0027GET\u0027, {\u0027execute\u0027: \u0027true\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_708ab964","side":"PARENT","line":175,"updated":"2019-11-14 10:53:20.000000000","message":"Same things here","commit_id":"b0c939fe249ce993d1a5bf4e402b5d324a9da586"}]}