)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c3f3d0dd1c5a9831de281f4e7fdf623d210a1297","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     maaoyu \u003cmaaoyu@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-25 09:45:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove install unnecessary packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docs requirements migrated to doc/requirements.txt"},{"line_number":10,"context_line":"we need not install things from requirements.txt."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_bf127b5f","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":35},"updated":"2020-09-25 14:19:28.000000000","message":"unnecessary package installation","commit_id":"59d96ef098b23d716a1534ce59a6574a95de984c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c3f3d0dd1c5a9831de281f4e7fdf623d210a1297","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove install unnecessary packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docs requirements migrated to doc/requirements.txt"},{"line_number":10,"context_line":"we need not install things from requirements.txt."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icb761d9312640a4d635e1c8042b79c6aa4baf44c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_5f035f10","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":11},"updated":"2020-09-25 14:19:28.000000000","message":"don\u0027t need to","commit_id":"59d96ef098b23d716a1534ce59a6574a95de984c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ad83272a0a38fc459777eb53a76dcc46644c911","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we don\u0027t need to install things from requirements.txt."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icb761d9312640a4d635e1c8042b79c6aa4baf44c"},{"line_number":13,"context_line":"Depends-On: I1166be2aee32d176412e562928b9887c6f6a083c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_1298fe73","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2020-10-09 02:48:16.000000000","message":"You don\u0027t need Depends-On since the change happens in a single repo.\n\nI think we can merge this independently because it might take some more time to adjust requirements to have ideal contents.","commit_id":"987b03823fadae4e0910894907f1d680b64c4049"}],"doc/requirements.txt":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c3f3d0dd1c5a9831de281f4e7fdf623d210a1297","unresolved":false,"context_lines":[{"line_number":1,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":2,"context_line":"openstackdocstheme\u003e\u003d2.2.1 # Apache-2.0"},{"line_number":3,"context_line":"reno\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":4,"context_line":"python-swiftclient\u003e\u003d3.1.0"},{"line_number":5,"context_line":"ipython\u003c6.0"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_9f197789","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":11},"updated":"2020-09-25 14:19:28.000000000","message":"Why do we need to add them to doc requirements ?\n\nI think they are not used in any doc builds, but do you see any issues without these lines ?","commit_id":"59d96ef098b23d716a1534ce59a6574a95de984c"},{"author":{"_account_id":31027,"name":"MaAoyu","email":"523354092@qq.com","username":"maaoyu"},"change_message_id":"38c446a0a54e3144282268f57b68ad1c84e16f1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":2,"context_line":"openstackdocstheme\u003e\u003d2.2.1 # Apache-2.0"},{"line_number":3,"context_line":"reno\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":4,"context_line":"python-swiftclient\u003e\u003d3.1.0"},{"line_number":5,"context_line":"ipython\u003c6.0"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_7155aaf8","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":11},"in_reply_to":"9f560f44_9f197789","updated":"2020-09-27 02:12:32.000000000","message":"I test again. The following errors were found. So I add the lines.\n\n2020-09-27 02:02:01.611843 | ubuntu-focal | Warning, treated as error:\n2020-09-27 02:02:01.611860 | ubuntu-focal | autodoc: failed to import module \u0027ipython\u0027 from module \u0027storlets.tools.extensions\u0027; the following exception was raised:\n2020-09-27 02:02:01.611876 | ubuntu-focal | No module named \u0027swiftclient\u0027\n2020-09-27 02:02:01.723078 | ubuntu-focal | ERROR: InvocationError for command /home/zuul/src/opendev.org/openstack/storlets/.tox/docs/bin/sphinx-build -a -W -E -b html doc/source doc/build/html (exited with code 2)\n2020-09-27 02:02:01.723175 | ubuntu-focal | docs finish: run-test  after 1.68 seconds\n2020-09-27 02:02:01.723679 | ubuntu-focal | docs start: run-test-post\n2020-09-27 02:02:01.723773 | ubuntu-focal | docs finish: run-test-post  after 0.00 seconds\n2020-09-27 02:02:01.724160 | ubuntu-focal | ___________________________________ summary ____________________________________\n2020-09-27 02:02:01.724230 | ubuntu-focal | ERROR:   docs: commands failed\n2020-09-27 02:02:02.202013 | ubuntu-focal | ERROR\n2020-09-27 02:02:02.202536 | ubuntu-focal | {\n2020-09-27 02:02:02.202684 | ubuntu-focal |   \"delta\": \"0:00:03.230988\",\n2020-09-27 02:02:02.202835 | ubuntu-focal |   \"end\": \"2020-09-27 02:02:01.746798\",\n2020-09-27 02:02:02.202988 | ubuntu-focal |   \"msg\": \"non-zero return code\",\n2020-09-27 02:02:02.203142 | ubuntu-focal |   \"rc\": 1,\n2020-09-27 02:02:02.203293 | ubuntu-focal |   \"start\": \"2020-09-27 02:01:58.515810\"\n2020-09-27 02:02:02.203444 | ubuntu-focal | }","commit_id":"59d96ef098b23d716a1534ce59a6574a95de984c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d53f1401af430d0a91db8ccd37b2042cad9922bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":2,"context_line":"openstackdocstheme\u003e\u003d2.2.1 # Apache-2.0"},{"line_number":3,"context_line":"reno\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":4,"context_line":"python-swiftclient\u003e\u003d3.1.0"},{"line_number":5,"context_line":"ipython\u003c6.0"}],"source_content_type":"text/plain","patch_set":8,"id":"9f560f44_9f561cce","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":11},"updated":"2020-10-05 11:49:41.000000000","message":"IIUC we need these lines to avoid module error raised by automated doc generation from the code.\n\nIMO, these requirements should be described in requirements.txt ideally, because they are actually required by some modules in storlets packages .\n\nSo what I would expect as the eventual goal are\n1. test-requirements.txt should be removed from doc build\n2. doc/requirements.txt includes all requirements specific to doc generation. This doesn\u0027t include these 2 packages actually required by storlets.tools module.\n3. requirements.txt has all required packages including these 2 and also used in doc generation\n\nI\u0027ll address 3 by another patch[1].\n\n[1] https://review.opendev.org/#/c/754626/","commit_id":"3d1c23da7a34e06ada3201c1cdee45ca0141f713"},{"author":{"_account_id":31027,"name":"MaAoyu","email":"523354092@qq.com","username":"maaoyu"},"change_message_id":"294c879cccbcff737f19afd6ebc3a0cb6b07854e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":2,"context_line":"openstackdocstheme\u003e\u003d2.2.1 # Apache-2.0"},{"line_number":3,"context_line":"reno\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":4,"context_line":"python-swiftclient\u003e\u003d3.1.0"},{"line_number":5,"context_line":"ipython\u003c6.0"}],"source_content_type":"text/plain","patch_set":8,"id":"9f560f44_17e0f026","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":11},"in_reply_to":"9f560f44_9f561cce","updated":"2020-10-09 01:41:45.000000000","message":"Yeah, I hear you.","commit_id":"3d1c23da7a34e06ada3201c1cdee45ca0141f713"}],"tox.ini":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d53f1401af430d0a91db8ccd37b2042cad9922bc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"basepython \u003d python3"},{"line_number":89,"context_line":"deps \u003d"},{"line_number":90,"context_line":"  -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":91,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":92,"context_line":"  git+git://github.com/openstack/swift.git"},{"line_number":93,"context_line":"commands \u003d"},{"line_number":94,"context_line":"  sphinx-build -a -W -E -b html doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":8,"id":"9f560f44_bfdde040","line":91,"updated":"2020-10-05 11:49:41.000000000","message":"I\u0027d prefer to keep -r{toxinidir}/requirements.txt because ideally we expect all dependencies of storlets are installed according to requirements.txt, to meet requirements to generate docs from codes.","commit_id":"3d1c23da7a34e06ada3201c1cdee45ca0141f713"},{"author":{"_account_id":31027,"name":"MaAoyu","email":"523354092@qq.com","username":"maaoyu"},"change_message_id":"294c879cccbcff737f19afd6ebc3a0cb6b07854e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"basepython \u003d python3"},{"line_number":89,"context_line":"deps \u003d"},{"line_number":90,"context_line":"  -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":91,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":92,"context_line":"  git+git://github.com/openstack/swift.git"},{"line_number":93,"context_line":"commands \u003d"},{"line_number":94,"context_line":"  sphinx-build -a -W -E -b html doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":8,"id":"9f560f44_d7c2f885","line":91,"in_reply_to":"9f560f44_bfdde040","updated":"2020-10-09 01:41:45.000000000","message":"OK.","commit_id":"3d1c23da7a34e06ada3201c1cdee45ca0141f713"}]}