)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4981eaac5acca2e418053bb389b2c2de3300b57b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0839f360_49daf0e8","updated":"2022-05-03 18:16:07.000000000","message":"Might want to address the setup.cfg comment, but otherwise LGTM.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5321f584793593c4d52d1fa8eecdebf92fe5f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0594d5d5_c7a7ad00","in_reply_to":"0839f360_49daf0e8","updated":"2022-05-04 12:55:17.000000000","message":"Thank you, Tim, for your feedback !","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"54a386f1be68b3dafd4eb81163b7b346cd5a941b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"891bcb29_8336c0ba","updated":"2022-05-13 10:33:33.000000000","message":"I\u0027ll approve this now becaus this would block py2 support removal in Swift.","commit_id":"302b73ca17aeaa29854338352f4b996d7c89af44"}],"playbooks/storlets-functional/post.yaml":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4981eaac5acca2e418053bb389b2c2de3300b57b","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        - \"ansible\""},{"line_number":31,"context_line":"        - \"storlets-daemon\""},{"line_number":32,"context_line":"        - \"daemon-factory\""},{"line_number":33,"context_line":"      become: yes"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - name: Copy logs from worker nodes to executor node"},{"line_number":36,"context_line":"      synchronize:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"59b9b6aa_3483cfbf","line":33,"updated":"2022-05-03 18:16:07.000000000","message":"Funny that there was this difference between py2/py3 versions...","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5321f584793593c4d52d1fa8eecdebf92fe5f8c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        - \"ansible\""},{"line_number":31,"context_line":"        - \"storlets-daemon\""},{"line_number":32,"context_line":"        - \"daemon-factory\""},{"line_number":33,"context_line":"      become: yes"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - name: Copy logs from worker nodes to executor node"},{"line_number":36,"context_line":"      synchronize:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f4f90bf5_622ca550","line":33,"in_reply_to":"59b9b6aa_3483cfbf","updated":"2022-05-04 12:55:17.000000000","message":"Yeah... looking at the tasks, it seems this is not necessary because these files are owned by zuul:zuul. I\u0027ll remove this.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"}],"s2aio.sh":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4981eaac5acca2e418053bb389b2c2de3300b57b","unresolved":true,"context_lines":[{"line_number":33,"context_line":"function _prepare_devstack_env {"},{"line_number":34,"context_line":"    # Checkout devstack"},{"line_number":35,"context_line":"    if [ ! -e $DEVSTACK_DIR ]; then"},{"line_number":36,"context_line":"        git clone https://github.com/openstack-dev/devstack.git $DEVSTACK_DIR"},{"line_number":37,"context_line":"        cp devstack/localrc.sample $DEVSTACK_DIR/localrc"},{"line_number":38,"context_line":"    fi"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"6bda5830_b0abadb7","line":36,"updated":"2022-05-03 18:16:07.000000000","message":"Might want to have this point at https://opendev.org/openstack/devstack/","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5321f584793593c4d52d1fa8eecdebf92fe5f8c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"function _prepare_devstack_env {"},{"line_number":34,"context_line":"    # Checkout devstack"},{"line_number":35,"context_line":"    if [ ! -e $DEVSTACK_DIR ]; then"},{"line_number":36,"context_line":"        git clone https://github.com/openstack-dev/devstack.git $DEVSTACK_DIR"},{"line_number":37,"context_line":"        cp devstack/localrc.sample $DEVSTACK_DIR/localrc"},{"line_number":38,"context_line":"    fi"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"111d3162_42b1bc39","line":36,"in_reply_to":"6bda5830_b0abadb7","updated":"2022-05-04 12:55:17.000000000","message":"I agree we should replace github here. I\u0027ll address this in a separate commit.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"}],"setup.cfg":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4981eaac5acca2e418053bb389b2c2de3300b57b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: 3.7"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3.8"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[pbr]"},{"line_number":24,"context_line":"skip_authors \u003d True"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"90e4746d_0ba24aa7","line":21,"updated":"2022-05-03 18:16:07.000000000","message":"Probably also want to add a\n\n python_requires \u003d \u003e\u003d 3.6\n\nline.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5321f584793593c4d52d1fa8eecdebf92fe5f8c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: 3.7"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3.8"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[pbr]"},{"line_number":24,"context_line":"skip_authors \u003d True"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"4a98a6b7_7c43afa9","line":21,"in_reply_to":"90e4746d_0ba24aa7","updated":"2022-05-04 12:55:17.000000000","message":"Done. That sounds reasonable.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"}],"tox.ini":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4981eaac5acca2e418053bb389b2c2de3300b57b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[testenv]"},{"line_number":9,"context_line":"basepython \u003d python3"},{"line_number":10,"context_line":"usedevelop \u003d True"},{"line_number":11,"context_line":"setenv \u003d"},{"line_number":12,"context_line":"   VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"b1a19a82_5846d85c","line":9,"updated":"2022-05-03 18:16:07.000000000","message":"Realistically, this probably isn\u0027t necessary. I\u0027d expect any dev environments to default to this these days.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5321f584793593c4d52d1fa8eecdebf92fe5f8c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[testenv]"},{"line_number":9,"context_line":"basepython \u003d python3"},{"line_number":10,"context_line":"usedevelop \u003d True"},{"line_number":11,"context_line":"setenv \u003d"},{"line_number":12,"context_line":"   VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"8a513117_27edbf63","line":9,"in_reply_to":"b1a19a82_5846d85c","updated":"2022-05-04 12:55:17.000000000","message":"I\u0027ve checked some other projects like nova or cinder but it seems this basepython line is globally kept so I\u0027ll follow that standard.","commit_id":"8ae088922bfefbcb85f754009d585cfd66a8a547"}]}