)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"214429224861b5a0b579b39c6d11fed51ba09e51","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     lujie \u003clujie@ict.ac.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-20 23:05:55 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move the chmod function before the write to prevent sensitive information leakage."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2047723"},{"line_number":10,"context_line":"Change-Id: If174ecbf34a2f864b24650fe20e91afdaa8ed846"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bd9cc8b6_14c38d24","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":82},"updated":"2024-01-20 17:03:50.000000000","message":"the title is too long, please consider making it a shorter summary.\n\nfor example;\n```\nRestrict file permission before writing contents\n```","commit_id":"52163b39771e93498380e3c8417ea5d4d19cf91d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb92035ad0e9485db2f97879c64276a004702b93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f49c05ee_be5fed1c","updated":"2024-01-20 17:34:57.000000000","message":"I\u0027m testing if we can put further restrictions https://review.opendev.org/c/openstack/storlets/+/906186","commit_id":"52163b39771e93498380e3c8417ea5d4d19cf91d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"214429224861b5a0b579b39c6d11fed51ba09e51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb410c04_0eccde75","updated":"2024-01-20 17:03:50.000000000","message":"Please update unit tests according to the logic change","commit_id":"52163b39771e93498380e3c8417ea5d4d19cf91d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d74c1c85fb55bb8bd1e27b34b5e5de5cb61348c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d692618f_b6c96488","in_reply_to":"cb410c04_0eccde75","updated":"2024-01-20 17:21:05.000000000","message":"Hmm. this might not be needed if you fix the apparent logic error","commit_id":"52163b39771e93498380e3c8417ea5d4d19cf91d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e135fd83332480b3be507320ee6e2a2083483802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e54bfc25_421e5fa0","in_reply_to":"f49c05ee_be5fed1c","updated":"2024-01-21 07:18:10.000000000","message":"OK that worked so I\u0027ll abandon this in favor of that version.","commit_id":"52163b39771e93498380e3c8417ea5d4d19cf91d"}],"storlets/gateway/gateways/docker/gateway.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d74c1c85fb55bb8bd1e27b34b5e5de5cb61348c1","unresolved":true,"context_lines":[{"line_number":316,"context_line":"                    perm \u003d \u00270600\u0027"},{"line_number":317,"context_line":"            # TODO(takashi): Do not directly write to target path"},{"line_number":318,"context_line":"            with open(cache_target_path, \u0027wb\u0027) as fn:"},{"line_number":319,"context_line":"                os.chmod(cache_target_path, int(perm, 8))"},{"line_number":320,"context_line":"                for data in data_iter:"},{"line_number":321,"context_line":"                    fn.write(data)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ece906b7_48d3f4c7","line":319,"range":{"start_line":319,"start_character":48,"end_line":319,"end_character":52},"updated":"2024-01-20 17:21:05.000000000","message":"The problem is that perm is not defined in case is_storlet is false. We have to skip the call according to is_storlet.","commit_id":"52163b39771e93498380e3c8417ea5d4d19cf91d"}]}
