)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37697,"name":"Ahmad Hassan","display_name":"Ahmad","email":"ahmad.hassan@canonical.com","username":"hassahma"},"change_message_id":"6304093bd70892e218ba4ad607cbc552092643e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf9de6d9_8e984207","updated":"2026-01-20 08:23:43.000000000","message":"recheck","commit_id":"c9138585579de136585786640efbd1960bcb12f9"},{"author":{"_account_id":37697,"name":"Ahmad Hassan","display_name":"Ahmad","email":"ahmad.hassan@canonical.com","username":"hassahma"},"change_message_id":"546722b1152adcc8ecd05ad1ab04990ac55f7888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"edfaebcb_9ba803bd","updated":"2026-01-23 09:16:19.000000000","message":"recheck","commit_id":"c9138585579de136585786640efbd1960bcb12f9"}],"charms/tempest-k8s/charmcraft.yaml":[{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"ed3fb33700076054cc2500950cfe797026aeb830","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        tempest tests. Removing a role from the list will disable tempest tests"},{"line_number":56,"context_line":"        relating to that role. Valid roles are: storage, compute, control."},{"line_number":57,"context_line":"    tempest-accounts-count:"},{"line_number":58,"context_line":"      type: string"},{"line_number":59,"context_line":"      default: \"8\""},{"line_number":60,"context_line":"        # It\u0027s desirable to have more accounts than the concurrency,"},{"line_number":61,"context_line":"        # so it can be hardcoded to a value that is"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9876c397_7ad15f18","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":18},"updated":"2026-01-13 08:45:31.000000000","message":"Is there a reason why this is of type string instead of int?\n\nDo you plan to add a magic value?","commit_id":"72853441eb053daeab3a28be23d09110cfde02bf"},{"author":{"_account_id":37697,"name":"Ahmad Hassan","display_name":"Ahmad","email":"ahmad.hassan@canonical.com","username":"hassahma"},"change_message_id":"f3659b92fd9e61e099c159b120ab75c1b173b040","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        tempest tests. Removing a role from the list will disable tempest tests"},{"line_number":56,"context_line":"        relating to that role. Valid roles are: storage, compute, control."},{"line_number":57,"context_line":"    tempest-accounts-count:"},{"line_number":58,"context_line":"      type: string"},{"line_number":59,"context_line":"      default: \"8\""},{"line_number":60,"context_line":"        # It\u0027s desirable to have more accounts than the concurrency,"},{"line_number":61,"context_line":"        # so it can be hardcoded to a value that is"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"17fc4b64_759e6d61","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":18},"in_reply_to":"9876c397_7ad15f18","updated":"2026-01-19 08:57:52.000000000","message":"changed charmed config to int to benefit from juju validation and then explicitly typecasting to str as env is always treated as str","commit_id":"72853441eb053daeab3a28be23d09110cfde02bf"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"ed3fb33700076054cc2500950cfe797026aeb830","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    tempest-accounts-count:"},{"line_number":58,"context_line":"      type: string"},{"line_number":59,"context_line":"      default: \"8\""},{"line_number":60,"context_line":"        # It\u0027s desirable to have more accounts than the concurrency,"},{"line_number":61,"context_line":"        # so it can be hardcoded to a value that is"},{"line_number":62,"context_line":"        # more than the max concurrency (see get_tempest_concurrency()),"},{"line_number":63,"context_line":"        # and still a relatively small number of accounts."},{"line_number":64,"context_line":"        # It\u0027s also helpful to have more accounts to mitigate the effects"},{"line_number":65,"context_line":"        # of credential locks not being released as per LP: #2052752."},{"line_number":66,"context_line":"      description: |"},{"line_number":67,"context_line":"        Number of tempest accounts for testing."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bb9d1f86_f072dcc4","line":65,"range":{"start_line":60,"start_character":8,"end_line":65,"end_character":69},"updated":"2026-01-13 08:45:31.000000000","message":"Isn\u0027t this comment better being part of the description? So that people outside of the code base doing a `juju config tempest-k8s` can read and reason about this value better?","commit_id":"72853441eb053daeab3a28be23d09110cfde02bf"},{"author":{"_account_id":37697,"name":"Ahmad Hassan","display_name":"Ahmad","email":"ahmad.hassan@canonical.com","username":"hassahma"},"change_message_id":"f3659b92fd9e61e099c159b120ab75c1b173b040","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    tempest-accounts-count:"},{"line_number":58,"context_line":"      type: string"},{"line_number":59,"context_line":"      default: \"8\""},{"line_number":60,"context_line":"        # It\u0027s desirable to have more accounts than the concurrency,"},{"line_number":61,"context_line":"        # so it can be hardcoded to a value that is"},{"line_number":62,"context_line":"        # more than the max concurrency (see get_tempest_concurrency()),"},{"line_number":63,"context_line":"        # and still a relatively small number of accounts."},{"line_number":64,"context_line":"        # It\u0027s also helpful to have more accounts to mitigate the effects"},{"line_number":65,"context_line":"        # of credential locks not being released as per LP: #2052752."},{"line_number":66,"context_line":"      description: |"},{"line_number":67,"context_line":"        Number of tempest accounts for testing."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e9087305_c4f43cc2","line":65,"range":{"start_line":60,"start_character":8,"end_line":65,"end_character":69},"in_reply_to":"bb9d1f86_f072dcc4","updated":"2026-01-19 08:57:52.000000000","message":"good point. moved it.","commit_id":"72853441eb053daeab3a28be23d09110cfde02bf"}]}
