)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"d68ef49643ac01adba9797e68ffbc3092db8f4d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f1d873e_3d1432cd","updated":"2026-07-04 01:27:38.000000000","message":"Seems in ironic we are looking for whether glance has exposed s3 backend or not. s3 credentials for ironic are not required at all. s3 relation in ironic does not make sense","commit_id":"50710f11818e9772dcf52c9077de67a698f6ca2a"}],"charms/glance-k8s/src/templates/glance-api.conf.j2":[{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"275ba8afb901ca462a8f24bb7361f3ef3fca3a4e","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[glance_store]"},{"line_number":26,"context_line":"{% if \u0027s3:s3\u0027 in glance_config.enabled_backends %}"},{"line_number":27,"context_line":"default_backend \u003d s3"},{"line_number":28,"context_line":"{% elif ceph.auth %}"},{"line_number":29,"context_line":"default_backend \u003d ceph"},{"line_number":30,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"4a6373ed_b742449c","line":27,"updated":"2026-07-04 01:37:35.000000000","message":"Any reason for s3 as default and getting priority over ceph?","commit_id":"50710f11818e9772dcf52c9077de67a698f6ca2a"}],"charms/ironic-conductor-k8s/src/charm.py":[{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"d68ef49643ac01adba9797e68ffbc3092db8f4d9","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"@sunbeam_tracing.trace_type"},{"line_number":143,"context_line":"class S3RelationHandler(sunbeam_rhandlers.RelationHandler):"},{"line_number":144,"context_line":"    \"\"\"Handler for the s3-credentials relation."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    Signals that Glance uses an external S3-compatible object store (via the"}],"source_content_type":"text/x-python","patch_set":2,"id":"bbbdc766_fac33fc7","line":143,"updated":"2026-07-04 01:27:38.000000000","message":"Can we move this to ops_sunbeam/relation_handlers.py and reuse it for glance-k8s and ironic-conductor-k8s","commit_id":"50710f11818e9772dcf52c9077de67a698f6ca2a"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"66220e604d3cdcf3e07dbd2b7a7f052496a813fa","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"@sunbeam_tracing.trace_type"},{"line_number":143,"context_line":"class S3RelationHandler(sunbeam_rhandlers.RelationHandler):"},{"line_number":144,"context_line":"    \"\"\"Handler for the s3-credentials relation."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    Signals that Glance uses an external S3-compatible object store (via the"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba4fc669_393e6877","line":143,"in_reply_to":"bbbdc766_fac33fc7","updated":"2026-07-04 01:36:42.000000000","message":"If the relationhandler is used by one charm, should be fine to keep in the charm","commit_id":"50710f11818e9772dcf52c9077de67a698f6ca2a"},{"author":{"_account_id":38581,"name":"Raven Kaur","display_name":"ravenk","email":"raven.kaur@canonical.com","username":"ravenk"},"change_message_id":"1ddc96945de1701deff414a6b157c6d37e92842c","unresolved":true,"context_lines":[{"line_number":436,"context_line":"        S3 backend and no Swift temp-url secret is needed."},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        If Glance is unavailable or the query fails, the S3 backend is assumed"},{"line_number":439,"context_line":"        to be unchanged from the last successful query."},{"line_number":440,"context_line":"        \"\"\""},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            keystone_session \u003d api_utils.create_keystone_session("}],"source_content_type":"text/x-python","patch_set":6,"id":"6795aa82_df5399dd","line":439,"updated":"2026-07-10 22:14:41.000000000","message":"Shouldn\u0027t `_glance_s3_backend` be in StoredState if it is assumed to be unchanged from the last successful query? As a plain instance variable it will reset to False on charm restart, so if Glance is briefly unreachable, the _validate_temp_url_secret will see a false value for `_glance_s3_backend` and expect a secret even though s3 was confirmed","commit_id":"88c7bb8360e67e18627c237605c385d5753ad46c"}]}
