)]}'
{"sushycli/system_boot.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sushycli import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"SYSTEM_ID_HELP \u003d ("},{"line_number":22,"context_line":"    \u0027The canonical path to the ComputerSystem resource that the driver \u0027"},{"line_number":23,"context_line":"    \u0027will interact with. It should include the root service, version and \u0027"},{"line_number":24,"context_line":"    \u0027the unique resource path to a ComputerSystem. For example: \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_57f43e88","line":21,"updated":"2020-02-07 15:00:10.000000000","message":"Please, rebase on my latest patch revision. I\u0027ve moved these repeating constants into a base class.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sushycli import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"SYSTEM_ID_HELP \u003d ("},{"line_number":22,"context_line":"    \u0027The canonical path to the ComputerSystem resource that the driver \u0027"},{"line_number":23,"context_line":"    \u0027will interact with. It should include the root service, version and \u0027"},{"line_number":24,"context_line":"    \u0027the unique resource path to a ComputerSystem. For example: \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_894daf94","line":21,"in_reply_to":"3fa7e38b_57f43e88","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class SystemBootShow(base.BaseLister):"},{"line_number":30,"context_line":"    \"\"\"shows machine boot info \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        \"\"\"SystemBootShow boot info command parser \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_d7258e17","line":30,"updated":"2020-02-07 15:00:10.000000000","message":"Better \"Show system boot information.\"\n\nThis goes to --help in the end","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class SystemBootShow(base.BaseLister):"},{"line_number":30,"context_line":"    \"\"\"shows machine boot info \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        \"\"\"SystemBootShow boot info command parser \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6925d3bf","line":30,"in_reply_to":"3fa7e38b_d7258e17","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"shows machine boot info \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        \"\"\"SystemBootShow boot info command parser \"\"\""},{"line_number":34,"context_line":"        parser \u003d super(SystemBootShow, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_972b96e7","line":33,"updated":"2020-02-07 15:00:10.000000000","message":"trailing whitespace","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"shows machine boot info \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        \"\"\"SystemBootShow boot info command parser \"\"\""},{"line_number":34,"context_line":"        parser \u003d super(SystemBootShow, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_89228fb6","line":33,"in_reply_to":"3fa7e38b_972b96e7","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return parser"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def take_action(self, args):"},{"line_number":44,"context_line":"        \"\"\"SystemShow system boot info command action \"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        root \u003d super(SystemBootShow, self).take_action(args)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_57399e3d","line":44,"updated":"2020-02-07 15:00:10.000000000","message":"trailing white space. You do not need to repeat class name in the docstring.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return parser"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def take_action(self, args):"},{"line_number":44,"context_line":"        \"\"\"SystemShow system boot info command action \"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        root \u003d super(SystemBootShow, self).take_action(args)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_29159b4c","line":44,"in_reply_to":"3fa7e38b_57399e3d","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        return ([\u0027Boot mode details\u0027,"},{"line_number":51,"context_line":"                \u0027allowed system boot devices\u0027],"},{"line_number":52,"context_line":"                [[sys_inst.boot.mode,"},{"line_number":53,"context_line":"                  sys_inst.get_allowed_system_boot_source_values()]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_771ffab7","line":50,"updated":"2020-02-07 15:00:10.000000000","message":"Let\u0027s show four things:\n\n\"Boot mode\", \"Available boot modes\", \"Boot device\", \"Available boot devices\"\n\nMay be we want two separate commands for boot mode and boot device?","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SystemBootSet(base.BaseCommand):"},{"line_number":57,"context_line":"    \"\"\"change machine boot device \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_parser(self, prog_name):"},{"line_number":60,"context_line":"        \"\"\"SystemBootDeviceSet boot device command parser\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_37150296","line":57,"updated":"2020-02-07 15:00:10.000000000","message":"Let\u0027s do better and consistent --help","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            help\u003dSYSTEM_ID_HELP)"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--target\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\"none|pxe|floppy|cd|usb|hdd\","},{"line_number":71,"context_line":"            choices\u003d[\u0027none\u0027, \u0027pxe\u0027, \u0027floppy\u0027, \u0027cd\u0027, \u0027usb\u0027, \u0027hdd\u0027],"},{"line_number":72,"context_line":"            type\u003dlambda x: x.lower(),"},{"line_number":73,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_376ae217","line":70,"updated":"2020-02-07 15:00:10.000000000","message":"I think --help should expand from `choices`, you do not need to do that by hand.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            help\u003dSYSTEM_ID_HELP)"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--target\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\"none|pxe|floppy|cd|usb|hdd\","},{"line_number":71,"context_line":"            choices\u003d[\u0027none\u0027, \u0027pxe\u0027, \u0027floppy\u0027, \u0027cd\u0027, \u0027usb\u0027, \u0027hdd\u0027],"},{"line_number":72,"context_line":"            type\u003dlambda x: x.lower(),"},{"line_number":73,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ecff91fc","line":70,"in_reply_to":"3fa7e38b_376ae217","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            choices\u003d[\u0027none\u0027, \u0027pxe\u0027, \u0027floppy\u0027, \u0027cd\u0027, \u0027usb\u0027, \u0027hdd\u0027],"},{"line_number":72,"context_line":"            type\u003dlambda x: x.lower(),"},{"line_number":73,"context_line":"            required\u003dTrue,"},{"line_number":74,"context_line":"            help\u003d\u0027the target boot source\u0027)"},{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027--enabled\u0027,"},{"line_number":77,"context_line":"            metavar\u003d\u0027none|continuous\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f7c68a15","line":74,"updated":"2020-02-07 15:00:10.000000000","message":"\"Set device to boot from\"","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            choices\u003d[\u0027none\u0027, \u0027pxe\u0027, \u0027floppy\u0027, \u0027cd\u0027, \u0027usb\u0027, \u0027hdd\u0027],"},{"line_number":72,"context_line":"            type\u003dlambda x: x.lower(),"},{"line_number":73,"context_line":"            required\u003dTrue,"},{"line_number":74,"context_line":"            help\u003d\u0027the target boot source\u0027)"},{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027--enabled\u0027,"},{"line_number":77,"context_line":"            metavar\u003d\u0027none|continuous\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_880a971b","line":74,"in_reply_to":"3fa7e38b_f7c68a15","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            required\u003dTrue,"},{"line_number":74,"context_line":"            help\u003d\u0027the target boot source\u0027)"},{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027--enabled\u0027,"},{"line_number":77,"context_line":"            metavar\u003d\u0027none|continuous\u0027,"},{"line_number":78,"context_line":"            help\u003d\u0027next reboot only or persistant to all future reboots\u0027"},{"line_number":79,"context_line":"                    \u0027default is set to boot once\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_17db26eb","line":76,"updated":"2020-02-07 15:00:10.000000000","message":"Let\u0027s do \u0027--once\u0027 and \u0027--continuous\u0027","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            required\u003dTrue,"},{"line_number":74,"context_line":"            help\u003d\u0027the target boot source\u0027)"},{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027--enabled\u0027,"},{"line_number":77,"context_line":"            metavar\u003d\u0027none|continuous\u0027,"},{"line_number":78,"context_line":"            help\u003d\u0027next reboot only or persistant to all future reboots\u0027"},{"line_number":79,"context_line":"                    \u0027default is set to boot once\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0c054d0f","line":76,"in_reply_to":"3fa7e38b_17db26eb","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        sys_inst.set_system_boot_source("},{"line_number":96,"context_line":"            args.target,"},{"line_number":97,"context_line":"            enabled\u003dsushy.BOOT_SOURCE_ENABLED_DISABLED"},{"line_number":98,"context_line":"            if args.enabled \u003d\u003d \u0027none\u0027"},{"line_number":99,"context_line":"            else sushy.BOOT_SOURCE_ENABLED_CONTINUOUS,"},{"line_number":100,"context_line":"            mode\u003dsushy.BOOT_SOURCE_MODE_UEFI"},{"line_number":101,"context_line":"            if args.mode \u003d\u003d \u0027uefi\u0027 else sushy.BOOT_SOURCE_MODE_BIOS)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f7ef6a83","line":98,"updated":"2020-02-07 15:00:10.000000000","message":"It\u0027s not `none`, but `once`.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        sys_inst.set_system_boot_source("},{"line_number":96,"context_line":"            args.target,"},{"line_number":97,"context_line":"            enabled\u003dsushy.BOOT_SOURCE_ENABLED_DISABLED"},{"line_number":98,"context_line":"            if args.enabled \u003d\u003d \u0027none\u0027"},{"line_number":99,"context_line":"            else sushy.BOOT_SOURCE_ENABLED_CONTINUOUS,"},{"line_number":100,"context_line":"            mode\u003dsushy.BOOT_SOURCE_MODE_UEFI"},{"line_number":101,"context_line":"            if args.mode \u003d\u003d \u0027uefi\u0027 else sushy.BOOT_SOURCE_MODE_BIOS)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_fd198b86","line":98,"in_reply_to":"3fa7e38b_f7ef6a83","updated":"2020-02-10 19:35:52.000000000","message":"ok, so we won\u0027t mention the \"BOOT_SOURCE_ENABLED_DISABLED\" option!\nalso, \"once\" option is the default option in sushy, i was thinking if we mention this at the help it would be enough! \nwdyt?","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2556351edffd3b8c26f2128a71707cd2929c1319","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        return ([\u0027Boot mode\u0027, \u0027Available boot modes\u0027,"},{"line_number":33,"context_line":"                 \u0027Boot device\u0027, \u0027Available boot devices\u0027],"},{"line_number":34,"context_line":"                [[sys_inst.boot.mode, sys_inst.boot.allowed_values,"},{"line_number":35,"context_line":"                  sys_inst.get_allowed_system_boot_source_values(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_ca5cd981","line":32,"updated":"2020-02-11 13:07:24.000000000","message":"Let\u0027s put these lists into separate variables for readability","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        return ([\u0027Boot mode\u0027, \u0027Available boot modes\u0027,"},{"line_number":33,"context_line":"                 \u0027Boot device\u0027, \u0027Available boot devices\u0027],"},{"line_number":34,"context_line":"                [[sys_inst.boot.mode, sys_inst.boot.allowed_values,"},{"line_number":35,"context_line":"                  sys_inst.get_allowed_system_boot_source_values(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_dec6d715","line":32,"in_reply_to":"3fa7e38b_ca5cd981","updated":"2020-02-11 22:07:54.000000000","message":"Done","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2556351edffd3b8c26f2128a71707cd2929c1319","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class SystemBootSet(base_system.BaseCommand):"},{"line_number":40,"context_line":"    \"\"\"Change system boot mode and device specifying the frequency;\"\"\""},{"line_number":41,"context_line":"    \"\"\"either this set it applied once or persistant for future reboots\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_parser(self, prog_name):"},{"line_number":44,"context_line":"        \"\"\"Set boot device command parser\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_ea78b5f7","line":41,"updated":"2020-02-11 13:07:24.000000000","message":"This is the right docstring format:\n\n\"\"\"Short title\n\nLong explanations...\n\"\"\"","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class SystemBootSet(base_system.BaseCommand):"},{"line_number":40,"context_line":"    \"\"\"Change system boot mode and device specifying the frequency;\"\"\""},{"line_number":41,"context_line":"    \"\"\"either this set it applied once or persistant for future reboots\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_parser(self, prog_name):"},{"line_number":44,"context_line":"        \"\"\"Set boot device command parser\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_fe24f3c5","line":41,"in_reply_to":"3fa7e38b_ea78b5f7","updated":"2020-02-11 22:07:54.000000000","message":"Done","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2556351edffd3b8c26f2128a71707cd2929c1319","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            help\u003d\u0027the target boot source\u0027)"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--enabled\u0027,"},{"line_number":56,"context_line":"            metavar\u003d\u0027once|continuous\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027next reboot only or persistant to all future reboots\u0027"},{"line_number":58,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":59,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_ea619539","line":56,"updated":"2020-02-11 13:07:24.000000000","message":"What about \"none\"?\n\nAlso, why is not this a choice?","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            help\u003d\u0027the target boot source\u0027)"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--enabled\u0027,"},{"line_number":56,"context_line":"            metavar\u003d\u0027once|continuous\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027next reboot only or persistant to all future reboots\u0027"},{"line_number":58,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":59,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_d9e83116","line":56,"in_reply_to":"3fa7e38b_ea619539","updated":"2020-02-11 22:07:54.000000000","message":"Done","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2556351edffd3b8c26f2128a71707cd2929c1319","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--enabled\u0027,"},{"line_number":56,"context_line":"            metavar\u003d\u0027once|continuous\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027next reboot only or persistant to all future reboots\u0027"},{"line_number":58,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--mode\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_6a4da5c3","line":57,"updated":"2020-02-11 13:07:24.000000000","message":"Let\u0027s start help with a capital letter","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--enabled\u0027,"},{"line_number":56,"context_line":"            metavar\u003d\u0027once|continuous\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027next reboot only or persistant to all future reboots\u0027"},{"line_number":58,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--mode\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_79e9fd15","line":57,"in_reply_to":"3fa7e38b_6a4da5c3","updated":"2020-02-11 22:07:54.000000000","message":"Done","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4d494b5dd97b160563751c6caf41a106ecc2842e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Set the system boot mode/device"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Change system boot mode and device specifying the frequency;"},{"line_number":46,"context_line":"    either it is disabled, applied once or persistant for future reboots"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_1c754d00","line":46,"range":{"start_line":46,"start_character":43,"end_line":46,"end_character":53},"updated":"2020-02-12 09:11:53.000000000","message":"nit: persistent","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"a90e4965d6004fc90c6afebab747418ee9a6df5a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Set the system boot mode/device"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Change system boot mode and device specifying the frequency;"},{"line_number":46,"context_line":"    either it is disabled, applied once or persistant for future reboots"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_22e5823e","line":46,"range":{"start_line":46,"start_character":43,"end_line":46,"end_character":53},"in_reply_to":"3fa7e38b_1c754d00","updated":"2020-02-12 12:35:08.000000000","message":"Done","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4d494b5dd97b160563751c6caf41a106ecc2842e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \u0027--enabled\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027disabled|once|continuous\u0027,"},{"line_number":63,"context_line":"            choices\u003d[\u0027disabled\u0027, \u0027once\u0027, \u0027continuous\u0027],"},{"line_number":64,"context_line":"            help\u003d\u0027Next reboot only or persistant to all future reboots\u0027"},{"line_number":65,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--mode\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_5c1985cf","line":64,"range":{"start_line":64,"start_character":70,"end_line":64,"end_character":71},"updated":"2020-02-12 09:11:53.000000000","message":"nit: add a semi-colon here and a space","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4d494b5dd97b160563751c6caf41a106ecc2842e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \u0027--enabled\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027disabled|once|continuous\u0027,"},{"line_number":63,"context_line":"            choices\u003d[\u0027disabled\u0027, \u0027once\u0027, \u0027continuous\u0027],"},{"line_number":64,"context_line":"            help\u003d\u0027Next reboot only or persistant to all future reboots\u0027"},{"line_number":65,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--mode\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_dc057569","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":48},"updated":"2020-02-12 09:11:53.000000000","message":"nit: persistent","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"a90e4965d6004fc90c6afebab747418ee9a6df5a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \u0027--enabled\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027disabled|once|continuous\u0027,"},{"line_number":63,"context_line":"            choices\u003d[\u0027disabled\u0027, \u0027once\u0027, \u0027continuous\u0027],"},{"line_number":64,"context_line":"            help\u003d\u0027Next reboot only or persistant to all future reboots\u0027"},{"line_number":65,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--mode\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_6265baaf","line":64,"range":{"start_line":64,"start_character":70,"end_line":64,"end_character":71},"in_reply_to":"3fa7e38b_5c1985cf","updated":"2020-02-12 12:35:08.000000000","message":"Done","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"a90e4965d6004fc90c6afebab747418ee9a6df5a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \u0027--enabled\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027disabled|once|continuous\u0027,"},{"line_number":63,"context_line":"            choices\u003d[\u0027disabled\u0027, \u0027once\u0027, \u0027continuous\u0027],"},{"line_number":64,"context_line":"            help\u003d\u0027Next reboot only or persistant to all future reboots\u0027"},{"line_number":65,"context_line":"                    \u0027default is set to boot once\u0027)"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--mode\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_8260f69f","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":48},"in_reply_to":"3fa7e38b_dc057569","updated":"2020-02-12 12:35:08.000000000","message":"Done","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        sys_inst.set_system_boot_source("},{"line_number":82,"context_line":"            args.target,"},{"line_number":83,"context_line":"            enabled\u003dargs.enabled,"},{"line_number":84,"context_line":"            mode\u003dsushy.BOOT_SOURCE_MODE_UEFI"},{"line_number":85,"context_line":"            if args.mode \u003d\u003d \u0027uefi\u0027 else sushy.BOOT_SOURCE_MODE_BIOS)"},{"line_number":86,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_a7950b96","line":83,"range":{"start_line":82,"start_character":12,"end_line":83,"end_character":33},"updated":"2020-02-11 22:07:54.000000000","message":"here we have this solution(taking args directly as a parameter, or we use if statement before calling the set_system method..\nwdyt?","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"a90e4965d6004fc90c6afebab747418ee9a6df5a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        sys_inst.set_system_boot_source("},{"line_number":82,"context_line":"            args.target,"},{"line_number":83,"context_line":"            enabled\u003dargs.enabled,"},{"line_number":84,"context_line":"            mode\u003dsushy.BOOT_SOURCE_MODE_UEFI"},{"line_number":85,"context_line":"            if args.mode \u003d\u003d \u0027uefi\u0027 else sushy.BOOT_SOURCE_MODE_BIOS)"},{"line_number":86,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_c237ceda","line":83,"range":{"start_line":82,"start_character":12,"end_line":83,"end_character":33},"in_reply_to":"3fa7e38b_1cfb0d15","updated":"2020-02-12 12:35:08.000000000","message":"Done","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"a90e4965d6004fc90c6afebab747418ee9a6df5a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        sys_inst.set_system_boot_source("},{"line_number":82,"context_line":"            args.target,"},{"line_number":83,"context_line":"            enabled\u003dargs.enabled,"},{"line_number":84,"context_line":"            mode\u003dsushy.BOOT_SOURCE_MODE_UEFI"},{"line_number":85,"context_line":"            if args.mode \u003d\u003d \u0027uefi\u0027 else sushy.BOOT_SOURCE_MODE_BIOS)"},{"line_number":86,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_42043ec5","line":83,"range":{"start_line":82,"start_character":12,"end_line":83,"end_character":33},"in_reply_to":"3fa7e38b_a7950b96","updated":"2020-02-12 12:35:08.000000000","message":"Done","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d7ae1939cf3c64788c36940a378ac8ea72cd6c91","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        sys_inst.set_system_boot_source("},{"line_number":82,"context_line":"            args.target,"},{"line_number":83,"context_line":"            enabled\u003dargs.enabled,"},{"line_number":84,"context_line":"            mode\u003dsushy.BOOT_SOURCE_MODE_UEFI"},{"line_number":85,"context_line":"            if args.mode \u003d\u003d \u0027uefi\u0027 else sushy.BOOT_SOURCE_MODE_BIOS)"},{"line_number":86,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_1cfb0d15","line":83,"range":{"start_line":82,"start_character":12,"end_line":83,"end_character":33},"in_reply_to":"3fa7e38b_a7950b96","updated":"2020-02-12 08:04:19.000000000","message":"This:\n\n      enabled\u003dargs.enabled,\n\nlooks good to me.","commit_id":"b1e8a052a61bfe27c070f6298069c896aa31d0f2"}],"sushycli/tests/unit/cmd/test_system_boot.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2020 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_77c37a3a","line":1,"updated":"2020-02-07 15:00:10.000000000","message":"snip this line","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5263d50e6a6ae1ec564891ea40b0f6db627d8ba5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @mock.patch(\u0027sys.stdout.write\u0027, autospec\u003dTrue)"},{"line_number":31,"context_line":"    def test_system_boot_show(self, mock_write, mock_sushy):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        s \u003d set([\u0027hdd\u0027, \u0027pxe\u0027, \u0027cd\u0027])"},{"line_number":34,"context_line":"        mock_root \u003d mock_sushy.return_value"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        mock_system \u003d mock_root.get_system.return_value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_d4e34c39","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":37},"updated":"2020-02-07 13:50:09.000000000","message":"you can probably replace this with a set literal (should also fix the issue with the failing test)","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @mock.patch(\u0027sys.stdout.write\u0027, autospec\u003dTrue)"},{"line_number":31,"context_line":"    def test_system_boot_show(self, mock_write, mock_sushy):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        s \u003d set([\u0027hdd\u0027, \u0027pxe\u0027, \u0027cd\u0027])"},{"line_number":34,"context_line":"        mock_root \u003d mock_sushy.return_value"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        mock_system \u003d mock_root.get_system.return_value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_69a2b342","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":37},"in_reply_to":"3fa7e38b_579d1e56","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @mock.patch(\u0027sys.stdout.write\u0027, autospec\u003dTrue)"},{"line_number":31,"context_line":"    def test_system_boot_show(self, mock_write, mock_sushy):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        s \u003d set([\u0027hdd\u0027, \u0027pxe\u0027, \u0027cd\u0027])"},{"line_number":34,"context_line":"        mock_root \u003d mock_sushy.return_value"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        mock_system \u003d mock_root.get_system.return_value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_579d1e56","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":37},"in_reply_to":"3fa7e38b_d4e34c39","updated":"2020-02-07 15:00:10.000000000","message":"+1\n\nAlso, one-letter variable names are not the best possible names.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @mock.patch(\u0027sys.stdout.write\u0027, autospec\u003dTrue)"},{"line_number":31,"context_line":"    def test_system_boot_show(self, mock_write, mock_sushy):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        s \u003d set([\u0027hdd\u0027, \u0027pxe\u0027, \u0027cd\u0027])"},{"line_number":34,"context_line":"        mock_root \u003d mock_sushy.return_value"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        mock_system \u003d mock_root.get_system.return_value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c9a96725","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":37},"in_reply_to":"3fa7e38b_d4e34c39","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5263d50e6a6ae1ec564891ea40b0f6db627d8ba5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mock_sushy.assert_called_once_with("},{"line_number":47,"context_line":"            \u0027http://fish.me\u0027, password\u003d\u0027fish\u0027, username\u003d\u0027jelly\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        expected_calles \u003d ["},{"line_number":50,"context_line":"            mock.call(\u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":51,"context_line":"                      \u0027| Boot mode details | allowed system boot devices |\\n\u0027"},{"line_number":52,"context_line":"                      \u0027+-------------------+-----------------------------+\\n\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_14b6c427","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":23},"updated":"2020-02-07 13:50:09.000000000","message":"nit: calls","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mock_sushy.assert_called_once_with("},{"line_number":47,"context_line":"            \u0027http://fish.me\u0027, password\u003d\u0027fish\u0027, username\u003d\u0027jelly\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        expected_calles \u003d ["},{"line_number":50,"context_line":"            mock.call(\u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":51,"context_line":"                      \u0027| Boot mode details | allowed system boot devices |\\n\u0027"},{"line_number":52,"context_line":"                      \u0027+-------------------+-----------------------------+\\n\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_09b45f80","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":23},"in_reply_to":"3fa7e38b_14b6c427","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mock_sushy.assert_called_once_with("},{"line_number":47,"context_line":"            \u0027http://fish.me\u0027, password\u003d\u0027fish\u0027, username\u003d\u0027jelly\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        expected_calles \u003d ["},{"line_number":50,"context_line":"            mock.call(\u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":51,"context_line":"                      \u0027| Boot mode details | allowed system boot devices |\\n\u0027"},{"line_number":52,"context_line":"                      \u0027+-------------------+-----------------------------+\\n\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b77fb214","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":23},"in_reply_to":"3fa7e38b_14b6c427","updated":"2020-02-07 15:00:10.000000000","message":"This comes by copy\u0026paste from my code (which is fixed). Sorry!","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mock_sushy.assert_called_once_with("},{"line_number":47,"context_line":"            \u0027http://fish.me\u0027, password\u003d\u0027fish\u0027, username\u003d\u0027jelly\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        expected_calles \u003d ["},{"line_number":50,"context_line":"            mock.call(\u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":51,"context_line":"                      \u0027| Boot mode details | allowed system boot devices |\\n\u0027"},{"line_number":52,"context_line":"                      \u0027+-------------------+-----------------------------+\\n\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a9ac2b36","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":23},"in_reply_to":"3fa7e38b_b77fb214","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26e7429d61c5fe659879d982877058291bcbc370","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            mock.call(\u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":51,"context_line":"                      \u0027| Boot mode details | allowed system boot devices |\\n\u0027"},{"line_number":52,"context_line":"                      \u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":53,"context_line":"                      \u0027| None              | \u0027 + repr(s.copy()) + \u0027        |\\n\u0027"},{"line_number":54,"context_line":"                      \u0027+-------------------+-----------------------------+\u0027),"},{"line_number":55,"context_line":"            mock.call(\u0027\\n\u0027)"},{"line_number":56,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b7ad7284","line":53,"updated":"2020-02-07 15:00:10.000000000","message":"You do not need `copy` here, but you might want `sort`. Otherwise your tests will be failing at times.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            mock.call(\u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":51,"context_line":"                      \u0027| Boot mode details | allowed system boot devices |\\n\u0027"},{"line_number":52,"context_line":"                      \u0027+-------------------+-----------------------------+\\n\u0027"},{"line_number":53,"context_line":"                      \u0027| None              | \u0027 + repr(s.copy()) + \u0027        |\\n\u0027"},{"line_number":54,"context_line":"                      \u0027+-------------------+-----------------------------+\u0027),"},{"line_number":55,"context_line":"            mock.call(\u0027\\n\u0027)"},{"line_number":56,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_295efb50","line":53,"in_reply_to":"3fa7e38b_b7ad7284","updated":"2020-02-10 19:35:52.000000000","message":"\u003e You do not need `copy` here, but you might want `sort`. Otherwise\n \u003e your tests will be failing at times.\n\nyes this was my thinking at first too, then i found out that it is impossible to sort a set in python so I turned to the copy solution.","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5263d50e6a6ae1ec564891ea40b0f6db627d8ba5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            mock.call(\u0027\\n\u0027)"},{"line_number":56,"context_line":"        ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        mock_write.assert_has_calls(expected_calles)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_system_boot_set(self, mock_sushy):"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_34b3c037","line":58,"range":{"start_line":58,"start_character":45,"end_line":58,"end_character":51},"updated":"2020-02-07 13:50:09.000000000","message":"nit: calls","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"5029c974a7a2d80cefc93c426f12729900b4fac9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            mock.call(\u0027\\n\u0027)"},{"line_number":56,"context_line":"        ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        mock_write.assert_has_calls(expected_calles)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_system_boot_set(self, mock_sushy):"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_4963371a","line":58,"range":{"start_line":58,"start_character":45,"end_line":58,"end_character":51},"in_reply_to":"3fa7e38b_34b3c037","updated":"2020-02-10 19:35:52.000000000","message":"Done","commit_id":"58f58a1aa0c57600e8fa1e05705b76d2432d22bc"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2556351edffd3b8c26f2128a71707cd2929c1319","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2020 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_aa9abd0e","line":1,"updated":"2020-02-11 13:07:24.000000000","message":"Let\u0027s move these tests into the only test file we have in cmd? May be it makes sense to spread the tests over many files, but I\u0027d do that as a separate patch.","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2020 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_d1c6c515","line":1,"in_reply_to":"3fa7e38b_aa9abd0e","updated":"2020-02-11 22:07:54.000000000","message":"Done","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2556351edffd3b8c26f2128a71707cd2929c1319","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        mock_system \u003d mock_root.get_system.return_value"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        mock_system.set_system_boot_source.\\"},{"line_number":90,"context_line":"            assert_called_once_with(\u0027cd\u0027, enabled\u003d\u0027continuous\u0027, mode\u003d\u0027uefi\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_2af1ed64","line":90,"updated":"2020-02-11 13:07:24.000000000","message":"Why are you calling it with \"none\", but expecting \"continuous\"?","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"de1d1fb3919584622411ccd516514fa7a2386216","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        mock_system \u003d mock_root.get_system.return_value"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        mock_system.set_system_boot_source.\\"},{"line_number":90,"context_line":"            assert_called_once_with(\u0027cd\u0027, enabled\u003d\u0027continuous\u0027, mode\u003d\u0027uefi\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_5405e313","line":90,"in_reply_to":"3fa7e38b_2af1ed64","updated":"2020-02-11 22:07:54.000000000","message":"\u003e Why are you calling it with \"none\", but expecting \"continuous\"?\n\nbecause it was passed as an else condition:\nif args.enabled\u003d disaled ...\nelse (which was once args in this case) do continuous..\nthat\u0027s why i updated the code","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d7ae1939cf3c64788c36940a378ac8ea72cd6c91","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        mock_system \u003d mock_root.get_system.return_value"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        mock_system.set_system_boot_source.\\"},{"line_number":90,"context_line":"            assert_called_once_with(\u0027cd\u0027, enabled\u003d\u0027continuous\u0027, mode\u003d\u0027uefi\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_bc32f9f1","line":90,"in_reply_to":"3fa7e38b_5405e313","updated":"2020-02-12 08:04:19.000000000","message":"Pardon me, but I can\u0027t readily grasp it.\n\nIn sushy we have these constants:\n\n    BOOT_SOURCE_ENABLED_ONCE \u003d \u0027once\u0027\n    BOOT_SOURCE_ENABLED_CONTINUOUS \u003d \u0027continuous\u0027\n    BOOT_SOURCE_ENABLED_DISABLED \u003d \u0027disabled\u0027\n\nSo I expect to see:\n\n    set_system_boot_source(enabled\u003d BOOT_SOURCE_ENABLED_DISABLED)\n\nin response to:\n\n    sushycli system boot set --enabled none\n\nWhere did I get confused?","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"a90e4965d6004fc90c6afebab747418ee9a6df5a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        mock_system \u003d mock_root.get_system.return_value"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        mock_system.set_system_boot_source.\\"},{"line_number":90,"context_line":"            assert_called_once_with(\u0027cd\u0027, enabled\u003d\u0027continuous\u0027, mode\u003d\u0027uefi\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_056890f0","line":90,"in_reply_to":"3fa7e38b_bc32f9f1","updated":"2020-02-12 12:35:08.000000000","message":"sorry i didn\u0027t explained it well,\nthe code was supporting only 2 choices[disabled, continuous] with \u0027once\u0027 choice as a default, then after adding the once choice, I updated it to\n\n\" enabled\u003dsushy.BOOT_SOURCE_ENABLED_DISABLED\nif args.enabled \u003d\u003d \u0027once\u0027\nelse sushy.BOOT_SOURCE_ENABLED_CONTINUOUS \"\n\nand it wasn\u0027t very correct, so enabled will get \u0027continuous\u0027 not only if we enter \u0027continuous\u0027 as an args, but for all other cases.. none is our case.. \n\nbut now it is resolved.","commit_id":"359fdf42a70ea925d0790d3da7c62de93bf3e455"}]}