)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     khansa \u003ckhansa.amrouni@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-05 21:04:43 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding system BIOS management command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding BIOS management command:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_307ce6ea","line":7,"updated":"2020-03-06 15:06:01.000000000","message":"Please, google on how to write commit messages. These are just a couple of simple rules.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     khansa \u003ckhansa.amrouni@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-05 21:04:43 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding system BIOS management command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding BIOS management command:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_3706f753","line":7,"in_reply_to":"1fa4df85_307ce6ea","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e9f9bb92f700de3f4fba479cf068ca4fc64ce03b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"     sushycli system bios reset"},{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_5b4e6bc1","line":15,"range":{"start_line":15,"start_character":64,"end_line":15,"end_character":70},"updated":"2020-03-06 07:07:30.000000000","message":"Nit: default","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"     sushycli system bios reset"},{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_57013337","line":15,"range":{"start_line":15,"start_character":64,"end_line":15,"end_character":70},"in_reply_to":"1fa4df85_5b4e6bc1","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":12,"context_line":"     sushycli system bios reset"},{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_70757ef9","line":15,"range":{"start_line":15,"start_character":64,"end_line":15,"end_character":70},"in_reply_to":"1fa4df85_5b4e6bc1","updated":"2020-03-06 15:06:01.000000000","message":"long line","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e9f9bb92f700de3f4fba479cf068ca4fc64ce03b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":19,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_7b49e7b4","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":48},"updated":"2020-03-06 07:07:30.000000000","message":"Nit: require","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":19,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_d79a0312","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":48},"in_reply_to":"1fa4df85_50cde22e","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"174e5843e63f6c26655a5610f9e1f428795f5533","unresolved":false,"context_lines":[{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":19,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_b72ae77b","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":48},"in_reply_to":"1fa4df85_50cde22e","updated":"2020-03-10 08:56:21.000000000","message":"I agree with Ilya, let\u0027s rephrase this.\nThe standard way to enable applied changes to BIOS settings is to restart a device.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":19,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_50cde22e","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":48},"in_reply_to":"1fa4df85_7b49e7b4","updated":"2020-03-06 15:06:01.000000000","message":"\u003e update one or many BIOS attributes that requires a system restart.\n\nThis is confusing. I suspect that any BIOS attribute change will require restart. May be better note that the user can change whatever they want and is likely to have to perform system restart upon any (?) change.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":19,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_17f73b5b","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":48},"in_reply_to":"1fa4df85_7b49e7b4","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"     sushycli system bios set [attributes]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"these commands allow to show current BIOS settings, reset it to defaut or"},{"line_number":16,"context_line":"update one or many BIOS attributes that requires a system restart."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":19,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_f28f0d72","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":48},"in_reply_to":"1fa4df85_b72ae77b","updated":"2020-03-10 10:49:11.000000000","message":"thanks","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"183f4721dea4ff8cfe9040aff5e9a79331c5c5aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add system BIOS management command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"this change illustrate three BIOS management commands:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" sushycli system bios show #show BIOS attributes"},{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1fa4df85_aa3a5595","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":22},"updated":"2020-03-12 07:15:08.000000000","message":"nit: illustrates","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add system BIOS management command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"this change illustrates three BIOS management commands:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" sushycli system bios show #show BIOS attributes"},{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_7e12de64","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"updated":"2020-03-12 10:14:41.000000000","message":"This","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add system BIOS management command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"this change illustrates three BIOS management commands:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" sushycli system bios show #show BIOS attributes"},{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_522033b1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"in_reply_to":"1fa4df85_7e12de64","updated":"2020-03-13 13:01:52.000000000","message":"Done","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"},{"line_number":13,"context_line":" sushycli system bios set BootMode\u003dBios [key\u003dvalue] #update attributes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"show and reset BIOS commands require \"commun\" attributes/arguments as:"},{"line_number":16,"context_line":"              --username\u003djelly --password\u003dfish"},{"line_number":17,"context_line":"              --service-endpoint\u003dhttp://fish.me"},{"line_number":18,"context_line":"              --system-id\u003d/redfish/v1/Systems/1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_9e179a52","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":4},"updated":"2020-03-12 10:14:41.000000000","message":"Show","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"},{"line_number":13,"context_line":" sushycli system bios set BootMode\u003dBios [key\u003dvalue] #update attributes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"show and reset BIOS commands require \"commun\" attributes/arguments as:"},{"line_number":16,"context_line":"              --username\u003djelly --password\u003dfish"},{"line_number":17,"context_line":"              --service-endpoint\u003dhttp://fish.me"},{"line_number":18,"context_line":"              --system-id\u003d/redfish/v1/Systems/1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_be185684","line":15,"updated":"2020-03-12 10:14:41.000000000","message":"common?","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"},{"line_number":13,"context_line":" sushycli system bios set BootMode\u003dBios [key\u003dvalue] #update attributes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"show and reset BIOS commands require \"commun\" attributes/arguments as:"},{"line_number":16,"context_line":"              --username\u003djelly --password\u003dfish"},{"line_number":17,"context_line":"              --service-endpoint\u003dhttp://fish.me"},{"line_number":18,"context_line":"              --system-id\u003d/redfish/v1/Systems/1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_b2188784","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":4},"in_reply_to":"1fa4df85_9e179a52","updated":"2020-03-13 13:01:52.000000000","message":"Done","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":12,"context_line":" sushycli system bios reset #reset BIOS attributes to default"},{"line_number":13,"context_line":" sushycli system bios set BootMode\u003dBios [key\u003dvalue] #update attributes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"show and reset BIOS commands require \"commun\" attributes/arguments as:"},{"line_number":16,"context_line":"              --username\u003djelly --password\u003dfish"},{"line_number":17,"context_line":"              --service-endpoint\u003dhttp://fish.me"},{"line_number":18,"context_line":"              --system-id\u003d/redfish/v1/Systems/1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_d21d0374","line":15,"in_reply_to":"1fa4df85_be185684","updated":"2020-03-13 13:01:52.000000000","message":"Done","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":17,"context_line":"              --service-endpoint\u003dhttp://fish.me"},{"line_number":18,"context_line":"              --system-id\u003d/redfish/v1/Systems/1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set BIOS command requires one more attribute(s), which is the bios"},{"line_number":21,"context_line":"attribute(s)."},{"line_number":22,"context_line":"set bios command allows to update one or many BIOS attributes at once."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_3e0c6641","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":3},"updated":"2020-03-12 10:14:41.000000000","message":"Set","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":17,"context_line":"              --service-endpoint\u003dhttp://fish.me"},{"line_number":18,"context_line":"              --system-id\u003d/redfish/v1/Systems/1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set BIOS command requires one more attribute(s), which is the bios"},{"line_number":21,"context_line":"attribute(s)."},{"line_number":22,"context_line":"set bios command allows to update one or many BIOS attributes at once."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_72120f65","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":3},"in_reply_to":"1fa4df85_3e0c6641","updated":"2020-03-13 13:01:52.000000000","message":"Done","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":21,"context_line":"attribute(s)."},{"line_number":22,"context_line":"set bios command allows to update one or many BIOS attributes at once."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Noting that The standard way to enable these applied changes to"},{"line_number":25,"context_line":"BIOS settings is to restart the device."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_0134afdd","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":52},"updated":"2020-03-12 10:14:41.000000000","message":"pending?","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":21,"context_line":"attribute(s)."},{"line_number":22,"context_line":"set bios command allows to update one or many BIOS attributes at once."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Noting that The standard way to enable these applied changes to"},{"line_number":25,"context_line":"BIOS settings is to restart the device."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_a10cbb3b","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":15},"updated":"2020-03-12 10:14:41.000000000","message":"the","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":21,"context_line":"attribute(s)."},{"line_number":22,"context_line":"set bios command allows to update one or many BIOS attributes at once."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Noting that The standard way to enable these applied changes to"},{"line_number":25,"context_line":"BIOS settings is to restart the device."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_c12697bb","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":24},"updated":"2020-03-12 10:14:41.000000000","message":"typical","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":22,"context_line":"set bios command allows to update one or many BIOS attributes at once."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Noting that The standard way to enable these applied changes to"},{"line_number":25,"context_line":"BIOS settings is to restart the device."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: If02304177c914146b78e731b085fe988685e5b85"},{"line_number":28,"context_line":"Story: 2006608"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_2118cb73","line":25,"range":{"start_line":25,"start_character":32,"end_line":25,"end_character":38},"updated":"2020-03-12 10:14:41.000000000","message":"machine","commit_id":"dfde58941283df9bf35ab7396ce9eefaf4ae04b1"}],"setup.cfg":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e9f9bb92f700de3f4fba479cf068ca4fc64ce03b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1fa4df85_9b586388","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":27},"updated":"2020-03-06 07:07:30.000000000","message":"Is the additional \u0027s\u0027 intentional?","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1fa4df85_f0e88e7c","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":27},"in_reply_to":"1fa4df85_9b586388","updated":"2020-03-06 15:06:01.000000000","message":"++, let\u0027s keep in singular","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1fa4df85_775a2f83","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":27},"in_reply_to":"1fa4df85_f0e88e7c","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f7ad97ce68990b815afe0337b076cb50c12fa7b6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"1fa4df85_06a37c02","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"updated":"2020-03-11 09:28:42.000000000","message":"s/managers/manager","commit_id":"909909911becaccac22c944862f9528dfdca447c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"183f4721dea4ff8cfe9040aff5e9a79331c5c5aa","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_8a3519ab","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"updated":"2020-03-12 07:15:08.000000000","message":"let\u0027s not change the name of the entry point","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"81dcbaa4434c915c2ee878971268d8a495b78102","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_feb6ce3e","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"in_reply_to":"1fa4df85_8a3519ab","updated":"2020-03-12 10:06:08.000000000","message":"you mean to keep it in plural, managers!\n\nIn my opinion, manager and system inventory show commands should be the same, I mean either the both in plural or singular because it may be tricky for the user to memorize.","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1ed40890bf39e4173e8a85392f0621c7a89dd8c9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_cd87a661","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"in_reply_to":"1fa4df85_929c6b5e","updated":"2020-03-12 14:21:48.000000000","message":"why in a separate patch? just don\u0027t change it, it\u0027s singular at the origin :)","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c1569468598c113aa39c5a3f36a86eefb8a81023","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_cdb9e1e9","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"in_reply_to":"1fa4df85_cd87a661","updated":"2020-03-12 17:56:51.000000000","message":"Ah, right! I somehow thought it\u0027s the managers -\u003e manager change.\n\nWe should leave it singular indeed. Chassis is the only exception so far because English.\n\nSorry for confusion!","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_444b83af","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"in_reply_to":"1fa4df85_cdb9e1e9","updated":"2020-03-13 13:01:52.000000000","message":"yes! I was having the same confusion too! :D\nI don\u0027t even remember from where came that s, probably typo error! Sorry for that","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_929c6b5e","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"in_reply_to":"1fa4df85_e150730d","updated":"2020-03-12 13:49:27.000000000","message":"Done","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    manager_vmedia_eject \u003d sushycli.manager_vmedia:ManagerVmediaEject"},{"line_number":33,"context_line":"    manager_vmedia_list \u003d sushycli.manager_vmedia:ManagerVmediaList"},{"line_number":34,"context_line":"    manager_list \u003d sushycli.manager_list:ManagerList"},{"line_number":35,"context_line":"    managers_inventory_show \u003d sushycli.manager_inventory:ManagerInventoryShow"},{"line_number":36,"context_line":"    system_bios_show \u003d sushycli.system_bios:SystemBiosShow"},{"line_number":37,"context_line":"    system_bios_reset \u003d sushycli.system_bios:SystemBiosReset"},{"line_number":38,"context_line":"    system_bios_set \u003d sushycli.system_bios:SystemBiosSet"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1fa4df85_e150730d","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":12},"in_reply_to":"1fa4df85_feb6ce3e","updated":"2020-03-12 10:14:41.000000000","message":"I think we should have it singular, but do it in a separate patch..","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"}],"sushycli/system_bios.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"174e5843e63f6c26655a5610f9e1f428795f5533","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def take_action(self, args):"},{"line_number":25,"context_line":"        \"\"\"System BIOS show command action."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":28,"context_line":"        come from the user"},{"line_number":29,"context_line":"        :returns: CLI process exit code"},{"line_number":30,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b74f4769","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":61},"updated":"2020-03-10 08:56:21.000000000","message":"attribute-value ?","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def take_action(self, args):"},{"line_number":25,"context_line":"        \"\"\"System BIOS show command action."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":28,"context_line":"        come from the user"},{"line_number":29,"context_line":"        :returns: CLI process exit code"},{"line_number":30,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d7e203d5","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":61},"in_reply_to":"1fa4df85_b74f4769","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e9f9bb92f700de3f4fba479cf068ca4fc64ce03b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":28,"context_line":"        come from the user"},{"line_number":29,"context_line":"        :returns: CLI process exit code"},{"line_number":30,"context_line":"        \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        root \u003d super(SystemBiosShow, self).take_action(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_3bcdaf30","line":29,"range":{"start_line":29,"start_character":1,"end_line":29,"end_character":39},"updated":"2020-03-06 07:07:30.000000000","message":"This seems not correct.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"ab87c48db3ce1dec0c858a89105c99914c14de07","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":28,"context_line":"        come from the user"},{"line_number":29,"context_line":"        :returns: CLI process exit code"},{"line_number":30,"context_line":"        \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        root \u003d super(SystemBiosShow, self).take_action(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f35df346","line":29,"range":{"start_line":29,"start_character":1,"end_line":29,"end_character":39},"in_reply_to":"1fa4df85_3bcdaf30","updated":"2020-03-09 18:24:54.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        root \u003d super(SystemBiosShow, self).take_action(args)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":"        attributes \u003d \u0027\\n\u0027.join("},{"line_number":36,"context_line":"            \u0027{} : {}\u0027.format(key, value)"},{"line_number":37,"context_line":"            for key, value in sys_inst.bios.attributes.items()"},{"line_number":38,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f0440e76","line":35,"updated":"2020-03-06 15:06:01.000000000","message":"May be we should not merge anything.\n\nIf we would pass each attribute/value separately as table cells, then we could leverage cliff\u0027s output formatting features (e.g. csv, JSON).\n\nMay be something like:\n\n    [`BIOS attribute\u0027, \u0027BIOS value\u0027]","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        root \u003d super(SystemBiosShow, self).take_action(args)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":"        attributes \u003d \u0027\\n\u0027.join("},{"line_number":36,"context_line":"            \u0027{} : {}\u0027.format(key, value)"},{"line_number":37,"context_line":"            for key, value in sys_inst.bios.attributes.items()"},{"line_number":38,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b7df470b","line":35,"in_reply_to":"1fa4df85_f0440e76","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":"        attributes \u003d \u0027\\n\u0027.join("},{"line_number":36,"context_line":"            \u0027{} : {}\u0027.format(key, value)"},{"line_number":37,"context_line":"            for key, value in sys_inst.bios.attributes.items()"},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_90a59a49","line":36,"updated":"2020-03-06 15:06:01.000000000","message":"nit: space before \u0027:\u0027","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":"        attributes \u003d \u0027\\n\u0027.join("},{"line_number":36,"context_line":"            \u0027{} : {}\u0027.format(key, value)"},{"line_number":37,"context_line":"            for key, value in sys_inst.bios.attributes.items()"},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_77e54fdb","line":36,"in_reply_to":"1fa4df85_90a59a49","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"174e5843e63f6c26655a5610f9e1f428795f5533","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def take_action(self, args):"},{"line_number":47,"context_line":"        \"\"\"System BIOS reset command action."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":50,"context_line":"            come from the user"},{"line_number":51,"context_line":"        :returns: CLI process exit code"},{"line_number":52,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d7520313","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":61},"updated":"2020-03-10 08:56:21.000000000","message":"attribute-value ?","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def take_action(self, args):"},{"line_number":47,"context_line":"        \"\"\"System BIOS reset command action."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":50,"context_line":"            come from the user"},{"line_number":51,"context_line":"        :returns: CLI process exit code"},{"line_number":52,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_97e80bb3","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":61},"in_reply_to":"1fa4df85_d7520313","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e9f9bb92f700de3f4fba479cf068ca4fc64ce03b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":50,"context_line":"            come from the user"},{"line_number":51,"context_line":"        :returns: CLI process exit code"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        root \u003d super(SystemBiosReset, self).take_action(args)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_bb019f3a","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":39},"updated":"2020-03-06 07:07:30.000000000","message":"Is this correct? I haven\u0027t checked the functions that are called from here, but since the return codes are not stored, I\u0027d think this functions returns 0 unless one of the called functions raises an exception, no?","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":50,"context_line":"            come from the user"},{"line_number":51,"context_line":"        :returns: CLI process exit code"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        root \u003d super(SystemBiosReset, self).take_action(args)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_30c146e6","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":39},"in_reply_to":"1fa4df85_bb019f3a","updated":"2020-03-06 15:06:01.000000000","message":"++\n\nWith cliff, we have two kinds of CLI handlers: command and lister. The first returns a return code to indicate the outcome of the operation, the latter just prints stuff out and no return code is accepted.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":50,"context_line":"            come from the user"},{"line_number":51,"context_line":"        :returns: CLI process exit code"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        root \u003d super(SystemBiosReset, self).take_action(args)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_573cd32d","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":39},"in_reply_to":"1fa4df85_bb019f3a","updated":"2020-03-10 10:49:11.000000000","message":"\u003e ++\n \u003e \n \u003e With cliff, we have two kinds of CLI handlers: command and lister.\n \u003e The first returns a return code to indicate the outcome of the\n \u003e operation, the latter just prints stuff out and no return code is\n \u003e accepted.\n\nYes, in this RESET command, we are handling with the first case.\n\nExecution of the instruction we specified in take_action method (call sushy reset method)\n\nthen a successful exit.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--attributes\u0027,"},{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a4441b48","line":79,"updated":"2020-03-06 15:06:01.000000000","message":"If we chose JSON form for input, we should make sure that sushy-cli can produce JSON that it could consume back.\n\nMay be it would be user-friendly to also support a simpler mechanism like:\n\n    sushycli bios set BootMode\u003dBios\n\n?","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"ab87c48db3ce1dec0c858a89105c99914c14de07","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--attributes\u0027,"},{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f3f5dc57","line":79,"in_reply_to":"1fa4df85_a4441b48","updated":"2020-03-09 18:24:54.000000000","message":"++\n\nYes, and since the list of BIOS attributes is dynamic and specific to a manufacturer or provider, so we would let the user enter both the \"key\" and \"value\" as an argument (like it is implemented in Sushy library method..)\nwe have many possibilities of implementation:\n\nsushycli system bios set --key\u003dBootMode --value\u003dBios\n\nor what you suggest \n\nsushycli system bios set BootMode\u003dBios\n\nalso, in case of many attributes, we can change the command as so:\n\nsushycli system bios set BootMode\u003dBios EmbeddedSata\u003dRaid ..\n\ninstead of\n\nsushycli system bios set attributes\u003d\u0027{\u0027BootMode\u0027:\u0027Bios\u0027, \u0027EmbeddedSata\u0027:\u0027Raid\u0027...}\u0027","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--attributes\u0027,"},{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_171bbbc9","line":79,"in_reply_to":"1fa4df85_a4441b48","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \u0027--attributes\u0027,"},{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_70581e55","line":80,"updated":"2020-03-06 15:06:01.000000000","message":"Let\u0027s put spaces at the end of the line.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \u0027--attributes\u0027,"},{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_7781cfc2","line":80,"in_reply_to":"1fa4df85_70581e55","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d00b1227","line":81,"updated":"2020-03-06 15:06:01.000000000","message":"Closing quote is missing?","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            type\u003djson.loads,"},{"line_number":79,"context_line":"            help\u003d\u0027Set BIOS new attributes,\u0027"},{"line_number":80,"context_line":"                 \u0027 attributes arguments should follow JSON format;\u0027"},{"line_number":81,"context_line":"                 \u0027 example: \\\u0027{\"BootMode\": \"Bios\"}\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_376fd72b","line":81,"in_reply_to":"1fa4df85_d00b1227","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d4d10990e456558430aa44ebe5a4e6c3a8033012","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def take_action(self, args):"},{"line_number":86,"context_line":"        \"\"\"Set system BIOS command action."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":89,"context_line":"            come from the user"},{"line_number":90,"context_line":"        :returns: CLI process exit code"},{"line_number":91,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_301dc673","line":88,"updated":"2020-03-06 15:06:01.000000000","message":"option vs attribute? Let\u0027s be consistent.","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def take_action(self, args):"},{"line_number":86,"context_line":"        \"\"\"Set system BIOS command action."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":89,"context_line":"            come from the user"},{"line_number":90,"context_line":"        :returns: CLI process exit code"},{"line_number":91,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f774dfff","line":88,"in_reply_to":"1fa4df85_301dc673","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e9f9bb92f700de3f4fba479cf068ca4fc64ce03b","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":89,"context_line":"            come from the user"},{"line_number":90,"context_line":"        :returns: CLI process exit code"},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        root \u003d super(SystemBiosSet, self).take_action(args)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_5bfc2b3d","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":39},"updated":"2020-03-06 07:07:30.000000000","message":"ditto","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"27e30a8dcd951e1835e82671c23cb68ab45463aa","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        :param args: a namespace of command-line option-value pairs that"},{"line_number":89,"context_line":"            come from the user"},{"line_number":90,"context_line":"        :returns: CLI process exit code"},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        root \u003d super(SystemBiosSet, self).take_action(args)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_17709b07","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":39},"in_reply_to":"1fa4df85_5bfc2b3d","updated":"2020-03-10 10:49:11.000000000","message":"Done","commit_id":"fa487eca34ee73d604b6fcefe7e3285e85e3bfa3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SystemBiosShow(base_system.BaseLister):"},{"line_number":23,"context_line":"    \"\"\"Show machine BIOS attributes\"\"\""},{"line_number":24,"context_line":"    def take_action(self, args):"},{"line_number":25,"context_line":"        \"\"\"System BIOS show command action."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_613c83bf","line":23,"updated":"2020-03-12 10:14:41.000000000","message":"Does PEP8 suggest to have titles terminated with a dot?","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SystemBiosShow(base_system.BaseLister):"},{"line_number":23,"context_line":"    \"\"\"Show machine BIOS attributes\"\"\""},{"line_number":24,"context_line":"    def take_action(self, args):"},{"line_number":25,"context_line":"        \"\"\"System BIOS show command action."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f550170d","line":23,"in_reply_to":"1fa4df85_613c83bf","updated":"2020-03-13 13:01:52.000000000","message":"Done","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"\"\"System BIOS show command action."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param args: a namespace of command-line attribute-value pairs that"},{"line_number":28,"context_line":"        come from the user"},{"line_number":29,"context_line":"        :returns: columns, values of data to be listed."},{"line_number":30,"context_line":"        \"\"\""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_616563e1","line":28,"updated":"2020-03-12 10:14:41.000000000","message":"should be indented","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"\"\"System BIOS show command action."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param args: a namespace of command-line attribute-value pairs that"},{"line_number":28,"context_line":"        come from the user"},{"line_number":29,"context_line":"        :returns: columns, values of data to be listed."},{"line_number":30,"context_line":"        \"\"\""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f44d8fc4","line":28,"in_reply_to":"1fa4df85_616563e1","updated":"2020-03-12 13:49:27.000000000","message":"Done","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # Convert the list of Tuples of attributes.items into list"},{"line_number":37,"context_line":"        attrblist \u003d list(sum(sys_inst.bios.attributes.items(), ()))"},{"line_number":38,"context_line":"        # Split list by even and odd elements"},{"line_number":39,"context_line":"        keys \u003d \u0027\\n\u0027.join(attrblist[::2])"},{"line_number":40,"context_line":"        values \u003d \u0027\\n\u0027.join(attrblist[1::2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_01b7cf3c","line":37,"updated":"2020-03-12 10:14:41.000000000","message":"\u0027list\u0027 is not necessary here, but I do not quite understand the whole purpose of this line","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # Convert the list of Tuples of attributes.items into list"},{"line_number":37,"context_line":"        attrblist \u003d list(sum(sys_inst.bios.attributes.items(), ()))"},{"line_number":38,"context_line":"        # Split list by even and odd elements"},{"line_number":39,"context_line":"        keys \u003d \u0027\\n\u0027.join(attrblist[::2])"},{"line_number":40,"context_line":"        values \u003d \u0027\\n\u0027.join(attrblist[1::2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_5737c5e4","line":37,"in_reply_to":"1fa4df85_01b7cf3c","updated":"2020-03-12 13:49:27.000000000","message":"since attributes.items() returns a list of tuples like [(\u0027BootMode\u0027, \u0027Bios\u0027), ...]\nand in order to show the result as this format:\n\n |\u0027BIOS attribute\u0027| \u0027BIOS value\u0027|\n\nthe idea was to:\n1)Convert the list of tuples into a list\n2)extract keys then values from that list\nthe join was used just to get a clear print\n\nSo yeah, let\u0027s not Over-formatting...\nrendering attributes.items() directly is a wise idea! thanks!","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c1569468598c113aa39c5a3f36a86eefb8a81023","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # Convert the list of Tuples of attributes.items into list"},{"line_number":37,"context_line":"        attrblist \u003d list(sum(sys_inst.bios.attributes.items(), ()))"},{"line_number":38,"context_line":"        # Split list by even and odd elements"},{"line_number":39,"context_line":"        keys \u003d \u0027\\n\u0027.join(attrblist[::2])"},{"line_number":40,"context_line":"        values \u003d \u0027\\n\u0027.join(attrblist[1::2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_6d930d5e","line":37,"in_reply_to":"1fa4df85_5737c5e4","updated":"2020-03-12 17:56:51.000000000","message":"Look, with `-f` option JSON document looks quite weird:\n\n  [\n    {\n      \"BIOS attribute\": \"AcPwrRcvry\",\n      \"BIOS value\": \"Last\"\n    },\n    {\n      \"BIOS attribute\": \"AcPwrRcvryDelay\",\n      \"BIOS value\": \"Immediate\"\n    },\n\nIs it the same format that sushycli is bound to accept?\n\nI\u0027d better have it like:\n\n  [\n    {\n    \"AcPwrRcvry\": \"Last\"\n    },\n    {\n      \"AcPwrRcvryDelay\": \"Immediate\"\n    },\n\nNot sure if we can make cliff formatting things nicely in both table and JSON forms... WDYT?","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        sys_inst \u003d root.get_system(args.system_id)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # Convert the list of Tuples of attributes.items into list"},{"line_number":37,"context_line":"        attrblist \u003d list(sum(sys_inst.bios.attributes.items(), ()))"},{"line_number":38,"context_line":"        # Split list by even and odd elements"},{"line_number":39,"context_line":"        keys \u003d \u0027\\n\u0027.join(attrblist[::2])"},{"line_number":40,"context_line":"        values \u003d \u0027\\n\u0027.join(attrblist[1::2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_b50cdf3b","line":37,"in_reply_to":"1fa4df85_6d930d5e","updated":"2020-03-13 13:01:52.000000000","message":"I think it is possible if we inherit from \"ShowOne\" base Class instead of \"Lister\" Class, according to OpenStack documentation :)\nand this way we can also have the same nice formatting in table format. \n DYT it is better to try with ShowOn?","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Convert the list of Tuples of attributes.items into list"},{"line_number":37,"context_line":"        attrblist \u003d list(sum(sys_inst.bios.attributes.items(), ()))"},{"line_number":38,"context_line":"        # Split list by even and odd elements"},{"line_number":39,"context_line":"        keys \u003d \u0027\\n\u0027.join(attrblist[::2])"},{"line_number":40,"context_line":"        values \u003d \u0027\\n\u0027.join(attrblist[1::2])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        return [\u0027BIOS attribute\u0027, \u0027BIOS value\u0027], [[keys, values]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_81f17f04","line":39,"updated":"2020-03-12 10:14:41.000000000","message":"Do we need to do these `join` calls at all? Intuitively, we should pass av pairs as-is to cliff so that it could format them as the user wants (e.g. csv, json)","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Convert the list of Tuples of attributes.items into list"},{"line_number":37,"context_line":"        attrblist \u003d list(sum(sys_inst.bios.attributes.items(), ()))"},{"line_number":38,"context_line":"        # Split list by even and odd elements"},{"line_number":39,"context_line":"        keys \u003d \u0027\\n\u0027.join(attrblist[::2])"},{"line_number":40,"context_line":"        values \u003d \u0027\\n\u0027.join(attrblist[1::2])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        return [\u0027BIOS attribute\u0027, \u0027BIOS value\u0027], [[keys, values]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_77b441f3","line":39,"in_reply_to":"1fa4df85_81f17f04","updated":"2020-03-12 13:49:27.000000000","message":"right!\nso we don\u0027t even need to convert it in a list!","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\"Update the system BIOS attribute(s)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    This command allows to update BIOS attributes, On the command"},{"line_number":68,"context_line":"     line, a declaration should typically be a number of key-value"},{"line_number":69,"context_line":"     pairs, example:"},{"line_number":70,"context_line":"        foo\u003dhello."},{"line_number":71,"context_line":"    or"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_a1f6fbf8","line":68,"updated":"2020-03-12 10:14:41.000000000","message":"indentation problems","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\"Update the system BIOS attribute(s)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    This command allows to update BIOS attributes, On the command"},{"line_number":68,"context_line":"     line, a declaration should typically be a number of key-value"},{"line_number":69,"context_line":"     pairs, example:"},{"line_number":70,"context_line":"        foo\u003dhello."},{"line_number":71,"context_line":"    or"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_97b9bdea","line":68,"in_reply_to":"1fa4df85_a1f6fbf8","updated":"2020-03-12 13:49:27.000000000","message":"Done","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    This command allows to update BIOS attributes, On the command"},{"line_number":68,"context_line":"     line, a declaration should typically be a number of key-value"},{"line_number":69,"context_line":"     pairs, example:"},{"line_number":70,"context_line":"        foo\u003dhello."},{"line_number":71,"context_line":"    or"},{"line_number":72,"context_line":"        foo\u003d\"hello\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_61d8037f","line":69,"updated":"2020-03-12 10:14:41.000000000","message":"may be this should go into some \"examples\" section if possible with Sphinx markup?","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    This command allows to update BIOS attributes, On the command"},{"line_number":68,"context_line":"     line, a declaration should typically be a number of key-value"},{"line_number":69,"context_line":"     pairs, example:"},{"line_number":70,"context_line":"        foo\u003dhello."},{"line_number":71,"context_line":"    or"},{"line_number":72,"context_line":"        foo\u003d\"hello\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_52e27303","line":69,"in_reply_to":"1fa4df85_61d8037f","updated":"2020-03-12 13:49:27.000000000","message":"thanks for this remark!","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    or"},{"line_number":72,"context_line":"        foo\u003d\"hello\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    Note: attributes update is not immediate but requires system restart."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_41c4e792","line":74,"updated":"2020-03-12 10:14:41.000000000","message":"may be we can have a Notes section?","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    or"},{"line_number":72,"context_line":"        foo\u003d\"hello\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    Note: attributes update is not immediate but requires system restart."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_f2eeffeb","line":74,"in_reply_to":"1fa4df85_41c4e792","updated":"2020-03-12 13:49:27.000000000","message":"Done","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a4f5c6a5aa7b7f41e8f1dd8c71afa175e89c3f86","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            metavar\u003d\"KEY\u003dVALUE\","},{"line_number":89,"context_line":"            action\u003dParseDict,"},{"line_number":90,"context_line":"            help\u003d\u0027Set BIOS attributes, Note that you should not\u0027"},{"line_number":91,"context_line":"                 \u0027 put spaces before or after the \u003d sign.\\n\u0027"},{"line_number":92,"context_line":"                 \u0027If a value contains spaces, you should define\u0027"},{"line_number":93,"context_line":"                 \u0027 it with double quotes, for example:\\n \u0027"},{"line_number":94,"context_line":"                 \u0027foo\u003d\"this is a sentence\".\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_01beeffe","line":91,"updated":"2020-03-12 10:14:41.000000000","message":"spaces should be at the tail of the string","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"f1be7f4b4232f885d8f45058613c4c806ab8f906","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            metavar\u003d\"KEY\u003dVALUE\","},{"line_number":89,"context_line":"            action\u003dParseDict,"},{"line_number":90,"context_line":"            help\u003d\u0027Set BIOS attributes, Note that you should not\u0027"},{"line_number":91,"context_line":"                 \u0027 put spaces before or after the \u003d sign.\\n\u0027"},{"line_number":92,"context_line":"                 \u0027If a value contains spaces, you should define\u0027"},{"line_number":93,"context_line":"                 \u0027 it with double quotes, for example:\\n \u0027"},{"line_number":94,"context_line":"                 \u0027foo\u003d\"this is a sentence\".\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_32ced783","line":91,"in_reply_to":"1fa4df85_01beeffe","updated":"2020-03-12 13:49:27.000000000","message":"Done","commit_id":"fe38b05c4e28dc08b566be76290ab36171a99cff"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1ed40890bf39e4173e8a85392f0621c7a89dd8c9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        if values:"},{"line_number":114,"context_line":"            for item in values:"},{"line_number":115,"context_line":"                split_items \u003d item.split(\"\u003d\", 1)"},{"line_number":116,"context_line":"                key \u003d split_items["},{"line_number":117,"context_line":"                    0"},{"line_number":118,"context_line":"                ].strip()  # we remove blanks around keys"},{"line_number":119,"context_line":"                value \u003d split_items[1]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"                d[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_0d693e8a","line":118,"range":{"start_line":116,"start_character":16,"end_line":118,"end_character":57},"updated":"2020-03-12 14:21:48.000000000","message":"maybe put the comment before the command and the command on one line ?","commit_id":"363d5178b6f51423d4cbaea2f85aa69bff32d49f"},{"author":{"_account_id":31182,"name":"khansa","email":"khansa.amrouni@gmail.com","username":"khansa"},"change_message_id":"49175215ae69226a4860b4c56486beae1b991c31","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        if values:"},{"line_number":114,"context_line":"            for item in values:"},{"line_number":115,"context_line":"                split_items \u003d item.split(\"\u003d\", 1)"},{"line_number":116,"context_line":"                key \u003d split_items["},{"line_number":117,"context_line":"                    0"},{"line_number":118,"context_line":"                ].strip()  # we remove blanks around keys"},{"line_number":119,"context_line":"                value \u003d split_items[1]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"                d[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_6d123265","line":118,"range":{"start_line":116,"start_character":16,"end_line":118,"end_character":57},"in_reply_to":"1fa4df85_0d693e8a","updated":"2020-03-13 13:01:52.000000000","message":"Done","commit_id":"363d5178b6f51423d4cbaea2f85aa69bff32d49f"}],"sushycli/tests/unit/cmd/test_sushycli.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bc38154eea985233f04bf81eee0312762656d86e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                \"ProcTurboMode\": \"Enabled\""},{"line_number":294,"context_line":"            }"},{"line_number":295,"context_line":"        )"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_system_boot_set(self, mock_sushy):"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        main([\u0027system\u0027, \u0027boot\u0027, \u0027set\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_81a52407","line":296,"updated":"2020-03-26 11:32:52.000000000","message":"We should have a test that would cover the need for double quotes and also one to cover the part from ParseDict \"# we remove blanks around keys\"","commit_id":"1d1157dac8ff7ed510e2b973c0c2c238dbc9e80b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3adec3d063db65a835e3ccc11c98b36e2557a568","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                \"ProcTurboMode\": \"Enabled\""},{"line_number":294,"context_line":"            }"},{"line_number":295,"context_line":"        )"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_system_boot_set(self, mock_sushy):"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        main([\u0027system\u0027, \u0027boot\u0027, \u0027set\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_663751b2","line":296,"in_reply_to":"df33271e_81a52407","updated":"2020-03-26 14:55:06.000000000","message":"I went ahead and added the \"# we remove blanks around keys\" test.\n\nHowever the \"double quotes\" feature seems to be all about UNIX shell behavior, this tool has no special handling of quoted values.","commit_id":"1d1157dac8ff7ed510e2b973c0c2c238dbc9e80b"}]}