)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-02-27 13:19:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":"Added code for exporting system configuration,"},{"line_number":9,"context_line":"It exports system configuration based on the specified target"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_89e3b8a4","line":8,"updated":"2020-04-06 10:16:20.000000000","message":"nit: new line","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-02-27 13:19:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":"Added code for exporting system configuration,"},{"line_number":9,"context_line":"It exports system configuration based on the specified target"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_c9ee608a","line":8,"range":{"start_line":8,"start_character":45,"end_line":8,"end_character":46},"updated":"2020-04-06 10:16:20.000000000","message":"nit: period.","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-02-27 13:19:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":"Added code for exporting system configuration,"},{"line_number":9,"context_line":"It exports system configuration based on the specified target"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_2fa191aa","line":8,"in_reply_to":"df33271e_89e3b8a4","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-02-27 13:19:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":"Added code for exporting system configuration,"},{"line_number":9,"context_line":"It exports system configuration based on the specified target"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_0fa48db8","line":8,"range":{"start_line":8,"start_character":45,"end_line":8,"end_character":46},"in_reply_to":"df33271e_c9ee608a","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard G. Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-22 18:25:05 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added code for exporting system configuration."},{"line_number":10,"context_line":"It exports system configuration based on the specified target."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_acc10051","line":7,"updated":"2020-09-22 20:00:33.000000000","message":"Could we indicate that this adds this feature?\n\n    Add export system configuration","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard G. Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-22 18:25:05 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added code for exporting system configuration."},{"line_number":10,"context_line":"It exports system configuration based on the specified target."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_28a3ce9c","line":7,"in_reply_to":"9f560f44_acc10051","updated":"2020-09-25 19:54:14.000000000","message":"Done","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added code for exporting system configuration."},{"line_number":10,"context_line":"It exports system configuration based on the specified target."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_ac6f405e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":62},"updated":"2020-09-22 20:00:33.000000000","message":"I have a couple of suggestions:\n\nLet us describe export system configuration as a Dell EMC iDRAC OEM action.\nHow about defining or describing target? Presently, I have no idea what it is referring to.","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added code for exporting system configuration."},{"line_number":10,"context_line":"It exports system configuration based on the specified target."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_88b77ad8","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":62},"in_reply_to":"9f560f44_ac6f405e","updated":"2020-09-25 19:54:14.000000000","message":"Done","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard G. Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-22 18:25:05 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Export System Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added code for exporting system configuration."},{"line_number":10,"context_line":"It exports system configuration based on the specified target."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia7db0223d72566cf4a4d013a35ef2782f273695f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_cca714a8","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":52},"updated":"2020-09-22 20:00:33.000000000","message":"I recommend the following resources for writing quality Git commit messages, in priority order, with the first one having the highest priority.\n\n1. https://wiki.openstack.org/wiki/GitCommitMessages\n2. https://chris.beams.io/posts/git-commit/#imperative","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"}],"sushy_oem_idrac/__init__.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f651530ac88fc9f707c968c309818d9d7d5c27e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_d9fe1dae","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":24},"updated":"2020-10-01 09:10:22.000000000","message":"company name and year incorrect","commit_id":"7dfca9c39d1019ca2d08ba7049f377d8d2d0c11e"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from sushy_oem_idrac.resources.manager.constants import *  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"556ea96e_a3823d70","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":65},"updated":"2021-03-11 13:47:02.000000000","message":"don\u0027t include for now - leave the file empty as before (revert)","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from sushy_oem_idrac.resources.manager.constants import *  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"0da1d75f_fd446164","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":65},"in_reply_to":"556ea96e_a3823d70","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"}],"sushy_oem_idrac/resources/common.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02bbcd090c99e24cf48709e1dfdbad29da2f254d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"89d0ca43_d4a3c478","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2021-03-12 13:27:35.000000000","message":"2020-2021","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"d2c8e63bd030c86120fb573bd495b491cba02199","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"be765118_1f63908d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"89d0ca43_d4a3c478","updated":"2021-03-12 13:50:13.000000000","message":"Done","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"}],"sushy_oem_idrac/resources/constants.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f651530ac88fc9f707c968c309818d9d7d5c27e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries.\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain\r"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_b91409eb","line":1,"updated":"2020-10-01 09:10:22.000000000","message":"maybe in the end this file is not necessary. In given example in sushy there are high level constants that are shared among many resources where under resource folder (e.g., management) there were resource-specific constants. In this case these constants are not generic to be used in different resources, in the end there should be management constants like EXPORT_ALL_CONFIG used and exposed. @Richard can you clarify?","commit_id":"7dfca9c39d1019ca2d08ba7049f377d8d2d0c11e"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"155e0afc2a7764bafc7dc9d1aa91499ab6b7b66d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"EXPORT_BIOS \u003d \u0027BIOS\u0027"},{"line_number":21,"context_line":"\"\"\"Export BIOS related configuration\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXPORT_IDRAC \u003d \u0027IDRAC\u0027"},{"line_number":24,"context_line":"\"\"\"Export IDRAC related configuration\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"EXPORT_NIC \u003d \u0027NIC\u0027"},{"line_number":27,"context_line":"\"\"\"Export NIC related configuration\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"93c145a2_4b8a87d3","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":40},"updated":"2021-02-15 20:36:52.000000000","message":"This is Dell specific, while all others are vendor independent.\nSuggest we break them into vendor independent and vendor dependent categories.\nAnd define rules on how to add vendor dependent exports.","commit_id":"8f46ad99c9c1a70e31e8699754be311b9059e7c5"}],"sushy_oem_idrac/resources/manager/constants.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"155e0afc2a7764bafc7dc9d1aa91499ab6b7b66d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"EXPORT_BIOS_CONFIG \u003d res_cons.EXPORT_BIOS"},{"line_number":23,"context_line":"\"\"\"Export BIOS related configuration\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"EXPORT_IDRAC_CONFIG \u003d res_cons.EXPORT_IDRAC"},{"line_number":26,"context_line":"\"\"\"Export IDRAC related configuration\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"EXPORT_NIC_CONFIG \u003d res_cons.EXPORT_NIC"},{"line_number":29,"context_line":"\"\"\"Export NIC related configuration\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3cf0b1a3_2172d2df","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":40},"updated":"2021-02-15 20:36:52.000000000","message":"ditto","commit_id":"8f46ad99c9c1a70e31e8699754be311b9059e7c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"2aa3744a_7ecc804a","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":20},"updated":"2021-03-11 13:47:02.000000000","message":"2020-2021 in other files too","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"5e5549a2_222c8ea0","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":20},"in_reply_to":"2aa3744a_7ecc804a","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# export system config action constants"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"EXPORT_ALL_CONFIG \u003d \u0027ALL\u0027"},{"line_number":18,"context_line":"\"\"\"Export entire system configuration\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"EXPORT_BIOS_CONFIG \u003d \u0027BIOS\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"6ad3c960_0398dc5f","line":17,"range":{"start_line":17,"start_character":21,"end_line":17,"end_character":24},"updated":"2021-03-11 13:47:02.000000000","message":"lower case \u0027all\u0027","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# export system config action constants"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"EXPORT_ALL_CONFIG \u003d \u0027ALL\u0027"},{"line_number":18,"context_line":"\"\"\"Export entire system configuration\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"EXPORT_BIOS_CONFIG \u003d \u0027BIOS\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"6e0cc7bb_b1d60afe","line":17,"range":{"start_line":17,"start_character":21,"end_line":17,"end_character":24},"in_reply_to":"6ad3c960_0398dc5f","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":20,"context_line":"EXPORT_BIOS_CONFIG \u003d \u0027BIOS\u0027"},{"line_number":21,"context_line":"\"\"\"Export BIOS related configuration\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXPORT_IDRAC_CONFIG \u003d \u0027IDRAC\u0027"},{"line_number":24,"context_line":"\"\"\"Export IDRAC related configuration\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"EXPORT_NIC_CONFIG \u003d \u0027NIC\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"f3c01f9e_d45606a3","line":23,"range":{"start_line":23,"start_character":23,"end_line":23,"end_character":28},"updated":"2021-03-11 13:47:02.000000000","message":"casing - \u0027iDRAC\u0027","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"EXPORT_BIOS_CONFIG \u003d \u0027BIOS\u0027"},{"line_number":21,"context_line":"\"\"\"Export BIOS related configuration\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXPORT_IDRAC_CONFIG \u003d \u0027IDRAC\u0027"},{"line_number":24,"context_line":"\"\"\"Export IDRAC related configuration\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"EXPORT_NIC_CONFIG \u003d \u0027NIC\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"770906e2_28adbe64","line":23,"range":{"start_line":23,"start_character":23,"end_line":23,"end_character":28},"in_reply_to":"f3c01f9e_d45606a3","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"}],"sushy_oem_idrac/resources/manager/manager.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                attempts -\u003d 1"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def export_system_configuration(self, target):"},{"line_number":182,"context_line":"        \"\"\"Export system configuration"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param target: To export all or particular component"},{"line_number":185,"context_line":"                       configuration of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_897f38aa","line":182,"updated":"2020-04-06 10:16:20.000000000","message":"nit: period","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                attempts -\u003d 1"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def export_system_configuration(self, target):"},{"line_number":182,"context_line":"        \"\"\"Export system configuration"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param target: To export all or particular component"},{"line_number":185,"context_line":"                       configuration of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_9fb473d3","line":182,"in_reply_to":"df33271e_897f38aa","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def export_system_configuration(self, target):"},{"line_number":182,"context_line":"        \"\"\"Export system configuration"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param target: To export all or particular component"},{"line_number":185,"context_line":"                       configuration of system"},{"line_number":186,"context_line":"            supported values are { ALL, System, BIOS, IDRAC, NIC, FC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3cf74cd7","line":183,"updated":"2020-04-06 10:16:20.000000000","message":"Let\u0027s explain what this \"export\" operation does and why is it needed. Reading the code I got no clue.","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def export_system_configuration(self, target):"},{"line_number":182,"context_line":"        \"\"\"Export system configuration"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param target: To export all or particular component"},{"line_number":185,"context_line":"                       configuration of system"},{"line_number":186,"context_line":"            supported values are { ALL, System, BIOS, IDRAC, NIC, FC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_42bfb0fa","line":183,"in_reply_to":"df33271e_3cf74cd7","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param target: To export all or particular component"},{"line_number":185,"context_line":"                       configuration of system"},{"line_number":186,"context_line":"            supported values are { ALL, System, BIOS, IDRAC, NIC, FC,"},{"line_number":187,"context_line":"                                  LifecycleController, RAID}"},{"line_number":188,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":189,"context_line":"            be used."}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c9930000","line":186,"updated":"2020-04-06 10:16:20.000000000","message":"nit: malformed formatting","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param target: To export all or particular component"},{"line_number":185,"context_line":"                       configuration of system"},{"line_number":186,"context_line":"            supported values are { ALL, System, BIOS, IDRAC, NIC, FC,"},{"line_number":187,"context_line":"                                  LifecycleController, RAID}"},{"line_number":188,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":189,"context_line":"            be used."}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_e26364dc","line":186,"in_reply_to":"df33271e_c9930000","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                       configuration of system"},{"line_number":186,"context_line":"            supported values are { ALL, System, BIOS, IDRAC, NIC, FC,"},{"line_number":187,"context_line":"                                  LifecycleController, RAID}"},{"line_number":188,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":189,"context_line":"            be used."},{"line_number":190,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":191,"context_line":"            operation"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3c68ecb8","line":188,"updated":"2020-04-06 10:16:20.000000000","message":"`response` is missing","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                       configuration of system"},{"line_number":186,"context_line":"            supported values are { ALL, System, BIOS, IDRAC, NIC, FC,"},{"line_number":187,"context_line":"                                  LifecycleController, RAID}"},{"line_number":188,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":189,"context_line":"            be used."},{"line_number":190,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":191,"context_line":"            operation"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_bfd057cb","line":188,"in_reply_to":"df33271e_3c68ecb8","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":191,"context_line":"            operation"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        action_data \u003d dict(ShareParameters\u003d{\u0027Target\u0027: target},"},{"line_number":194,"context_line":"                           ExportFormat\u003d\"XML\")"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            response \u003d asynchronous.http_call("}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5cb4d035","line":193,"updated":"2020-04-06 10:16:20.000000000","message":"Why not dict literal?\n\n{\n  \u0027ShareParameters\u0027:\n    {\n    ..\n    }\n}","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":191,"context_line":"            operation"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        action_data \u003d dict(ShareParameters\u003d{\u0027Target\u0027: target},"},{"line_number":194,"context_line":"                           ExportFormat\u003d\"XML\")"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            response \u003d asynchronous.http_call("}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_9fa7530c","line":193,"in_reply_to":"df33271e_5cb4d035","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1a55371f3de7ad8ade0b903ec3feb814bdaa9666","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                self._conn,"},{"line_number":198,"context_line":"                \u0027post\u0027,"},{"line_number":199,"context_line":"                self.export_system_configuration_uri,"},{"line_number":200,"context_line":"                data\u003daction_data)"},{"line_number":201,"context_line":"            return response"},{"line_number":202,"context_line":"        except (sushy.exceptions.ServerSideError,"},{"line_number":203,"context_line":"                sushy.exceptions.BadRequestError) as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5cfe90ae","line":200,"updated":"2020-04-06 10:16:20.000000000","message":"Should we have some log message confirming the outcome of this operation?","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"fa4c30962bc236d4c329ed1e702267d35e1cd620","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                self._conn,"},{"line_number":198,"context_line":"                \u0027post\u0027,"},{"line_number":199,"context_line":"                self.export_system_configuration_uri,"},{"line_number":200,"context_line":"                data\u003daction_data)"},{"line_number":201,"context_line":"            return response"},{"line_number":202,"context_line":"        except (sushy.exceptions.ServerSideError,"},{"line_number":203,"context_line":"                sushy.exceptions.BadRequestError) as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5f082b90","line":200,"in_reply_to":"df33271e_5cfe90ae","updated":"2020-04-08 09:07:20.000000000","message":"Done","commit_id":"85991b37ac71a796a9fbc82252a269d825f6e947"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a9dc0c061b59639623ac9db2ac092d4c6fa36f6c","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"                       configuration of system"},{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_778ceb7e","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":60},"updated":"2020-04-27 11:02:08.000000000","message":"Can input value be validated before it makes the call?\nOr will it raise error if invalid option provided? What type of error?","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a9dc0c061b59639623ac9db2ac092d4c6fa36f6c","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"                       configuration of system"},{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_b734b394","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":60},"updated":"2020-04-27 11:02:08.000000000","message":"Should these be pre-defined or based on actual values at `Target@Redfish.AllowableValues` in Redfish resource?","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"0806df651493499aaf609de1859c8536ddf8b48f","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"                       configuration of system"},{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_5e4d6d98","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":60},"in_reply_to":"1f493fa4_778ceb7e","updated":"2020-04-28 11:16:12.000000000","message":"It will raise an error if we pass an invalid option.\nError Type: BadRequestError\nBrief Error: Unable to run the method because an invalid FQDD is entered","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"6058c88c190df3e7077c4a6cd8f29fca3e29f760","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"                       configuration of system"},{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_17ce0cb3","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":60},"in_reply_to":"1f493fa4_a93efd87","updated":"2020-04-29 11:01:03.000000000","message":"Done","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"0806df651493499aaf609de1859c8536ddf8b48f","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"                       configuration of system"},{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_beaf5128","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":60},"in_reply_to":"1f493fa4_b734b394","updated":"2020-04-28 11:16:12.000000000","message":"Yes Aija, these values are based on actual values at `Target@Redfish.AllowableValues` in redfish resource.","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02131025b92308db08d970b6616e5753a580dde4","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"                       configuration of system"},{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_a93efd87","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":60},"in_reply_to":"1f493fa4_beaf5128","updated":"2020-04-28 11:41:04.000000000","message":"I guess this is not clear from the comment. The comment reads like the only options are ALL, BIOS, IDRAC, NIC, RAID, but based on the system it can be different. Maybe mention that actual values depend on the system (found in Target.AllowableValues) and give these just as an example?","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a9dc0c061b59639623ac9db2ac092d4c6fa36f6c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":194,"context_line":"            be used."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_f48599d0","line":196,"range":{"start_line":193,"start_character":0,"end_line":196,"end_character":21},"updated":"2020-04-27 11:02:08.000000000","message":"Where/When does it raise these errors?","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02131025b92308db08d970b6616e5753a580dde4","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":194,"context_line":"            be used."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_c948a92e","line":196,"range":{"start_line":193,"start_character":0,"end_line":196,"end_character":21},"in_reply_to":"1f493fa4_69007502","updated":"2020-04-28 11:41:04.000000000","message":"InvalidParameterValue - above it says that it will return BadRequestError for invalid option (target). Can it be clarified which one is returned if passing incorrect target?\n(And what happens when invalid ExportFormat is passed?)","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"6058c88c190df3e7077c4a6cd8f29fca3e29f760","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":194,"context_line":"            be used."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_57c37489","line":196,"range":{"start_line":193,"start_character":0,"end_line":196,"end_character":21},"in_reply_to":"1f493fa4_c948a92e","updated":"2020-04-29 11:01:03.000000000","message":"Done","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"0806df651493499aaf609de1859c8536ddf8b48f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            supported values are ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":191,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":192,"context_line":"            the specified target."},{"line_number":193,"context_line":"        :raises: InvalidParameterValue if Dell OEM extension can\u0027t"},{"line_number":194,"context_line":"            be used."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_69007502","line":196,"range":{"start_line":193,"start_character":0,"end_line":196,"end_character":21},"in_reply_to":"1f493fa4_f48599d0","updated":"2020-04-28 11:16:12.000000000","message":"InvalidParameterValue: We get this error when we pass an invalid target\n\nExtensionError: Will remove this error.","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a9dc0c061b59639623ac9db2ac092d4c6fa36f6c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"},{"line_number":200,"context_line":"                \u0027Target\u0027: target"},{"line_number":201,"context_line":"            },"},{"line_number":202,"context_line":"            \u0027ExportFormat\u0027: \"XML\""},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            response \u003d asynchronous.http_call("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_77306be9","line":202,"range":{"start_line":202,"start_character":29,"end_line":202,"end_character":32},"updated":"2020-04-27 11:02:08.000000000","message":"Was it requirement to hardcode this to \"XML\"? Could this be parameter based on available options?","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"21564ba573f3332e0d6426fcec33552f666ecf11","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"},{"line_number":200,"context_line":"                \u0027Target\u0027: target"},{"line_number":201,"context_line":"            },"},{"line_number":202,"context_line":"            \u0027ExportFormat\u0027: \"XML\""},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            response \u003d asynchronous.http_call("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_87f045ff","line":202,"range":{"start_line":202,"start_character":29,"end_line":202,"end_character":32},"in_reply_to":"1f493fa4_094f3134","updated":"2020-04-28 15:40:04.000000000","message":"Since it would be easy to add a parameter to support other formats such as JSON and default it to XML at some point in the future, let\u0027s leave it as-is for now.","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02131025b92308db08d970b6616e5753a580dde4","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"},{"line_number":200,"context_line":"                \u0027Target\u0027: target"},{"line_number":201,"context_line":"            },"},{"line_number":202,"context_line":"            \u0027ExportFormat\u0027: \"XML\""},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            response \u003d asynchronous.http_call("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_094f3134","line":202,"range":{"start_line":202,"start_character":29,"end_line":202,"end_character":32},"in_reply_to":"1f493fa4_694eb56f","updated":"2020-04-28 11:41:04.000000000","message":"Might be handy that Ironic defines what format it will be returned so it does not have to rely on internals of this function. Also if in future smbdy starting to need to get JSON, then Ironic wouldn\u0027t require changes to keep using XML. Just my thoughts.","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"1424a208e501a2c4389bf1d9aa4f19fcc7ca2126","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"},{"line_number":200,"context_line":"                \u0027Target\u0027: target"},{"line_number":201,"context_line":"            },"},{"line_number":202,"context_line":"            \u0027ExportFormat\u0027: \"XML\""},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            response \u003d asynchronous.http_call("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_694eb56f","line":202,"range":{"start_line":202,"start_character":29,"end_line":202,"end_character":32},"in_reply_to":"1f493fa4_77306be9","updated":"2020-04-28 11:15:51.000000000","message":"Current implementation in IRonic is based on XML lib, so let\u0027s keep it as it for now.","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a9dc0c061b59639623ac9db2ac092d4c6fa36f6c","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"            return response"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        except (sushy.exceptions.ServerSideError,"},{"line_number":217,"context_line":"                sushy.exceptions.BadRequestError) as exc:"},{"line_number":218,"context_line":"            LOG.error(\u0027Dell OEM export system configuration failed : %s\u0027, exc)"},{"line_number":219,"context_line":"            raise"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_d41b3d7e","line":217,"range":{"start_line":216,"start_character":16,"end_line":217,"end_character":48},"updated":"2020-04-27 11:02:08.000000000","message":"Should these be documented as \"raises\"?","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"1424a208e501a2c4389bf1d9aa4f19fcc7ca2126","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"            return response"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        except (sushy.exceptions.ServerSideError,"},{"line_number":217,"context_line":"                sushy.exceptions.BadRequestError) as exc:"},{"line_number":218,"context_line":"            LOG.error(\u0027Dell OEM export system configuration failed : %s\u0027, exc)"},{"line_number":219,"context_line":"            raise"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_09457143","line":217,"range":{"start_line":216,"start_character":16,"end_line":217,"end_character":48},"in_reply_to":"1f493fa4_d41b3d7e","updated":"2020-04-28 11:15:51.000000000","message":"@Mahendra - please keep BadRequestError as it doesn\u0027t need ServerSideError","commit_id":"2a2068648b1f44b19ae69437e7d1ed167ac77496"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        \"\"\"Export system configuration."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        It exports system configuration for specified target"},{"line_number":185,"context_line":"        like NIC, BIOS, RAID. Depending on this information we can"},{"line_number":186,"context_line":"        update system configuration."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"            configuration of system."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4ce2e4d5","line":186,"range":{"start_line":185,"start_character":29,"end_line":186,"end_character":36},"updated":"2020-09-22 20:00:33.000000000","message":"How is this related? Perhaps this sentence can be removed.","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        \"\"\"Export system configuration."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        It exports system configuration for specified target"},{"line_number":185,"context_line":"        like NIC, BIOS, RAID. Depending on this information we can"},{"line_number":186,"context_line":"        update system configuration."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"            configuration of system."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ab39a5f1","line":186,"range":{"start_line":185,"start_character":29,"end_line":186,"end_character":36},"in_reply_to":"9f560f44_4ce2e4d5","updated":"2020-09-25 19:54:14.000000000","message":"Done","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        like NIC, BIOS, RAID. Depending on this information we can"},{"line_number":186,"context_line":"        update system configuration."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"            configuration of system."},{"line_number":190,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":191,"context_line":"            found in Target.AllowableValues"},{"line_number":192,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ec1778a2","line":189,"range":{"start_line":188,"start_character":23,"end_line":189,"end_character":36},"updated":"2020-09-22 20:00:33.000000000","message":"Component of the system to export the configuration from. Can be the entire system.","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        like NIC, BIOS, RAID. Depending on this information we can"},{"line_number":186,"context_line":"        update system configuration."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param target: To export all or particular component"},{"line_number":189,"context_line":"            configuration of system."},{"line_number":190,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":191,"context_line":"            found in Target.AllowableValues"},{"line_number":192,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4eb45736","line":189,"range":{"start_line":188,"start_character":23,"end_line":189,"end_character":36},"in_reply_to":"9f560f44_ec1778a2","updated":"2020-09-25 19:54:14.000000000","message":"Done","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":191,"context_line":"            found in Target.AllowableValues"},{"line_number":192,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":193,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":194,"context_line":"            the specified target."},{"line_number":195,"context_line":"        :raises: BadRequestError if we pass an invalid target."},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        action_data \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_6c236806","line":194,"range":{"start_line":193,"start_character":18,"end_line":194,"end_character":33},"updated":"2020-09-22 20:00:33.000000000","message":"What is the format of the return value? Is there public, on-line documentation of it which can be referenced?","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":191,"context_line":"            found in Target.AllowableValues"},{"line_number":192,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":193,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":194,"context_line":"            the specified target."},{"line_number":195,"context_line":"        :raises: BadRequestError if we pass an invalid target."},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        action_data \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ce798782","line":194,"range":{"start_line":193,"start_character":18,"end_line":194,"end_character":33},"in_reply_to":"9f560f44_6c236806","updated":"2020-09-25 19:54:14.000000000","message":"\u003e What is the format of the return value? Is there public, on-line\n \u003e documentation of it which can be referenced?\n\nWe can specify the format of the return value to JSON or XML and we specified XML format in action_data.\nRef link: [Content No 5 A.2]\nhttps://downloads.dell.com/manuals/all-products/esuprt_solutions_int/esuprt_solutions_int_solutions_resources/dell-management-solution-resources_white-papers15_en-us.pdf","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":193,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":194,"context_line":"            the specified target."},{"line_number":195,"context_line":"        :raises: BadRequestError if we pass an invalid target."},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        action_data \u003d {"},{"line_number":198,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ac1900d2","line":195,"range":{"start_line":195,"start_character":33,"end_line":195,"end_character":46},"updated":"2020-09-22 20:00:33.000000000","message":"s/if we pass an/on/","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":193,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":194,"context_line":"            the specified target."},{"line_number":195,"context_line":"        :raises: BadRequestError if we pass an invalid target."},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        action_data \u003d {"},{"line_number":198,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_eb59dd5a","line":195,"range":{"start_line":195,"start_character":33,"end_line":195,"end_character":46},"in_reply_to":"9f560f44_ac1900d2","updated":"2020-09-25 19:54:14.000000000","message":"Done","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                \u0027Target\u0027: target"},{"line_number":200,"context_line":"            },"},{"line_number":201,"context_line":"            \u0027ExportFormat\u0027: \"XML\""},{"line_number":202,"context_line":"        }"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            response \u003d asynchronous.http_call("},{"line_number":205,"context_line":"                self._conn,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ccf8b44b","line":202,"updated":"2020-09-22 20:00:33.000000000","message":"Please add a blank line.","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"5cdb5263535e0388badcae4ec412dacb197e1c4a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                \u0027Target\u0027: target"},{"line_number":200,"context_line":"            },"},{"line_number":201,"context_line":"            \u0027ExportFormat\u0027: \"XML\""},{"line_number":202,"context_line":"        }"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            response \u003d asynchronous.http_call("},{"line_number":205,"context_line":"                self._conn,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_8b4b0185","line":202,"in_reply_to":"9f560f44_ccf8b44b","updated":"2020-09-25 19:54:14.000000000","message":"Done","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            return response"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        except (sushy.exceptions.BadRequestError) as exc:"},{"line_number":216,"context_line":"            LOG.error(\u0027Dell OEM export system configuration failed : %s\u0027, exc)"},{"line_number":217,"context_line":"            raise"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_eccad817","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":49},"updated":"2020-09-22 20:00:33.000000000","message":"I believe the parentheses are unnecessary.","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f5c3f400c646d3d4f1260968ec913863ae89e766","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"                attempts -\u003d 1"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def export_system_configuration(self, target):"},{"line_number":182,"context_line":"        \"\"\"Export system configuration."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        It exports system configuration for specified target"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d102b63d","line":181,"range":{"start_line":181,"start_character":42,"end_line":181,"end_character":48},"updated":"2020-09-27 07:27:11.000000000","message":"The values for \u0027target\u0027 should be represented by constants, instead of arbitrary string literals. There is a pattern established in sushy that I think we should follow. Please see the following:\n\nDeclaration of sushy \u0027Manager\u0027 \u0027reset()\u0027 method \u0027value\u0027 parameter value constants:\n1. Common sushy resource constants, which can be leveraged by specific resources, such as \u0027Manager\u0027: https://github.com/openstack/sushy/blob/ee85feda89026875296c0be763e045e25641d6a0/sushy/resources/constants.py#L90-L118\n2. sushy \u0027Manager\u0027 resource constants: https://github.com/openstack/sushy/blob/ee85feda89026875296c0be763e045e25641d6a0/sushy/resources/manager/constants.py#L18-L24\n3. Publication of sushy constants to code consuming sushy. Note that such consumers should not reach into the internal implementation of sushy by importing the internal modules which declare them. Instead, they can reference them like so:\n\n    sushy.RESET_MANAGER_GRACEFUL_RESTART\n\nSee https://github.com/openstack/sushy/blob/master/sushy/__init__.py\n\n\nMappings from Redfish resource reset-related action constants to sushy constants and reverse mappings of the same:\n1.Common Redfish constant mappings: https://github.com/openstack/sushy/blob/ee85feda89026875296c0be763e045e25641d6a0/sushy/resources/mappings.py#L67-L79\n2. sushy \u0027Manager\u0027 resource constant mappings: https://github.com/openstack/sushy/blob/ee85feda89026875296c0be763e045e25641d6a0/sushy/resources/manager/mappings.py#L17-L22","commit_id":"719d852b913c426a9baed5c90e729cacf8de9676"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"02e8c707385754c0aaacbc573777ef1313c894b2","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"                attempts -\u003d 1"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def export_system_configuration(self, target):"},{"line_number":182,"context_line":"        \"\"\"Export system configuration."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        It exports system configuration for specified target"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_17c53e5c","line":181,"range":{"start_line":181,"start_character":42,"end_line":181,"end_character":48},"in_reply_to":"9f560f44_d102b63d","updated":"2020-09-27 14:23:57.000000000","message":"Done","commit_id":"719d852b913c426a9baed5c90e729cacf8de9676"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f5c3f400c646d3d4f1260968ec913863ae89e766","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            the specified target."},{"line_number":194,"context_line":"        :raises: BadRequestError on invalid target."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7112ca62","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":21},"updated":"2020-09-27 07:27:11.000000000","message":"nit: Please add a period.","commit_id":"719d852b913c426a9baed5c90e729cacf8de9676"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"02e8c707385754c0aaacbc573777ef1313c894b2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            the specified target."},{"line_number":194,"context_line":"        :raises: BadRequestError on invalid target."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2c4e3995","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":21},"in_reply_to":"9f560f44_7112ca62","updated":"2020-09-27 14:23:57.000000000","message":"Done","commit_id":"719d852b913c426a9baed5c90e729cacf8de9676"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f5c3f400c646d3d4f1260968ec913863ae89e766","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        :raises: BadRequestError on invalid target."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"},{"line_number":200,"context_line":"                \u0027Target\u0027: target"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_514b4685","line":197,"updated":"2020-09-27 07:27:11.000000000","message":"The argument value should be validated against the values allowed by the service, and, if valid, converted from a sushy constant to a Redfish constant. Here is an example: https://github.com/openstack/sushy/blob/ee85feda89026875296c0be763e045e25641d6a0/sushy/resources/manager/manager.py#L183-L188.","commit_id":"719d852b913c426a9baed5c90e729cacf8de9676"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"02e8c707385754c0aaacbc573777ef1313c894b2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        :raises: BadRequestError on invalid target."},{"line_number":195,"context_line":"        :raises: ExtensionError on failure to perform requested"},{"line_number":196,"context_line":"            operation"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        action_data \u003d {"},{"line_number":199,"context_line":"            \u0027ShareParameters\u0027: {"},{"line_number":200,"context_line":"                \u0027Target\u0027: target"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f7bfeac6","line":197,"in_reply_to":"9f560f44_514b4685","updated":"2020-09-27 14:23:57.000000000","message":"Done","commit_id":"719d852b913c426a9baed5c90e729cacf8de9676"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f4fb943ee23273c3da0b0dca8fdb5e6c2cd7242e","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"                attempts -\u003d 1"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def get_allowed_export_system_config_values(self):"},{"line_number":185,"context_line":"        \"\"\"Get the allowed values of export system configuration."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        :returns: A set of allowed values."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_0ac21e54","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":47},"updated":"2020-09-29 08:15:44.000000000","message":"Are there unit tests added for this method?","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"aa4267d7972b0c9c50bc87f14fa19930cb39850a","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"                attempts -\u003d 1"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def get_allowed_export_system_config_values(self):"},{"line_number":185,"context_line":"        \"\"\"Get the allowed values of export system configuration."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        :returns: A set of allowed values."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_ec38a5cc","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":47},"in_reply_to":"9f560f44_0ac21e54","updated":"2020-09-29 12:29:07.000000000","message":"Done","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f4fb943ee23273c3da0b0dca8fdb5e6c2cd7242e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        export_action \u003d self._actions.export_system_configuration"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        if not export_action.allowed_values:"},{"line_number":192,"context_line":"            LOG.warning(\u0027Could not figure out the allowed values for the \u0027"},{"line_number":193,"context_line":"                        \u0027export system config action\u0027)"},{"line_number":194,"context_line":"            return set(mgr_maps.EXPORT_CONFIG_VALUE_MAP_REV)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        return set([mgr_maps.EXPORT_CONFIG_VALUE_MAP_REV[value] for value in"},{"line_number":197,"context_line":"                    set(mgr_maps.EXPORT_CONFIG_VALUE_MAP)."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_2ac5625d","line":194,"range":{"start_line":191,"start_character":0,"end_line":194,"end_character":60},"updated":"2020-09-29 08:15:44.000000000","message":"Is there an example of Dell system that does not have these values provided?\nThen better return empty list instead of all theoretically possible values. Otherwise consumer will not be able to distinguish when these are really supported and when couldn\u0027t find out. If empty list is returned, then consumer can deal with it in way it decides to.","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"aa4267d7972b0c9c50bc87f14fa19930cb39850a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        export_action \u003d self._actions.export_system_configuration"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        if not export_action.allowed_values:"},{"line_number":192,"context_line":"            LOG.warning(\u0027Could not figure out the allowed values for the \u0027"},{"line_number":193,"context_line":"                        \u0027export system config action\u0027)"},{"line_number":194,"context_line":"            return set(mgr_maps.EXPORT_CONFIG_VALUE_MAP_REV)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        return set([mgr_maps.EXPORT_CONFIG_VALUE_MAP_REV[value] for value in"},{"line_number":197,"context_line":"                    set(mgr_maps.EXPORT_CONFIG_VALUE_MAP)."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_4c46f152","line":194,"range":{"start_line":191,"start_character":0,"end_line":194,"end_character":60},"in_reply_to":"9f560f44_2ac5625d","updated":"2020-09-29 12:29:07.000000000","message":"Thanks Aija for giving direction for fetching the values from the correct field. I was extracting allowed values from the different fields, that\u0027s why I was getting an empty list.","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f4fb943ee23273c3da0b0dca8fdb5e6c2cd7242e","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :param target: Component of the system to export the"},{"line_number":207,"context_line":"            configuration from. Can be the entire system."},{"line_number":208,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":209,"context_line":"            found in Target.AllowableValues"},{"line_number":210,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":211,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":212,"context_line":"            the specified target."},{"line_number":213,"context_line":"        :raises: InvalidParameterValueError on invalid target."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_f5b35d4c","line":210,"range":{"start_line":208,"start_character":12,"end_line":210,"end_character":40},"updated":"2020-09-29 08:15:44.000000000","message":"update this comment saying that valid values can be get from `get_allowed_export_system_config_values` and what constants can be used as input params.","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"332af425d467eec72e43c17162567d6e10d9470c","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :param target: Component of the system to export the"},{"line_number":207,"context_line":"            configuration from. Can be the entire system."},{"line_number":208,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":209,"context_line":"            found in Target.AllowableValues"},{"line_number":210,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":211,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":212,"context_line":"            the specified target."},{"line_number":213,"context_line":"        :raises: InvalidParameterValueError on invalid target."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_fe1cc315","line":210,"range":{"start_line":208,"start_character":12,"end_line":210,"end_character":40},"in_reply_to":"9f560f44_18b8af0f","updated":"2020-09-29 16:32:16.000000000","message":"Done","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"042b1eca10680785a6dc7e3eb769041c0314ecce","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :param target: Component of the system to export the"},{"line_number":207,"context_line":"            configuration from. Can be the entire system."},{"line_number":208,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":209,"context_line":"            found in Target.AllowableValues"},{"line_number":210,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":211,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":212,"context_line":"            the specified target."},{"line_number":213,"context_line":"        :raises: InvalidParameterValueError on invalid target."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_18b8af0f","line":210,"range":{"start_line":208,"start_character":12,"end_line":210,"end_character":40},"in_reply_to":"9f560f44_6c9bf5c7","updated":"2020-09-29 15:03:17.000000000","message":"thanks, that was not meant to be precise text for the docstring. I meant to say that this needs documenting what constants exactly can be used otherwise it\u0027s not obvious. From my understanding consumer can use EXPORT_ALL, EXPORT_BIOS, etc. while they are supported by target system.\n\nSo the part that starts with \"valid values can be.. \" could be replaced with:\n\n\"Valid values can be get from `get_allowed_export_system_config_values` and correspond to EXPORT_* constants.\"","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"aa4267d7972b0c9c50bc87f14fa19930cb39850a","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :param target: Component of the system to export the"},{"line_number":207,"context_line":"            configuration from. Can be the entire system."},{"line_number":208,"context_line":"            Target values depend on the system, followings are the examples"},{"line_number":209,"context_line":"            found in Target.AllowableValues"},{"line_number":210,"context_line":"            ALL, BIOS, IDRAC, NIC, RAID."},{"line_number":211,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":212,"context_line":"            the specified target."},{"line_number":213,"context_line":"        :raises: InvalidParameterValueError on invalid target."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_6c9bf5c7","line":210,"range":{"start_line":208,"start_character":12,"end_line":210,"end_character":40},"in_reply_to":"9f560f44_f5b35d4c","updated":"2020-09-29 12:29:07.000000000","message":"Done","commit_id":"68ca05a39c823f12319cc6b80d41083ed379b8b8"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"b0c303e5edb24ae838ce6ecde8fb34c022b01a2c","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        allowed_values \u003d export_action.allowed_values["},{"line_number":192,"context_line":"            \u0027Target@Redfish.AllowableValues\u0027]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        return set([mgr_maps.EXPORT_CONFIG_VALUE_MAP_REV[value] for value in"},{"line_number":195,"context_line":"                    set(mgr_maps.EXPORT_CONFIG_VALUE_MAP)."},{"line_number":196,"context_line":"                    intersection(allowed_values)])"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7d06ce07_59f0e77f","line":194,"updated":"2021-03-12 08:59:03.000000000","message":"TODO: change EXPORT_CONFIG_VALUE_MAP_REV to EXPORT_CONFIG_VALUE_MAP","commit_id":"287f72b9e847f2deae54dbd4312cfe3897b84cc4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"632c374678a7d85ad297aa565dc044da6fcb519c","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                    set(mgr_maps.EXPORT_CONFIG_VALUE_MAP)."},{"line_number":196,"context_line":"                    intersection(allowed_values)])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def export_system_configuration(self, target):"},{"line_number":199,"context_line":"        \"\"\"Export system configuration."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        It exports system configuration for specified target"}],"source_content_type":"text/x-python","patch_set":15,"id":"50927043_5ef4e02a","line":198,"range":{"start_line":198,"start_character":42,"end_line":198,"end_character":48},"updated":"2021-03-08 14:44:06.000000000","message":"as discussed in the meeting, let\u0027s make this function private (rename to _export_system_configuration) as currently it will be used only from this library in the followup patch.\n\n(I\u0027ll work on public method in my patches.)","commit_id":"29a42a133224c458ee51639aeb47715f9ef59261"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"c4b016ac164cf4265a9bbf5d65118adb2459df91","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    set(mgr_maps.EXPORT_CONFIG_VALUE_MAP)."},{"line_number":196,"context_line":"                    intersection(allowed_values)])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def export_system_configuration(self, target):"},{"line_number":199,"context_line":"        \"\"\"Export system configuration."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        It exports system configuration for specified target"}],"source_content_type":"text/x-python","patch_set":15,"id":"de3bb962_83e69a51","line":198,"range":{"start_line":198,"start_character":42,"end_line":198,"end_character":48},"in_reply_to":"50927043_5ef4e02a","updated":"2021-03-10 04:37:29.000000000","message":"Done","commit_id":"29a42a133224c458ee51639aeb47715f9ef59261"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":206,"context_line":"            Valid values can be get from"},{"line_number":207,"context_line":"            `get_allowed_export_system_config_values` and correspond"},{"line_number":208,"context_line":"            to EXPORT_ALL, EXPORT_NIC, EXPORT_RAID, EXPORT_BIOS, EXPORT_BIOS"},{"line_number":209,"context_line":"            and EXPORT_IDRAC constants."},{"line_number":210,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":211,"context_line":"            the specified target."},{"line_number":212,"context_line":"        :raises: InvalidParameterValueError on invalid target."}],"source_content_type":"text/x-python","patch_set":16,"id":"440be6bf_e1633b2a","line":209,"updated":"2021-03-11 13:47:02.000000000","message":"remove \u0027and correspond\n            to EXPORT_ALL, EXPORT_NIC, EXPORT_RAID, EXPORT_BIOS, EXPORT_BIOS\n            and EXPORT_IDRAC constants\u0027","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            Valid values can be get from"},{"line_number":207,"context_line":"            `get_allowed_export_system_config_values` and correspond"},{"line_number":208,"context_line":"            to EXPORT_ALL, EXPORT_NIC, EXPORT_RAID, EXPORT_BIOS, EXPORT_BIOS"},{"line_number":209,"context_line":"            and EXPORT_IDRAC constants."},{"line_number":210,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":211,"context_line":"            the specified target."},{"line_number":212,"context_line":"        :raises: InvalidParameterValueError on invalid target."}],"source_content_type":"text/x-python","patch_set":16,"id":"e13dbfa3_718b11ee","line":209,"in_reply_to":"440be6bf_e1633b2a","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02bbcd090c99e24cf48709e1dfdbad29da2f254d","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        :param target: Component of the system to export the"},{"line_number":205,"context_line":"            configuration from. Can be the entire system."},{"line_number":206,"context_line":"            Valid values can be get from"},{"line_number":207,"context_line":"            `get_allowed_export_system_config_values`."},{"line_number":208,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":209,"context_line":"            the specified target."}],"source_content_type":"text/x-python","patch_set":19,"id":"e77768ea_45eea972","line":206,"range":{"start_line":206,"start_character":32,"end_line":206,"end_character":36},"updated":"2021-03-12 13:27:35.000000000","message":"nit: gotten","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"d2c8e63bd030c86120fb573bd495b491cba02199","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        :param target: Component of the system to export the"},{"line_number":205,"context_line":"            configuration from. Can be the entire system."},{"line_number":206,"context_line":"            Valid values can be get from"},{"line_number":207,"context_line":"            `get_allowed_export_system_config_values`."},{"line_number":208,"context_line":"        :returns: a response object containing configuration details for"},{"line_number":209,"context_line":"            the specified target."}],"source_content_type":"text/x-python","patch_set":19,"id":"8b15be6f_f7e12218","line":206,"range":{"start_line":206,"start_character":32,"end_line":206,"end_character":36},"in_reply_to":"e77768ea_45eea972","updated":"2021-03-12 13:50:13.000000000","message":"Done","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"}],"sushy_oem_idrac/resources/manager/mappings.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"155e0afc2a7764bafc7dc9d1aa91499ab6b7b66d","unresolved":true,"context_lines":[{"line_number":19,"context_line":"EXPORT_CONFIG_VALUE_MAP \u003d {"},{"line_number":20,"context_line":"    \u0027ALL\u0027: mgr_cons.EXPORT_ALL_CONFIG,"},{"line_number":21,"context_line":"    \u0027BIOS\u0027: mgr_cons.EXPORT_BIOS_CONFIG,"},{"line_number":22,"context_line":"    \u0027IDRAC\u0027: mgr_cons.EXPORT_IDRAC_CONFIG,"},{"line_number":23,"context_line":"    \u0027NIC\u0027: mgr_cons.EXPORT_NIC_CONFIG,"},{"line_number":24,"context_line":"    \u0027RAID\u0027: mgr_cons.EXPORT_RAID_CONFIG"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":14,"id":"3d0531c9_7a67942a","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":42},"updated":"2021-02-15 20:36:52.000000000","message":"ditto","commit_id":"8f46ad99c9c1a70e31e8699754be311b9059e7c5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02bbcd090c99e24cf48709e1dfdbad29da2f254d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"811f1fd5_86c77469","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2021-03-12 13:27:35.000000000","message":"2020-2021","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"d2c8e63bd030c86120fb573bd495b491cba02199","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"b6e8f284_1b3f7c08","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"811f1fd5_86c77469","updated":"2021-03-12 13:50:13.000000000","message":"Done","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"}],"sushy_oem_idrac/tests/unit/test_manager.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"a979cf49f70dec07215cddb0f3d7a88fef99fa6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f560f44_2c9fb002","line":79,"updated":"2020-09-22 20:00:33.000000000","message":"Please add a test to cover the except block which starts at https://review.opendev.org/#/c/710327/4/sushy_oem_idrac/resources/manager/manager.py@215.","commit_id":"7a2046d275bb658c500256cbd2a8d590c2d9ef86"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"042b1eca10680785a6dc7e3eb769041c0314ecce","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":72,"context_line":"    def test_export_system_configuration(self):"},{"line_number":73,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":74,"context_line":"        oem.export_system_configuration(target\u003d\"ALL\")"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.conn.post.assert_called_once_with("},{"line_number":77,"context_line":"            \u0027/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_38c5b35d","line":74,"range":{"start_line":74,"start_character":47,"end_line":74,"end_character":52},"updated":"2020-09-29 15:03:17.000000000","message":"nit: replace this with `EXPORT_ALL` constant so there is an example of using constants.","commit_id":"287f72b9e847f2deae54dbd4312cfe3897b84cc4"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"332af425d467eec72e43c17162567d6e10d9470c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":72,"context_line":"    def test_export_system_configuration(self):"},{"line_number":73,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":74,"context_line":"        oem.export_system_configuration(target\u003d\"ALL\")"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.conn.post.assert_called_once_with("},{"line_number":77,"context_line":"            \u0027/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_2352a836","line":74,"range":{"start_line":74,"start_character":47,"end_line":74,"end_character":52},"in_reply_to":"9f560f44_38c5b35d","updated":"2020-09-29 16:32:16.000000000","message":"Done","commit_id":"287f72b9e847f2deae54dbd4312cfe3897b84cc4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"042b1eca10680785a6dc7e3eb769041c0314ecce","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":87,"context_line":"    def test_get_allowed_export_system_config_values(self):"},{"line_number":88,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":89,"context_line":"        expected_values \u003d {\u0027IDRAC\u0027, \u0027RAID\u0027, \u0027ALL\u0027, \u0027BIOS\u0027, \u0027NIC\u0027}"},{"line_number":90,"context_line":"        allowed_values \u003d oem.get_allowed_export_system_config_values()"},{"line_number":91,"context_line":"        self.assertEqual(expected_values, allowed_values)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_181a6fc5","line":89,"range":{"start_line":89,"start_character":27,"end_line":89,"end_character":64},"updated":"2020-09-29 15:03:17.000000000","message":"use constants here as well to add some coverage for them as well","commit_id":"287f72b9e847f2deae54dbd4312cfe3897b84cc4"},{"author":{"_account_id":31418,"name":"Mahendra Kamble","email":"mahendra.kamble358@gmail.com","username":"MahendraKamble"},"change_message_id":"332af425d467eec72e43c17162567d6e10d9470c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":87,"context_line":"    def test_get_allowed_export_system_config_values(self):"},{"line_number":88,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":89,"context_line":"        expected_values \u003d {\u0027IDRAC\u0027, \u0027RAID\u0027, \u0027ALL\u0027, \u0027BIOS\u0027, \u0027NIC\u0027}"},{"line_number":90,"context_line":"        allowed_values \u003d oem.get_allowed_export_system_config_values()"},{"line_number":91,"context_line":"        self.assertEqual(expected_values, allowed_values)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_832c54b3","line":89,"range":{"start_line":89,"start_character":27,"end_line":89,"end_character":64},"in_reply_to":"9f560f44_181a6fc5","updated":"2020-09-29 16:32:16.000000000","message":"Done","commit_id":"287f72b9e847f2deae54dbd4312cfe3897b84cc4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":65,"context_line":"    def test_get_allowed_export_system_config_values(self):"},{"line_number":66,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":67,"context_line":"        expected_values \u003d {sushy_oem_idrac.EXPORT_IDRAC_CONFIG,"},{"line_number":68,"context_line":"                           sushy_oem_idrac.EXPORT_RAID_CONFIG,"},{"line_number":69,"context_line":"                           sushy_oem_idrac.EXPORT_ALL_CONFIG,"},{"line_number":70,"context_line":"                           sushy_oem_idrac.EXPORT_BIOS_CONFIG,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1441b6cf_72159462","line":67,"range":{"start_line":67,"start_character":27,"end_line":67,"end_character":42},"updated":"2021-03-11 13:47:02.000000000","message":"use management constant module here and elsewhere","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":65,"context_line":"    def test_get_allowed_export_system_config_values(self):"},{"line_number":66,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":67,"context_line":"        expected_values \u003d {sushy_oem_idrac.EXPORT_IDRAC_CONFIG,"},{"line_number":68,"context_line":"                           sushy_oem_idrac.EXPORT_RAID_CONFIG,"},{"line_number":69,"context_line":"                           sushy_oem_idrac.EXPORT_ALL_CONFIG,"},{"line_number":70,"context_line":"                           sushy_oem_idrac.EXPORT_BIOS_CONFIG,"}],"source_content_type":"text/x-python","patch_set":16,"id":"11893022_c2ea7335","line":67,"range":{"start_line":67,"start_character":27,"end_line":67,"end_character":42},"in_reply_to":"1441b6cf_72159462","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4c8ce38a056888390a3ac5d8a2d06b31aa399abc","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                                                \u0027ExportFormat\u0027: \u0027JSON\u0027})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":97,"context_line":"    def test_export_system_configuration_invalid_target(self):"},{"line_number":98,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":99,"context_line":"        target \u003d \"xyz\""},{"line_number":100,"context_line":"        self.assertRaises(sushy.exceptions.InvalidParameterValueError,"}],"source_content_type":"text/x-python","patch_set":16,"id":"81d1c718_d2baf27d","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":55},"updated":"2021-03-11 13:47:02.000000000","message":"nit: extra underscore - test__export_system_configuration_invalid_target","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"5d2e5bff487d2343b69e4e318b50bfd876f890b4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                                                \u0027ExportFormat\u0027: \u0027JSON\u0027})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":97,"context_line":"    def test_export_system_configuration_invalid_target(self):"},{"line_number":98,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":99,"context_line":"        target \u003d \"xyz\""},{"line_number":100,"context_line":"        self.assertRaises(sushy.exceptions.InvalidParameterValueError,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ed44504d_734c4fbb","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":55},"in_reply_to":"81d1c718_d2baf27d","updated":"2021-03-12 09:49:45.000000000","message":"Done","commit_id":"d6b41e765208a5a8769d2ac6f237bbb116621c5c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"02bbcd090c99e24cf48709e1dfdbad29da2f254d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"49ed477b_77a2ef23","line":2,"updated":"2021-03-12 13:27:35.000000000","message":"add for Dell so that in the end there is:\n\n# Copyright 2017 Red Hat, Inc.\n#\n# Copyright (c) 2020-2021 Dell Inc. or its subsidiaries.","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"},{"author":{"_account_id":25726,"name":"sonali bhausaheb borkar","email":"sonaliborkar85@gmail.com","username":"sonaliborkar85"},"change_message_id":"d2c8e63bd030c86120fb573bd495b491cba02199","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"a9a1b800_bedaa1b9","line":2,"in_reply_to":"49ed477b_77a2ef23","updated":"2021-03-12 13:50:13.000000000","message":"Done","commit_id":"65e70668b9a88152f9cba0ede75bfedad51b6e8f"}]}